Re: git: 8d8a745c456c - main - libutil: Drop auth_getval()

Am Tage des Herren Sat, 2 Aug 2025 17:57:02 GMT
Dag-Erling Smørgrav <des@FreeBSD.org> schrieb:

> The branch main has been updated by des:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=8d8a745c456cacf706689febee9639f5e8292fc8
> 
> commit 8d8a745c456cacf706689febee9639f5e8292fc8
> Author:     Dag-Erling Smørgrav <des@FreeBSD.org>
> AuthorDate: 2025-08-02 17:56:16 +0000
> Commit:     Dag-Erling Smørgrav <des@FreeBSD.org>
> CommitDate: 2025-08-02 17:56:35 +0000
> 
>     libutil: Drop auth_getval()
>     
>     This function has been an empty stub for years; now that we're bumping
>     the library version, we can finally get rid of it.
>     
>     Fixes:          0c381b7f0570
>     Reviewed by:    kib, emaste
>     Differential Revision:  https://reviews.freebsd.org/D51704
> ---
>  lib/libutil/Makefile   |  2 +-
>  lib/libutil/Symbol.map |  1 -
>  lib/libutil/auth.c     | 44 --------------------------------------------
>  lib/libutil/libutil.h  |  1 -
>  4 files changed, 1 insertion(+), 47 deletions(-)
> 
> diff --git a/lib/libutil/Makefile b/lib/libutil/Makefile
> index d445bc5dec3b..12ac623aec6b 100644
> --- a/lib/libutil/Makefile
> +++ b/lib/libutil/Makefile
> @@ -9,7 +9,7 @@ PACKAGE=	runtime
>  LIB=	util
>  SHLIB_MAJOR= 10
>  
> -SRCS=	_secure_path.c auth.c cpuset.c expand_number.c flopen.c fparseln.c \
> +SRCS=	_secure_path.c cpuset.c expand_number.c flopen.c fparseln.c \
>  	ftime.c getlocalbase.c gr_util.c \
>  	hexdump.c humanize_number.c kinfo_getfile.c \
>  	kinfo_getallproc.c kinfo_getproc.c kinfo_getvmmap.c \
> diff --git a/lib/libutil/Symbol.map b/lib/libutil/Symbol.map
> index d4bac5b5f53e..8c8fff451cd1 100644
> --- a/lib/libutil/Symbol.map
> +++ b/lib/libutil/Symbol.map
> @@ -2,7 +2,6 @@ FBSD_1.8 {
>  	_secure_path;
>  	auth_cat;
>  	auth_checknologin;
> -	auth_getval;
>  	auth_hostok;
>  	auth_timeok;
>  	auth_ttyok;
> diff --git a/lib/libutil/auth.c b/lib/libutil/auth.c
> deleted file mode 100644
> index 3414fc8e26e7..000000000000
> --- a/lib/libutil/auth.c
> +++ /dev/null
> @@ -1,44 +0,0 @@
> -/*-
> - * SPDX-License-Identifier: BSD-2-Clause
> - *
> - * Simple authentication database handling code.
> - *
> - * Copyright (c) 1998
> - *	Jordan Hubbard.  All rights reserved.
> - *
> - * Redistribution and use in source and binary forms, with or without
> - * modification, are permitted provided that the following conditions
> - * are met:
> - * 1. Redistributions of source code must retain the above copyright
> - *    notice, this list of conditions and the following disclaimer,
> - *    verbatim and that no modifications are made prior to this
> - *    point in the file.
> - * 2. Redistributions in binary form must reproduce the above copyright
> - *    notice, this list of conditions and the following disclaimer in the
> - *    documentation and/or other materials provided with the distribution.
> - *
> - * THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
> - * IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> - * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE
> - * ARE DISCLAIMED.  IN NO EVENT SHALL THE AUTHOR OR HIS PETS BE LIABLE
> - * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> - * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS
> - * OR SERVICES; LOSS OF USE, DATA, LIFE OR PROFITS; OR BUSINESS INTERRUPTION)
> - * HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> - * LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY
> - * OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF
> - * SUCH DAMAGE.
> - */
> -
> -#include <sys/cdefs.h>
> -#include <stdlib.h>
> -
> -#include <libutil.h>
> -
> -char *
> -auth_getval(const char *name)
> -{
> -
> -	(void)name;
> -	return (NULL);
> -}
> diff --git a/lib/libutil/libutil.h b/lib/libutil/libutil.h
> index 6d36a0c291c6..d27262e44daf 100644
> --- a/lib/libutil/libutil.h
> +++ b/lib/libutil/libutil.h
> @@ -86,7 +86,6 @@ struct termios;
>  struct winsize;
>  
>  __BEGIN_DECLS
> -char	*auth_getval(const char *_name);
>  void	clean_environment(const char * const *_white,
>  	    const char * const *_more_white);
>  int	expand_number(const char *_buf, int64_t *_num);
> 

A warning should be issued about transition of libutil.so.9 -> libutil.so.10!
make delete-old-libs has a great impact (as usual) on a running/working system regarding
python, perl, X11, claws-mail and other software. A quick and dirty (but working) workaround
was using the libmap.conf mechanism.

Kind regards,
oh

-- 

A FreeBSD user