git: 62473ce8ccba - main - pam_krb5: fix the GCC build

From: Lexi Winter <ivy_at_FreeBSD.org>
Date: Fri, 01 Aug 2025 14:15:09 UTC
The branch main has been updated by ivy:

URL: https://cgit.FreeBSD.org/src/commit/?id=62473ce8ccba20bad3e34f63448dba13433816e8

commit 62473ce8ccba20bad3e34f63448dba13433816e8
Author:     Lexi Winter <ivy@FreeBSD.org>
AuthorDate: 2025-08-01 14:05:58 +0000
Commit:     Lexi Winter <ivy@FreeBSD.org>
CommitDate: 2025-08-01 14:06:39 +0000

    pam_krb5: fix the GCC build
    
    GCC doesn't recognise
    -Wno-error=incompatible-pointer-types-discards-qualifiers.
    
    Remove it and just fix the error instead: our pam_message does not have
    a const msg member.
    
    Reviewed by:    cy, emaste
    Differential Revision:  https://reviews.freebsd.org/D51575
---
 contrib/pam-krb5/module/prompting.c  | 2 +-
 lib/libpam/modules/pam_krb5/Makefile | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/contrib/pam-krb5/module/prompting.c b/contrib/pam-krb5/module/prompting.c
index 506fb8fd2b22..8f9d8ef40d8e 100644
--- a/contrib/pam-krb5/module/prompting.c
+++ b/contrib/pam-krb5/module/prompting.c
@@ -157,7 +157,7 @@ pamk5_conv(struct pam_args *args, const char *message, int type,
         return PAM_CONV_ERR;
     pmsg = &msg;
     msg.msg_style = type;
-    msg.msg = (PAM_CONST char *) message;
+    msg.msg = (char *) message;
     pamret = conv->conv(1, &pmsg, &resp, conv->appdata_ptr);
     if (pamret != PAM_SUCCESS)
         return pamret;
diff --git a/lib/libpam/modules/pam_krb5/Makefile b/lib/libpam/modules/pam_krb5/Makefile
index c1792b5fb61d..7634930a7202 100644
--- a/lib/libpam/modules/pam_krb5/Makefile
+++ b/lib/libpam/modules/pam_krb5/Makefile
@@ -63,7 +63,6 @@ MLINKS=	pam-krb5.8 pam_krb5.8
 CFLAGS=	-I${SRCDIR} \
 	-I${.CURDIR} \
 	-fno-strict-aliasing \
-	-Wno-error=incompatible-pointer-types-discards-qualifiers \
 	-DHAVE_CONFIG_H
 
 WARNS?=	3