From nobody Fri Aug 01 14:15:05 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4btnyy0T0nz63wFR; Fri, 01 Aug 2025 14:15:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4btnyx6qNYz3jtr; Fri, 01 Aug 2025 14:15:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754057706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZqYZSUJJDupzT1emz+tH0InF3X6X7NN3C0P7CubXFA4=; b=HX3VtxJ6Iqzp6WnjJCrBxQSJTJqyKLbER88/7rFmnBnH9/fkU+PN0x8h6CKuzqNAoRwK50 gIFujJJ7A43/0rwdltIyAmjP38LYHdbbU6qR0Me2CqaQLmFIHc79Wokh+eLBkOB/QoH8Rj HUwghJd4cUqSM+BjY4nw9P7YlvZCmzQYcd6D+FyDfx0H3y3VJnC0dlYBX29UefBAK9qmeY JNVTnN6w/5vq7uPbMfreQZYuTaLoyS8YwU89b4boYNhsK2vY+EAgyWrqACwOPAjKePjuXD 379ovfw2+1duQFGfEO0VW+G9MxKspTpe8RsmnteqBD0iF7bCgwN/x0JEgbZFVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1754057706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=ZqYZSUJJDupzT1emz+tH0InF3X6X7NN3C0P7CubXFA4=; b=TGLJmJJ6pjFtK8c73T9zGDyB/KJebLMz/tIOKx/ZTzrKuwGX6LJGYGlpPnEFB+qC/mc41x nbCWDXJaDuy6J5dmU1DUSSNkJoPchG/eh/944N3gOj/AjRKZt5sUjPTYypiCoro6H1DYg3 xwye+Y2DTOGhQ9vJDrfQfJEqVuGYgKpS9IfWT8jme6VTDXCWjE7GbzH5r8k1+aiUT4kqSR qSb4OIjC7n2l1r3K9WvAORERiG5XIZu6e/sEZG1q9EJ9J5RqNyxJj+WRphf2qGhNG66Z7v EiS5qCcQQCd+Nd5Jf6+b963ArsEwy1CxvD/UfKy7EnHEmXg1IgHZA0Hhmlu4Pw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1754057706; a=rsa-sha256; cv=none; b=BHNsuyZqRMiO36ktFWdKsZhP79Rb7JVzb9rbN1RMZvuV7pEzoPGJtN2uPcRD4MMmSev02e kvoaLsZcm1AekiTYL/zpDXEaEBPXOyeS+Od94giG7X8R7m6Fx0+UUWi0wkMk7ZgDWesBXa BU0M15Yj8Bes4MZBRKN/SqxYS8L8KI6jrF8j+6GbDZSJuorK6lAnBDepAsqVcoN1VYPRls 5qvQgZbAulgaSmtzaVfh3CBWpDoH/xAsvqHWgAwH2wuWHhYrBygWdZO2xBRTL5/AwmfqBY levJdimMZKVxcY5ISinnOIK+bT+fvv+SPb6/3sLlGrIsdMR8jMB+/UBzynHOdg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4btnyx6BhZzrj4; Fri, 01 Aug 2025 14:15:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 571EF5bg039128; Fri, 1 Aug 2025 14:15:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 571EF57N039125; Fri, 1 Aug 2025 14:15:05 GMT (envelope-from git) Date: Fri, 1 Aug 2025 14:15:05 GMT Message-Id: <202508011415.571EF57N039125@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Lexi Winter Subject: git: 250bb6793a2b - main - bsnmp: fix undefined behaviour List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: ivy X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 250bb6793a2bc4d2530eb304ac4c4f03ea585985 Auto-Submitted: auto-generated The branch main has been updated by ivy: URL: https://cgit.FreeBSD.org/src/commit/?id=250bb6793a2bc4d2530eb304ac4c4f03ea585985 commit 250bb6793a2bc4d2530eb304ac4c4f03ea585985 Author: Lexi Winter AuthorDate: 2025-07-31 11:18:40 +0000 Commit: Lexi Winter CommitDate: 2025-08-01 14:06:39 +0000 bsnmp: fix undefined behaviour Modifying and using a variable without an intervening sequence point is undefined behaviour, which causes an error in the GCC build. Reviewed by: harti, emaste Differential Revision: https://reviews.freebsd.org/D51576 --- contrib/bsnmp/lib/snmpclient.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/contrib/bsnmp/lib/snmpclient.c b/contrib/bsnmp/lib/snmpclient.c index 44dfbd5a06b1..01e46480abb8 100644 --- a/contrib/bsnmp/lib/snmpclient.c +++ b/contrib/bsnmp/lib/snmpclient.c @@ -2096,7 +2096,9 @@ get_port(struct snmp_client *sc, const char *port[2]) return (NULL); } - return (port[1] = ++(port[0]) + strlen(port[0])); + ++port[0]; + port[1] = port[0] + strlen(port[0]); + return (port[1]); } /**