Re: git: ded037e65e52 - main - qat: driver updates to improve code and fix bugs

On Wed, Jul 30, 2025 at 02:29:37PM +0200, Kristof Provost wrote:
> On 6 Jun 2025, at 15:57, Mark Johnston wrote:
> > The branch main has been updated by markj:
> > 
> > URL: https://cgit.FreeBSD.org/src/commit/?id=ded037e65e5239671b1292ec987a2e0894b217b5
> > 
> > commit ded037e65e5239671b1292ec987a2e0894b217b5
> > Author:     Hareshx Sankar Raj <hareshx.sankar.raj@intel.com>
> > AuthorDate: 2025-05-07 09:38:21 +0000
> > Commit:     Mark Johnston <markj@FreeBSD.org>
> > CommitDate: 2025-06-06 13:43:54 +0000
> > 
> >     qat: driver updates to improve code and fix bugs
> > 
> >     Bug fixes and improvements are done for the qat code base
> >     to improve code quality.
> > 
> >     Reviewed by:    markj, ziaee
> >     MFC after:      2 weeks
> >     Sponsored by:   Intel Corporation
> >     Differential Revision:  https://reviews.freebsd.org/D50379
> > ---
> …
> > diff --git a/sys/dev/qat/qat_hw/qat_c3xxx/adf_c3xxx_hw_data.h
> > b/sys/dev/qat/qat_hw/qat_c3xxx/adf_c3xxx_hw_data.h
> > index bfc5db1f5e5c..cddfc3f84853 100644
> > --- a/sys/dev/qat/qat_hw/qat_c3xxx/adf_c3xxx_hw_data.h
> > +++ b/sys/dev/qat/qat_hw/qat_c3xxx/adf_c3xxx_hw_data.h
> > @@ -1,11 +1,11 @@
> >  /* SPDX-License-Identifier: BSD-3-Clause */
> > -/* Copyright(c) 2007-2022 Intel Corporation */
> > +/* Copyright(c) 2007-2025 Intel Corporation */
> >  #ifndef ADF_C3XXX_HW_DATA_H_
> >  #define ADF_C3XXX_HW_DATA_H_
> > 
> >  /* PCIe configuration space */
> > -#define ADF_C3XXX_PMISC_BAR 0
> > -#define ADF_C3XXX_ETR_BAR 1
> > +#define ADF_C3XXX_PMISC_BAR 1
> > +#define ADF_C3XXX_ETR_BAR 2
> >  #define ADF_C3XXX_RX_RINGS_OFFSET 8
> >  #define ADF_C3XXX_TX_RINGS_MASK 0xFF
> >  #define ADF_C3XXX_MAX_ACCELERATORS 3
> 
> We’re seeing panics loading the QAT driver on Atom Processor C3000 (with
> pfSense).
> 
> I believe this change is the trigger.
> This causes us to look for the ETR registers in the third BAR, but there are
> only two on that hardware:
> 
> 	# pciconf -l -b -vV pci0:1:0:0
> 	none0@pci0:1:0:0:	class=0x0b4000 rev=0x11 hdr=0x00 vendor=0x8086
> device=0x19e2 subvendor=0x8086 subdevice=0x19e2
> 	    vendor     = 'Intel Corporation'
> 	    device     = 'Atom Processor C3000 Series QuickAssist Technology'
> 	    class      = processor
> 	    bar   [18] = type Memory, range 64, base 0x80700000, size 262144,
> enabled
> 	    bar   [20] = type Memory, range 64, base 0x80740000, size 262144,
> enabled

Indeed, that portion of the change doesn't make a lot of sense.  I
posted a patch to revert it and will commit it soon if I don't hear
back: https://reviews.freebsd.org/D51664