From nobody Mon Apr 28 21:40:07 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZmcLH52g0z5twMF; Mon, 28 Apr 2025 21:40:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZmcLH1cwWz3fMy; Mon, 28 Apr 2025 21:40:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745876407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=f/E18QRLQpSasUc3USZo3psDfo2O3o/b7fr5AWzZ4IM=; b=UZUIVWOH+kJk8xBsgE/f9i5h9dPfMpfDk3uh0EtP5UK4qsvxh+VWMXp5/Jkk/EGPgHCfiu 1f20EgXuawtpF7GCP2k/BpDYemLT2pdcBQPNBluzjloV4QoXWRQxJopQV7LHYwFk13iTm+ hrSVqXzs6gvFZWXTEzq1gnvdq+cgcUqMuNOlHnIIukYbXmyp7sH/Rc9A61hY7BOvR5r4jS 2tmxRUiSPgNmfhiXUBKqsZ9gNidHQR3PfjaKi8SovX5pvCS5ehFmQ8o/G05awPRwTmjHz4 V9mdfHqiYCOmdDV8bHqx7i1se1ULJjyw/7xFAECwoClNz3fdeTLCX2gs4z8P3A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745876407; a=rsa-sha256; cv=none; b=yvPbdGiMZVQKTPCnhn7freFgxkyVIfyDrBKHz8Q3hT6kTr9s2SafTUb5OaT+JjOhXI576R gyBwqBz+sYa/pTNXlpDp1KfQX2CvSNzWS1rnwU7bK0S0ZWrx6Sel2v3E6gaQdPe8UcZ6CZ HOnevRpH2mzI/2B0uf6j3v/RuvLZhNmZTsaF6gI/4I7/VqSwwEWbgP5GxgxGI/DRtUCrxg yyTkNKV0/tHBrHtigUfOzK2y9n6tCQWBLzh7frreTvp+6V+SsHYm2klUlrNj4GzSOCjQxj jIMejCR7Ur9GmooIusPw6qt8rForu95ZIl4dY+YMYQUwH2edpx2qqA5wa1IP9g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745876407; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=f/E18QRLQpSasUc3USZo3psDfo2O3o/b7fr5AWzZ4IM=; b=DpGOJ7bLlfhqBmJgi5XkeiBMcHYkdLYg/l0VWBmV9VZB988d9F9TqMt8w+V+jq8a3VvuNo np7w09A9GxMLqxEUvMjy4rObMFwkSuE2i3FzTRES7TVyebfIuH0/lRvK9Y7yN5hF2/ex3F YZ3cWRR+sY1tYnoqEzK0RD9wngHrPEMg0pwAX/Gianfulte/x2SZXgkVAVHIE7+iZ4GGVZ iv7p2gBq3J6Wd6jjOfNFrEv2+ltc4o7haQV76U6Dz4v7KB+EY9SWboClILX8Cm2ixPe8VL 9kfAFz2xK0NJ8PUYr3WNanj4CPsRHh7gpHaD9rIhvRx88+JYZbRuigq9k664Sw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZmcLH1BH6zsbR; Mon, 28 Apr 2025 21:40:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53SLe7mM061977; Mon, 28 Apr 2025 21:40:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53SLe7c4061973; Mon, 28 Apr 2025 21:40:07 GMT (envelope-from git) Date: Mon, 28 Apr 2025 21:40:07 GMT Message-Id: <202504282140.53SLe7c4061973@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Vladimir Kondratyev Subject: git: 2abdb305bd0c - main - iichid(4): Do not send packets read in interrupt handler to hidbus List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: wulf X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 2abdb305bd0c105226f6a71a8d3dc89698c9ef6b Auto-Submitted: auto-generated The branch main has been updated by wulf: URL: https://cgit.FreeBSD.org/src/commit/?id=2abdb305bd0c105226f6a71a8d3dc89698c9ef6b commit 2abdb305bd0c105226f6a71a8d3dc89698c9ef6b Author: Vladimir Kondratyev AuthorDate: 2025-04-28 21:39:28 +0000 Commit: Vladimir Kondratyev CommitDate: 2025-04-28 21:39:28 +0000 iichid(4): Do not send packets read in interrupt handler to hidbus if no hidbus and hidbus clients were attached and opened by users. iichid(4) enables interrupts before hidbus is attached and sending packets to it at this time leads to panic at boot time. Fixes: daa098cc37b9 ("Wait for RESET command response while attaching") Tested by: dch PR: 286045 MFC with: daa098cc37b9 --- sys/dev/iicbus/iichid.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/dev/iicbus/iichid.c b/sys/dev/iicbus/iichid.c index b86858791a4d..9c0324a24685 100644 --- a/sys/dev/iicbus/iichid.c +++ b/sys/dev/iicbus/iichid.c @@ -630,7 +630,7 @@ iichid_intr(void *context) error = iichid_cmd_read(sc, sc->intr_buf, sc->intr_bufsize, &actual); THREAD_NO_SLEEPING(); if (error == 0) { - if (sc->power_on) { + if (sc->power_on && sc->open) { if (actual != 0) sc->intr_handler(sc->intr_ctx, sc->intr_buf, actual);