From nobody Mon Apr 28 12:23:44 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZmN0K0KLTz5vJ0r; Mon, 28 Apr 2025 12:23:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZmN0J4DZ7z3gCQ; Mon, 28 Apr 2025 12:23:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745843024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/emBpGNIUfYnwzEFS3Y1jLgY7ggelT4nBeaYiX4hREQ=; b=eMmY+d9IRNpsTPy149yMBF9jpXmgmZ4mgwKsKuvdpiE6sK72SLs8SObpJnlEmtyYdRfbrK CIlrnnQszDNG7XNCK63A4II1WU9o+OdrpEXBuVnqs/X0Gw/vrNHITL6b10lIOG/jCoJCRL usH3mUyMl/RGL362UMPt607UbwY9J8OsLseMgBEC9XKioUnbUu4Dy6UeLsNCRB1fE+bsSo h24aZosST24BUnRbJwCZIlX/7GkhOGeYRUKjCq1HlbI6WNyGYFNy8A9dLg+UW+Svk3GEi2 /QOKkstNc5Jd1fRCd8eQ5YfDCEGY++QDiTRKta59MhdY1Y91aS8aRrwwFvj8eQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745843024; a=rsa-sha256; cv=none; b=Lf2PzRLIzE3M039ScfBzznqRGiLn+/vzR7r0/JQeYDz7OxLfSvHTagumXdGNNt3KJXXQzo U/Fe10XP/g+lMDkZldgspIpFjf1h4K62vZe/3iKEDqicmOWhdMI5gHiYtAaMURBCIVPy5Y it7ZNNH2tzL7ZvMIkWjIIkP2lUkYTNKS35UyZVoiBsI1EhUgmaOWqoN8siWTLbPbVl3PAV 26dfSKguCKS9eRkRbcWwgvQHlfTSHoP7GlnxszaiC+t4mMvuDf4U55v7Wxoj2/UsiyQtJm 52FonFGucvQZmBBd5ROnFdZlPiLh/NNsbnq9/EQx2uOe6eyem38E04eQBNZj4Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745843024; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=/emBpGNIUfYnwzEFS3Y1jLgY7ggelT4nBeaYiX4hREQ=; b=afYGHlRyzlRrbIdc+ZAInMcbo7Z1AEB7vppII2UkDRhfliml6nQtgFt1fu9ok674Bsjlm2 csduoxSJCnkNNMrUFBe28OnEdDQGl/DZe5aXQFrrLdbV0h6KXZIO+LWLsmhFb4DhF4w9mb SwIpp0xT9BshJboL11juXDGVMVbzV3HZnimFooh319RPyWK3cRFt4hxAJxFUUeJBngt1OC voY998CY+ZDFHRsP/foZj7HaPj3gFR68QuFnTYCZwqYAVFHve264QfLNWthrN7IrIqH1Un cG0F546siHQx/cQ6swtr8cqmeyOJckEDQKd4QI5nB46EycHyc1BURiD0JvQ4Ag== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZmN0J2rr2zbhJ; Mon, 28 Apr 2025 12:23:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53SCNihY025906; Mon, 28 Apr 2025 12:23:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53SCNidf025902; Mon, 28 Apr 2025 12:23:44 GMT (envelope-from git) Date: Mon, 28 Apr 2025 12:23:44 GMT Message-Id: <202504281223.53SCNidf025902@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Olivier Certner Subject: git: 613d66b5e17d - main - queue(3): Wrap QMD_ASSERT()'s guard with __predict_false() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: olce X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 613d66b5e17d92e5304fdc9abe4c62ba015ebf31 Auto-Submitted: auto-generated The branch main has been updated by olce: URL: https://cgit.FreeBSD.org/src/commit/?id=613d66b5e17d92e5304fdc9abe4c62ba015ebf31 commit 613d66b5e17d92e5304fdc9abe4c62ba015ebf31 Author: Olivier Certner AuthorDate: 2025-04-22 14:26:22 +0000 Commit: Olivier Certner CommitDate: 2025-04-28 12:19:43 +0000 queue(3): Wrap QMD_ASSERT()'s guard with __predict_false() Such a guard is bound to be almost always false (obviously). Reviewed by: emaste (older version) MFC after: 3 days Sponsored by: The FreeBSD Foundation Differential Revision: https://reviews.freebsd.org/D49974 --- sys/sys/queue.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sys/sys/queue.h b/sys/sys/queue.h index b4814706cb76..a29ad6b94f03 100644 --- a/sys/sys/queue.h +++ b/sys/sys/queue.h @@ -208,7 +208,7 @@ struct qm_trace { #ifndef QMD_ASSERT #define QMD_ASSERT(expression, fmt, ...) do { \ - if (!(expression)) \ + if (__predict_false(!(expression))) \ QMD_PANIC("%s:%u: %s: " fmt, \ __FILE__, __LINE__, __func__, ##__VA_ARGS__); \ } while (0)