From nobody Mon Apr 28 00:13:54 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zm3pG0CMZz5vWtL; Mon, 28 Apr 2025 00:13:58 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zm3pF0d9mz41HS; Mon, 28 Apr 2025 00:13:57 +0000 (UTC) (envelope-from kevans@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745799237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jkyx2lOYITab2TXxHKXu1Tx45o4fJ9eSvsG4wJl+t1g=; b=mFIP0nl9meJNeucgyk7mGNyR6bjNOVZIpdL/QAUtf6EXgLvEWknBukee8uhETn2OulDuwO xEFhAGtl+QwU8DGlBGwuS63NDbD3n7E1s1Vo+P+Dud4RHHe6UxrNfFNstkZZgNEKpvBPkV Lom+gax/CQyf8uj8LQ0jr+21Ozx5x7Lwq/aurV1tFnxEinmYgymSvGKXumddTfmMozfbuU rmifF7dNc3AecP4nyCbRyFry8zY+ob/zMQxn4m4PasR7C2+4iELjD79y8w2OhDlPLuUs1v h64fewXxWQmLzvRZEGDOve5hCTSt+2UzO+oAx0F4ODNLJWtEWDwIbciqRwyPeQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745799237; a=rsa-sha256; cv=none; b=Y/ULOZGvSNAATiZSNdkgfk5ZFFI46a2P+oa+uJhVRcV4UnXIb5QrRqYs0WhBqXqYlyBERq JRRqtgkG4YEtjxBmrc9ps9pNwfqqh1cAhtxEsJuIv5o3xABS8gmoG5bEbFldVJd7UXFIbY SOgKED+PmjpWDOik7cNbw9kXnuxxkYWnVrhrwTBg9VdbbBBBpUCpyVjKe0zzsmnu8ICGfo 3LtxS3EeautNYh0xTAthsEAfJF8VdQLhgd6TTaReKCkGzK2C0pFdDcJDGF47Q/2VSptAq8 sIDXXxBsj8dklpcphALm2/pE37WXY12xxRNw/CaQUjyBZm65jXMh2XUuTTi0iQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745799237; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jkyx2lOYITab2TXxHKXu1Tx45o4fJ9eSvsG4wJl+t1g=; b=fTlqn8EcGTbzEloGzS28XYTdlcghVhfm+1PEHPxUxFwsfhf0xvFuGUShitxB/0I5A6bf53 tieTpmvIJSAbj4XRRAUe9rZMYscNE5ZkYgUTYnLczcgxnymnlsoU9Rgpi0uTdvAPbExLZk G7B6Ie1jl3Qt0Wa/0By3wCoR9EEeTnTkfPipqAqkS33TPDNm03poT+Pu2qD+lkEYF94jAO qFsz/3MH9IfA99IsFA2w1etx3mOrdx0THIKXjHkt3clZBzc+KfS54im+a7PlvzfDz0lrhn gyFZ9F0drkC+I+DNKCA/OazVbzL1ZWDUEoP5F1TzJx8ucuyu1y8i2lLelLsFKA== Received: from [10.9.4.95] (unknown [209.182.120.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: kevans/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Zm3pD46jrzlqL; Mon, 28 Apr 2025 00:13:56 +0000 (UTC) (envelope-from kevans@FreeBSD.org) Message-ID: <4fecf1e7-24a7-4cd4-9d37-1ad37335072e@FreeBSD.org> Date: Sun, 27 Apr 2025 19:13:54 -0500 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 8c7149c73f8f - main - wpa_supplicant: Handle systems without INET (legacy IP) support To: Cy Schubert , Marek Zarychta References: <202504280005.53S059jX040559@gitrepo.freebsd.org> Content-Language: en-US Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kyle Evans In-Reply-To: <202504280005.53S059jX040559@gitrepo.freebsd.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/27/25 19:05, Cy Schubert wrote: > The branch main has been updated by cy: > > URL: https://cgit.FreeBSD.org/src/commit/?id=8c7149c73f8f2301369f271c98470b72973b0c01 > > commit 8c7149c73f8f2301369f271c98470b72973b0c01 > Author: Marek Zarychta > AuthorDate: 2025-04-28 00:02:04 +0000 > Commit: Cy Schubert > CommitDate: 2025-04-28 00:04:45 +0000 > > wpa_supplicant: Handle systems without INET (legacy IP) support > > Currently, wpa_supplicant fails when legacy IP support is disabled > in FreeBSD (i.e., the world built with WITHOUT_INET and nooptions > INET in the kernel config). The proposed patch allows running > wpa_supplicant and connecting to wireless networks without INET > support when INET6 is available. > > Reviewed by: cy, adrian, philip, roy_marples.name > Differential Revision: https://reviews.freebsd.org/D49959 > --- It looks like we really only invoke interface ('i' group) ioctls on this socket, is there any particular reason we didn't just use a PF_LOCAL socket? It'd be less complex and match what ifconfig does for a lot of its work. Thanks, Kyle Evans > contrib/wpa/src/drivers/driver_bsd.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/contrib/wpa/src/drivers/driver_bsd.c b/contrib/wpa/src/drivers/driver_bsd.c > index 6efaa9c27ff2..d23d720789f9 100644 > --- a/contrib/wpa/src/drivers/driver_bsd.c > +++ b/contrib/wpa/src/drivers/driver_bsd.c > @@ -1800,9 +1800,19 @@ bsd_global_init(void *ctx) > > global->sock = socket(PF_INET, SOCK_DGRAM | SOCK_CLOEXEC, 0); > if (global->sock < 0) { > + if (errno == EAFNOSUPPORT) { > + wpa_printf(MSG_INFO, "INET not supported, trying INET6..."); > + global->sock = socket(PF_INET6, SOCK_DGRAM | SOCK_CLOEXEC, 0); > + if (global->sock < 0) { > + wpa_printf(MSG_ERROR, "socket[PF_INET6,SOCK_DGRAM]: %s", > + strerror(errno)); > + goto fail1; > + } > + } else { > wpa_printf(MSG_ERROR, "socket[PF_INET,SOCK_DGRAM]: %s", > strerror(errno)); > goto fail1; > + } > } > > global->route = socket(PF_ROUTE,