From nobody Wed Apr 23 15:19:44 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZjN7j24cMz5tWZ8; Wed, 23 Apr 2025 15:19:45 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZjN7h2Tbvz3bG4; Wed, 23 Apr 2025 15:19:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745421584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CrHiAFW39xru4PDOm5G5lG5RFn/cgqx/GNWlcFWlC24=; b=xfG4FWFZSCTiJ3LQ/UalhBYjrc/J8CztxqH/BBzLXho7ANMFvtoea7AgFrw6GnXQ/6S0tr YKUC8VrE866/Z8/hFUcqZCsZbmJyMeHrwqO9a/7SfLxy4BoKqlGaSdxHnHWR4V5lzzT4Z3 tWXNlUdJs5oSZmsConF/DI8MbdZ5vDVWFb5fK3bNgsMtGYgABOykZOhxqAaP+aV1Py+E7W 2kK6ctyIyaKVhvFFUAEehsyTgCIW1m4uX4yyDJfI3ZlS2aJf/7ZaYfwQAjdQ2cvKTl7A9/ NBlvyp1TE45E0wXK00l3h35g13t11JUU6N96E4I2O5tUFnrxaULqB5p2VbRl1g== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745421584; a=rsa-sha256; cv=none; b=ictEJ55XNU7WzDgrZuwvV9xYTzbrUo1fWNB1JoCZO+rAmsed44wDKHJ+eWJONrLwIIaNmP SW6Z31B1+PhJ6H99gLyNlzUDWtltqFnprwAAOGI43AMM7XxwmwoA/805RiyASfqZ5OVQl+ Ta5jub3DUTJY1+h5YjyGvM2GkxEgD//SwBgLfbKzj95l1mKg8LOZbVvCU8dLVM6r0AugyS GcHEmsSiyyLhU4PCtS7zkUHMVmdhZojS2y4Dqz99tigzoArt2DFHabIruKBF/e3KXp/tkl pWie0MydhVfveU7sSiO4p9+P/AGUwU1GUl1zajcmEpYu+dtYo/Q03ONjcz89PQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745421584; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=CrHiAFW39xru4PDOm5G5lG5RFn/cgqx/GNWlcFWlC24=; b=upK15Lo6188iBE6QIt1ZIDuPyndU+WSoIX1ykM9jFkNFQqaDV53p0ogzuSEjDiXFuUAiZP OiSzNoiswDav2Zc295fHCBi3gQZ3zmiepTDzISKJj8kmOIMajmajO5ghJenc/r7Qh8zlw5 rkcs+/who38MynuA7xiGQcjcZZmxwfpN+Vcin8amUUZ0o5OkXSWWitzTnsgY8Y6FiuRXw0 qV1iB2TxaXWn2WB+M9pE7Ihzyv9UfEWB3q9gHIZT1sqS45w7OAbQZFOwPWJmwB9vO1KR24 L7+k3mrelbmEyiueIZ6IeUs5PB7Evvx9Ch7nUS+vhqmbAeHOoHlQWQUvp76BGA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZjN7h259Cz18KX; Wed, 23 Apr 2025 15:19:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53NFJiO9052045; Wed, 23 Apr 2025 15:19:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53NFJibG052042; Wed, 23 Apr 2025 15:19:44 GMT (envelope-from git) Date: Wed, 23 Apr 2025 15:19:44 GMT Message-Id: <202504231519.53NFJibG052042@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Colin Percival Subject: git: ce9a34b1614e - main - Turn off hw.pci.intx_reroute in EC2 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: cperciva X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ce9a34b1614e37dc3f8763586448063408c7bf16 Auto-Submitted: auto-generated The branch main has been updated by cperciva: URL: https://cgit.FreeBSD.org/src/commit/?id=ce9a34b1614e37dc3f8763586448063408c7bf16 commit ce9a34b1614e37dc3f8763586448063408c7bf16 Author: Colin Percival AuthorDate: 2025-04-23 15:17:51 +0000 Commit: Colin Percival CommitDate: 2025-04-23 15:19:28 +0000 Turn off hw.pci.intx_reroute in EC2 Having this enabled on Graviton systems prior to Graviton 4 results in a resource leak and a kernel panic after repeated hotplug/unplug. MFC after: 3 days Sponsored by: Amazon --- release/tools/ec2.conf | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/release/tools/ec2.conf b/release/tools/ec2.conf index 507d9acabfd9..d6cb85959183 100644 --- a/release/tools/ec2.conf +++ b/release/tools/ec2.conf @@ -79,6 +79,12 @@ ec2_common() { # delay before rescanning upon device detach. echo 'debug.acpi.quirks="56"' >> ${DESTDIR}/boot/loader.conf + # The default behaviour of re-routing INTx interrupts causes a + # resource leak on INTRng (aka on Graviton systems). Repeated + # hotplug/unplug on PCI (not PCIe) Graviton systems ends up with + # a kernel panic unless we disable this. + echo 'hw.pci.intx_reroute=0' >> ${DESTDIR}/boot/loader.conf + # Load the kernel module for the Amazon "Elastic Network Adapter" echo 'if_ena_load="YES"' >> ${DESTDIR}/boot/loader.conf