From nobody Wed Apr 23 02:04:09 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zj2Tj5Rrjz5tXP7; Wed, 23 Apr 2025 02:04:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zj2Tj36fcz46fM; Wed, 23 Apr 2025 02:04:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745373849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lZf9BeMf3BQvminihkQIGL5kFSstK4LhZYMwafNB9HA=; b=s9NCBanuD77WoDkyFAo5G9PH0LzJFJXY8vo2F8lj6k0LysTPNv1TRZaXd5jowy8fJjJGvR OW+MLWoQy3YZZslVgQKWo4y5BQqa+29uTK+qo2BCN5uV6gFym8idncdjkuYymHX8gU5vpt Tb3ETMl2YiMC7pkhT+Y0gJ5dHu8Y2s19jndacOrEeswdtKEgzs07wEAkaaDqFPGQRrofIu /u6GKYwtXIPxIE0XBapH/G2IQhw8DfoSC2RW7VebnUFIZ+fhzVQj9nDxJeBAsU21Z967GG szPS9JeyI6yerpRIIU4V2lwdEyb+DJH30ffqyBeO6o/FfePsFB/j1ufiPouo8A== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745373849; a=rsa-sha256; cv=none; b=El63tBVwrauER+rchCWXPZlkITeH7TtEMjkyEYN9lj2wmpZc6etu6UGOW+vvpQOhYIMlQq WjALuBBE/08TjaDBc2qCkE6YFvLy0pvGWirz7pJdzu/EsT/RLH8QPmOzgIzDAtLXGifzKf GM7ITQbnTrw+RHoBoKepWFWfpD1QJNtdS6llm/MfGX0q9P2C47uZ5qKTJqNXg6Wi1EK7ie bgnoBzv4a5y45eUQH/ycGg2Q0WSkRhueir1TKZh+TeDsJpBzTgZEMENBXx6t/yBb0nCqOS mWfjif9InSCH15Ov95oXiOde4yczt4yVJIXg59Jb9z+BEH2MnnXK2uZIg4GUxg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745373849; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lZf9BeMf3BQvminihkQIGL5kFSstK4LhZYMwafNB9HA=; b=CAADzv66Licdxeze/OOQ1C5otNhIUbTUjrdcUXHAGeG4fmqOzPsc2D390TTgr+dDK0d9nd Juc9dCyaTEcqeY3P7tca76DJUSw+ygpUmEtgQzEY18Gejr6ClpAeNQK1JWdOzme9jiXUlh wDf4mmdShFMmGjv+Rej9DmgLAr+ZszZgMDr16U28BQAv2psQZTSrs8GU6GMnse6Mfgn08O NCR2kHr6QKI1ylHdyT7tQfIvfbGgiuOssq04b+PY+ZBlblGpkd8lPGRtTXpi89/0PLfYoG efPFysNEn7qAOgO4w5SikSZb0AtK7yw1sPmcJE2HJ7pwrSLFqsOhJ1keuLP40g== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zj2Tj2YDPzlT5; Wed, 23 Apr 2025 02:04:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53N249xi070223; Wed, 23 Apr 2025 02:04:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53N249Y3070220; Wed, 23 Apr 2025 02:04:09 GMT (envelope-from git) Date: Wed, 23 Apr 2025 02:04:09 GMT Message-Id: <202504230204.53N249Y3070220@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: d5f5193e2db9 - main - rtwn: don't treat UDP/TCP checksum failure as permanent failure List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: d5f5193e2db974576120b5e5f559970a6c15247d Auto-Submitted: auto-generated The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=d5f5193e2db974576120b5e5f559970a6c15247d commit d5f5193e2db974576120b5e5f559970a6c15247d Author: Adrian Chadd AuthorDate: 2025-04-01 23:57:41 +0000 Commit: Adrian Chadd CommitDate: 2025-04-23 02:02:47 +0000 rtwn: don't treat UDP/TCP checksum failure as permanent failure jrtc27@freebsd.org reported that DHCP wasn't working on some networks. She dug into it and found that the RTL8812AU/RTL8812AU NICs seem to be failing UDP frames w/ a zero checksum, which is a valid "there's no checksum" checksum. So, just pass those frames up the stack and let the IP stack deal with it. If the hardware claims the frames did pass TCP/UDP checksum then still mark those frames with the checksum offload bits. PR: kern/285387 Differential Revision: https://reviews.freebsd.org/D49628 --- sys/dev/rtwn/rtl8812a/r12a_rx.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/sys/dev/rtwn/rtl8812a/r12a_rx.c b/sys/dev/rtwn/rtl8812a/r12a_rx.c index 805775033fd1..b2e02998de49 100644 --- a/sys/dev/rtwn/rtl8812a/r12a_rx.c +++ b/sys/dev/rtwn/rtl8812a/r12a_rx.c @@ -190,8 +190,16 @@ r12a_check_frame_checksum(struct rtwn_softc *sc, struct mbuf *m) (rxdw1 & R12A_RXDW1_IPV6) ? "IPv6" : "IP", (rxdw1 & R12A_RXDW1_CKSUM_ERR) ? "invalid" : "valid"); + /* + * There seems to be a problem with UDP checksum processing + * with the checksum value = 0 (ie, no checksum.) + * So, don't treat it as a permament failure; just let + * the IP stack take a crack at validating frames. + * + * See kern/285837 for more details. + */ if (rxdw1 & R12A_RXDW1_CKSUM_ERR) - return (-1); + return (0); if ((rxdw1 & R12A_RXDW1_IPV6) ? (rs->rs_flags & R12A_RXCKSUM6_EN) :