From nobody Wed Apr 23 02:04:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zj2Th2prpz5tXX3; Wed, 23 Apr 2025 02:04:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zj2Th2414z46nq; Wed, 23 Apr 2025 02:04:08 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745373848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OIeBerWK2z3yZaDpwKBkGnd//fEVMq82557EyhGRy1E=; b=EvPalMm2zjdkFw7+APmZVCieW1IvQk+J+JM3ZyXBAl7fxZE039dgQJmtotZupdALADD5a0 vsYyzsCXlo3/NjzyxkkIpLXyMBkDLv5w5lg2fRCOdi0xshgbhnPZRtaO6lzc3X59xRo1oZ 6+aeQ70yr7gzmfl0F46bCTt9t44Q8tRrSP6mAEB5CEl0BN39nIGSpTFy8E/MjAsj7ZACX3 yW6bWEX+jUjYqYtpmU3ogVLv5eIJz84tkBgOvgjQj68HTd4RQ33P/yGazW2lRbLHbijNM1 JPA2c0iI0w6ZRvK5LDKPoG8CppIL9BCOJmt4ScOmuYfQUPkWnbV+g2aa04OOPw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745373848; a=rsa-sha256; cv=none; b=m1gUwvz4wURpzV82yPHApnqM3FWhsCkeBB31NmvEl5jeoob9caX/h0SVLdv7d3KTZwGoRN RN9nmeU4TI0yl8cmD6QdNgIL5h/D5Nsi1fA5UssVxDQ48KD8QTW2rmTdefbnGrR5djACdf tm/6bl5nNtnAGDJ01NL6B1VPcFqCtuQHSGrVW2vE3WUcQKIVRUzNj1kQmdtCJpt9UeCOzu hEKTsWFkQVktkV86GLPHRYt5JdRa1pQ8fTGasZL+Wd+ypDrWsp2UgVrfpf7MlotEr5zoCh ophDm/v6cssBByzBF0QrCEk2rYCMHS88vq/VvRkSF2KivBvIG5Vbgw1rGMJ86A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745373848; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=OIeBerWK2z3yZaDpwKBkGnd//fEVMq82557EyhGRy1E=; b=avKWDjsm8buWQDqxNQZ9yvKHGhTqCL8Eqlh30sI8YwTmKgjkuFiwMUvkA+SRMT91n1YEo1 Fw/GAPmTRSPFikG4oeA5g59QjBIQzMNXnfefOf5kwInJjdwXQKndIOG3tfe6Ll8cykQHXN Zt2b71Orr1b5jrvzpFW4xidV66zL6F7yg711fnysZL5BtekuzjyO0OgkqRHg6VuQqiUvTK F1q87vIL/G4d88tLlh7bYULIc8de5qGmgo5ba7D1f25GsFrtbie72Syzi6CX9zYYgWUinX 88oD3QlFfZ0IOBEHDI7W1Z6AvScVyVE49sSJA1DYWE3faEnNfW3ZRars68JNrA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zj2Th1cq8zlJp; Wed, 23 Apr 2025 02:04:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53N248YR070188; Wed, 23 Apr 2025 02:04:08 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53N248Jb070185; Wed, 23 Apr 2025 02:04:08 GMT (envelope-from git) Date: Wed, 23 Apr 2025 02:04:08 GMT Message-Id: <202504230204.53N248Jb070185@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Adrian Chadd Subject: git: 5c74aa3abd4e - main - rtwn: enable reception of BAR frames List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: adrian X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 5c74aa3abd4e353ed7f8cb446c0527c8ebe15d1c Auto-Submitted: auto-generated The branch main has been updated by adrian: URL: https://cgit.FreeBSD.org/src/commit/?id=5c74aa3abd4e353ed7f8cb446c0527c8ebe15d1c commit 5c74aa3abd4e353ed7f8cb446c0527c8ebe15d1c Author: Jessica Clarke AuthorDate: 2025-04-01 00:43:13 +0000 Commit: Adrian Chadd CommitDate: 2025-04-23 02:02:39 +0000 rtwn: enable reception of BAR frames The RX filter wasn't enabling BAR frames, so we weren't receiving them during normal operation. Jessica noticed we WERE getting BAR frames, but only when promisc mode is active. Which is a different set of bugs, but it did highlight the differences here. Differential Revision: https://reviews.freebsd.org/D49596 PR: kern/285822 --- sys/dev/rtwn/if_rtwn.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sys/dev/rtwn/if_rtwn.c b/sys/dev/rtwn/if_rtwn.c index 7df1b78db37b..7a547e13cafa 100644 --- a/sys/dev/rtwn/if_rtwn.c +++ b/sys/dev/rtwn/if_rtwn.c @@ -1203,6 +1203,9 @@ rtwn_newstate(struct ieee80211vap *vap, enum ieee80211_state nstate, int arg) /* Stop Rx of data frames. */ rtwn_write_2(sc, R92C_RXFLTMAP2, 0); + /* Stop Rx of control frames. */ + rtwn_write_2(sc, R92C_RXFLTMAP1, 0); + /* Reset EDCA parameters. */ rtwn_write_4(sc, R92C_EDCA_VO_PARAM, 0x002f3217); rtwn_write_4(sc, R92C_EDCA_VI_PARAM, 0x005e4317); @@ -1374,6 +1377,11 @@ rtwn_run(struct rtwn_softc *sc, struct ieee80211vap *vap) rtwn_write_2(sc, R92C_BCN_INTERVAL(uvp->id), ni->ni_intval); if (sc->vaps_running == sc->monvaps_running) { + /* Enable Rx of BAR control frames. */ + rtwn_write_2(sc, R92C_RXFLTMAP1, + 1 << (IEEE80211_FC0_SUBTYPE_BAR >> + IEEE80211_FC0_SUBTYPE_SHIFT)); + /* Enable Rx of data frames. */ rtwn_write_2(sc, R92C_RXFLTMAP2, 0xffff);