From nobody Mon Apr 21 14:42:40 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zh7Pt2Pdlz5tZRp; Mon, 21 Apr 2025 14:42:42 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zh7Ps4xWbz3gCQ; Mon, 21 Apr 2025 14:42:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745246561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=creJ3TyZEfKVtjaenY+HcokaEV6XUkgMY5aseDhbV5A=; b=GjXH2NeiSFsc2SGMdTtd+zBvzm+HyOqH3yA/J+/dPw/dAs2HWyRVz/LKKqFFvrvSCKORjf H5wrofq+IIwOgD+L3SaE7hqfVJjTvfzHa68BH8JetCdFToX38uZnH5wc/1Ds96wp/D4vkP tQExpREBws9dD4EKyjtec4MEQEnM1WWbdZQLKLAB/qUeiC+VG69AsIfjn3E61V6TsdrkVK rjPKKRmRcnjwX9+28S413pGS5KKl+AIQ0sjdtDrZkD7QF9i7NNijHUL0CmMcSax0fln28/ 6ZSa0DALtwFgc9X5dEiNJRfK/D42JgjyuJRtzbSEQWmk9eoG8lD2+/AQr3dAog== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745246561; a=rsa-sha256; cv=none; b=o1F4QjJepeFjZPTSkfHfzbUwGzYiGoJBxYKAdbb3C6wKRl8HVAy9lnKpYM5xf5m8NocaQZ abtOq1aBWXsjvO6KXfi0Fni/8YeHwHdhHDYJ4jxTuUX81kivD4Wl76JPUSUOdaVDN+NTzg VZEhJDQuhkBcogNnGWhQDVyT/b2njAG77AMQLHE47UvGI27PN8vxRc12mRGJUHrcVvbmrj KNcdYX+Yo4rbQZqmMAqsBnBgOoenx28m6HcFSpkgI1FhCML2uduLnjR3C87HWUX72J7TqX cyN/NjlLsgzFi83u2ZdzPx/wiBioC+5dTxG/8QyM2kcWC/8c4irmwluS2aR73A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745246561; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=creJ3TyZEfKVtjaenY+HcokaEV6XUkgMY5aseDhbV5A=; b=pfjJxoD5dSztEZi+3tVux0Y4Oq+JJEr9BP5tFlLxDmBIKi5FOSXeRkcPimW78XjaMJxp55 GkpdoUQFMM5zYxf8BhI6Fu6oh2+Iysu8YXMmAH92pkpND5YaSNIwBp4KUx/3EXAXmm/uEc Y7VM7RLyUtYfpWY+LycOwp+YFRnF7x5/1yWZqrnO68F6FYM1BxlaWvzQ/ANbVfWfvi9dkO vQ/24B+HZ1cXaO8gJryfaU78GMsdikMfmdjJRR31sHtErEBffII4506pY+RoAEpoLwiMt4 5UeAn/jAZZEH0kEoPMIFreIDQmGH7ma/U9ADYbLUWFcqDrKeOsuNyy4OXX1HWQ== Received: from [IPV6:2601:5c0:4200:b830:da:dbef:6846:200] (unknown [IPv6:2601:5c0:4200:b830:da:dbef:6846:200]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Zh7Ps3H7fzMsF; Mon, 21 Apr 2025 14:42:41 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <2e182af1-19b6-4b10-9575-c549d766e086@FreeBSD.org> Date: Mon, 21 Apr 2025 10:42:40 -0400 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: b7527823fdcc - main - vm_page: Bump __FreeBSD_version for removal of vm_page_next() and _prev Content-Language: en-US To: Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org References: <202504191356.53JDu2Zc011615@gitrepo.freebsd.org> <4a521ab3-8a40-4be6-bb06-51ca4e15febe@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/21/25 10:27, Mark Johnston wrote: > On Mon, Apr 21, 2025 at 10:23:21AM -0400, John Baldwin wrote: >> On 4/19/25 09:56, Mark Johnston wrote: >>> The branch main has been updated by markj: >>> >>> URL: https://cgit.FreeBSD.org/src/commit/?id=b7527823fdcc29f0da9c17152dbb062eeb18244d >>> >>> commit b7527823fdcc29f0da9c17152dbb062eeb18244d >>> Author: Mark Johnston >>> AuthorDate: 2025-04-19 13:49:48 +0000 >>> Commit: Mark Johnston >>> CommitDate: 2025-04-19 13:55:37 +0000 >>> >>> vm_page: Bump __FreeBSD_version for removal of vm_page_next() and _prev >>> Out-of-tree code needs to be modified to use iterators after commit >>> a3a88ed22cb1. >>> Fixes: a3a88ed22cb1 ("vm_page: drop prev and next") >> >> Hmm, would it be better for out-of-tree code to use the __FreeBSD_version that >> introduces the new API as the version to switch behavior on rather than the >> removal of the old API? I tend to follow this practice when patching ports for >> API changes in new-bus, etc. > > In this case, I'm not sure that would be better: the iterator interface > has changed a bit since it was introduced and in particular the layout > of the iterator structure -- part of the KBI -- has changed since it was > introduced. So, using an old value of __FreeBSD_version felt a bit > sketchy here. Ok, fair enough. -- John Baldwin