From nobody Mon Apr 21 14:27:09 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zh7423qWrz5tYBV; Mon, 21 Apr 2025 14:27:14 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qv1-xf2e.google.com (mail-qv1-xf2e.google.com [IPv6:2607:f8b0:4864:20::f2e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zh7416MbBz3Wck; Mon, 21 Apr 2025 14:27:13 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qv1-xf2e.google.com with SMTP id 6a1803df08f44-6e8f05acc13so53967216d6.2; Mon, 21 Apr 2025 07:27:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1745245632; x=1745850432; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=wTznqzVgA4dG6txyyqYVSjphm2r3xHE2g26rFq4ydpw=; b=AENvnZ98GkFikxbmXHj427xfGFoa6XeHjqXXWbdDDBIQGZr9abbUM46AIJcuhqaoUR 3b8zuMbzKoUehErigi8imU6gG3nzasTrN7ANMm5sydGquN9DFht2xqchz1V2T43HvmYc 2jcHXh+xLYRLgpyB97JddIQ9iJuJ1GAl35oX7HqXtAn53TRu0Johziy9AtO3WMMaYBZM inJgFgggHTqR8T3cvMEUiFUm4G/u/fl9ZyIgqlVws6VEgmpo3xnYdIlatbcLuoHpz8Wi nXXSTZMw7UhmCnEiutNj6lw6FPBeXR3VeENhokMw89nQH346UrhbiP0Md7LBDtwnCFUn mSHA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745245632; x=1745850432; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wTznqzVgA4dG6txyyqYVSjphm2r3xHE2g26rFq4ydpw=; b=DpS/pqQqUQfrFO2b3L3vZ2vmOMWXqEByzofmJiGbLAxmN99nLpS8XR9Z4Ch6r/tyP2 3DF97JHf9sIk/Cw7M5JZ4/ACOhwtbsUmfbP+rzZ0oIcVoTlBSTWqkOlZ+yjDwd8ptI9e 9Zq5N7QvTtp18gfje2y43Z8Klcbkadg/AfAXupUWWaZYatbhtHpqSvjuRAbAaYccPw+m yrBm4SUcF3LjTfTcbABrGGds38ydB2LAEPeOIE9LxuNU1M0/7FwETJiexHOEX25OipcK Hc0FNfkjwoGSLFvcrwzPWWOoRg74QHGdF1UYyRWXzOxhWnBeL4cLhNluVI06MzYBNCBJ QemQ== X-Forwarded-Encrypted: i=1; AJvYcCVSpcsghw5DWpDL/f5LX38MChO3rub+50xDN90LLRqwPq+YMknLILXEUXV1909OLGRY72Nic4rSqCoSqdWo+VRvvCJ7HBQ=@freebsd.org, AJvYcCVg/uO1hEPOTtBGOYzaYhdQ5TVCZZKYCe7nfZ92FYV23CHp9OYygYxc37BlQ1GfmH2taQStSdHKJGBqd+tvleDZMw7k@freebsd.org X-Gm-Message-State: AOJu0YzZKhVB+mFBIVz1SgKxUkKZoug5k5VPKMRj8gB1+35m6ixeSUYt OS6M7ChIAlGbZ7jN45S2/BtlInPzV/e2iF/Xuy2VyfCRwZGX1cpF+N0JVatu X-Gm-Gg: ASbGncvzkmvLC5sJTc7Peju6cGVIMiYpAeY9FFZ6hovqlylNxNmsCjDuQARJZZ5qNKH bLvG8IcYZ5pm6tvdr8M1zfGfe1wkWQlfROqA+ndWUZSFYaWWUu6jFRL4cfWELv7xFXRB+3jwfWQ lxquxHQE3aor5/0ebS/urZ3ZOH1Y/8U+gmEfkFG2jcoWir5M2+dz/HuLrj68guB8GSFO3brVzcm /FoitqT2E2Y/SSBroEsMCPzgwbSkUYQI8kQYzCNQJuKd7anGWTv3Zcl6BpuXA33OEZ7r9+IZFdT MqFmiey8gqNgfIvV3bMgfObbjSVRYUBAaFVZuhC5RxRV4dL1oYtHrrrl5iGXCDrvjg== X-Google-Smtp-Source: AGHT+IEoft3Q+oPM3ZE7CJnIX3c7y4a7PiN+SflSRBgBGn6R7lHCd/DYV6MO6smSYaIOq3tqNOMHUg== X-Received: by 2002:a05:6214:c64:b0:6ea:d393:9634 with SMTP id 6a1803df08f44-6f2c44e6184mr216452496d6.3.1745245631984; Mon, 21 Apr 2025 07:27:11 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6f2c2af1722sm44351446d6.11.2025.04.21.07.27.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Apr 2025 07:27:11 -0700 (PDT) Date: Mon, 21 Apr 2025 10:27:09 -0400 From: Mark Johnston To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: b7527823fdcc - main - vm_page: Bump __FreeBSD_version for removal of vm_page_next() and _prev Message-ID: References: <202504191356.53JDu2Zc011615@gitrepo.freebsd.org> <4a521ab3-8a40-4be6-bb06-51ca4e15febe@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4a521ab3-8a40-4be6-bb06-51ca4e15febe@FreeBSD.org> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4Zh7416MbBz3Wck X-Spamd-Bar: ---- On Mon, Apr 21, 2025 at 10:23:21AM -0400, John Baldwin wrote: > On 4/19/25 09:56, Mark Johnston wrote: > > The branch main has been updated by markj: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=b7527823fdcc29f0da9c17152dbb062eeb18244d > > > > commit b7527823fdcc29f0da9c17152dbb062eeb18244d > > Author: Mark Johnston > > AuthorDate: 2025-04-19 13:49:48 +0000 > > Commit: Mark Johnston > > CommitDate: 2025-04-19 13:55:37 +0000 > > > > vm_page: Bump __FreeBSD_version for removal of vm_page_next() and _prev > > Out-of-tree code needs to be modified to use iterators after commit > > a3a88ed22cb1. > > Fixes: a3a88ed22cb1 ("vm_page: drop prev and next") > > Hmm, would it be better for out-of-tree code to use the __FreeBSD_version that > introduces the new API as the version to switch behavior on rather than the > removal of the old API? I tend to follow this practice when patching ports for > API changes in new-bus, etc. In this case, I'm not sure that would be better: the iterator interface has changed a bit since it was introduced and in particular the layout of the iterator structure -- part of the KBI -- has changed since it was introduced. So, using an old value of __FreeBSD_version felt a bit sketchy here.