From nobody Mon Apr 21 07:09:08 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZgxLd2SqZz5t4xW; Mon, 21 Apr 2025 07:09:13 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta004.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZgxLb1jjDz3qB7; Mon, 21 Apr 2025 07:09:11 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=permerror reason="p tag has invalid value: quarantine rua=mailto:p[ostmaster@cschubert.com" header.from=cschubert.com (policy=permerror); spf=pass (mx1.freebsd.org: domain of cy.schubert@cschubert.com designates 3.97.99.33 as permitted sender) smtp.mailfrom=cy.schubert@cschubert.com Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTPS id 6VjcuvuER5Mqy6lHCuPIJ7; Mon, 21 Apr 2025 07:09:10 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id 6lHAurVE1JhBP6lHBuCvgE; Mon, 21 Apr 2025 07:09:10 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=QY3Fvdbv c=1 sm=1 tr=0 ts=6805ef16 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=XR8D0OoHHMoA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=p1V55uMdNdPVWb8m0XAA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id 6BECD1AF3; Mon, 21 Apr 2025 00:09:08 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 65A1C202; Mon, 21 Apr 2025 00:09:08 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Doug Moore cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org, manu@freebsd.org Subject: Re: git: a3a88ed22cb1 - main - vm_page: drop prev and next In-reply-to: <202504181927.53IJRsoQ035803@gitrepo.freebsd.org> References: <202504181927.53IJRsoQ035803@gitrepo.freebsd.org> Comments: In-reply-to Doug Moore message dated "Fri, 18 Apr 2025 19:27:54 +0000." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Mon, 21 Apr 2025 00:09:08 -0700 Message-Id: <20250421070908.65A1C202@slippy.cwsent.com> X-CMAE-Envelope: MS4xfB+w0m2maEH+JdY8vXAH32iwmnAz8LYRJRgDX4gyOI33mXo97oZU5SAZlHWZB0Wcna6eE73alFsb/X4QSa1gS5NGP4zY6XBWUY2Hd+DcR0TBbOch15yM yFTdCiAgzVsijl4aDvBRkf+QFKSLU1A11/x3g0820I9hD1EBJoF2u6X5swChcvKrF2DKIOmL+Tq4yW7ntkMCVDeva7bRpZZyQZLYFfjI0BinW+OM3UG/8l1+ W6u+QDAw2iRkkJhSe7YIgg8m9//N3rsemyjlCTBP4H436nZStE8r5yOodVAX8WwtONs77LZfKD19FH1IVxPQtzrMyGszUx0zkZ/JV9vl9sBClEyi3marwozT Z1iadJbp X-Spamd-Result: default: False [-0.86 / 15.00]; NEURAL_HAM_SHORT(-0.54)[-0.542]; NEURAL_HAM_MEDIUM(-0.54)[-0.536]; NEURAL_SPAM_LONG(0.52)[0.516]; MV_CASE(0.50)[]; RWL_MAILSPIKE_EXCELLENT(-0.40)[3.97.99.33:from]; R_SPF_ALLOW(-0.20)[+ip4:3.97.99.32/31]; RCVD_IN_DNSWL_LOW(-0.10)[3.97.99.33:from]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US]; DMARC_BAD_POLICY(0.00)[cschubert.com : p tag has invalid value: quarantine rua=mailto:p[ostmaster@cschubert.com]; HAS_REPLYTO(0.00)[Cy.Schubert@cschubert.com]; RCPT_COUNT_FIVE(0.00)[5]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MLMMJ_DEST(0.00)[dev-commits-src-main@freebsd.org,dev-commits-src-all@freebsd.org]; RCVD_TLS_LAST(0.00)[]; R_DKIM_NA(0.00)[]; REPLYTO_EQ_FROM(0.00)[] X-Rspamd-Queue-Id: 4ZgxLb1jjDz3qB7 X-Spamd-Bar: / In message <202504181927.53IJRsoQ035803@gitrepo.freebsd.org>, Doug Moore writes : > The branch main has been updated by dougm: > > URL: https://cgit.FreeBSD.org/src/commit/?id=a3a88ed22cb111da3336f64ec3ba5815 > a8278f88 > > commit a3a88ed22cb111da3336f64ec3ba5815a8278f88 > Author: Doug Moore > AuthorDate: 2025-04-18 19:26:56 +0000 > Commit: Doug Moore > CommitDate: 2025-04-18 19:26:56 +0000 > > vm_page: drop prev and next > > Functions vm_page_prev() and vm_page_next() are no longer > invoked. Remove them. > > Reviewed by: kib > Differential Revision: https://reviews.freebsd.org/D49892 > --- > sys/vm/vm_page.c | 40 ---------------------------------------- > sys/vm/vm_page.h | 2 -- > 2 files changed, 42 deletions(-) > > diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c > index 65d278caf3fd..db91b7bab2ab 100644 > --- a/sys/vm/vm_page.c > +++ b/sys/vm/vm_page.c > @@ -1894,46 +1894,6 @@ vm_page_find_least(vm_object_t object, vm_pindex_t pin > dex) > return (m); > } > > -/* > - * Returns the given page's successor (by pindex) within the object if it is > - * resident; if none is found, NULL is returned. > - * > - * The object must be locked. > - */ > -vm_page_t > -vm_page_next(vm_page_t m) > -{ > - vm_page_t next; > - > - VM_OBJECT_ASSERT_LOCKED(m->object); > - if ((next = TAILQ_NEXT(m, listq)) != NULL) { > - MPASS(next->object == m->object); > - if (next->pindex != m->pindex + 1) > - next = NULL; > - } > - return (next); > -} > - > -/* > - * Returns the given page's predecessor (by pindex) within the object if it > is > - * resident; if none is found, NULL is returned. > - * > - * The object must be locked. > - */ > -vm_page_t > -vm_page_prev(vm_page_t m) > -{ > - vm_page_t prev; > - > - VM_OBJECT_ASSERT_LOCKED(m->object); > - if ((prev = TAILQ_PREV(m, pglist, listq)) != NULL) { > - MPASS(prev->object == m->object); > - if (prev->pindex != m->pindex - 1) > - prev = NULL; > - } > - return (prev); > -} > - > /* > * Uses the page mnew as a replacement for an existing page at index > * pindex which must be already present in the object. > diff --git a/sys/vm/vm_page.h b/sys/vm/vm_page.h > index 0a40b42ffb62..bf2e850612d7 100644 > --- a/sys/vm/vm_page.h > +++ b/sys/vm/vm_page.h > @@ -664,12 +664,10 @@ bool vm_page_iter_rename(struct pctrie_iter *old_pages, > vm_page_t m, > void vm_page_launder(vm_page_t m); > vm_page_t vm_page_lookup(vm_object_t, vm_pindex_t); > vm_page_t vm_page_lookup_unlocked(vm_object_t, vm_pindex_t); > -vm_page_t vm_page_next(vm_page_t m); > void vm_page_pqbatch_drain(void); > void vm_page_pqbatch_submit(vm_page_t m, uint8_t queue); > bool vm_page_pqstate_commit(vm_page_t m, vm_page_astate_t *old, > vm_page_astate_t new); > -vm_page_t vm_page_prev(vm_page_t m); > bool vm_page_ps_test(vm_page_t m, int psind, int flags, vm_page_t skip_m); > void vm_page_putfake(vm_page_t m); > void vm_page_readahead_finish(vm_page_t m); > This breaks ports/graphics/drm-*-kmod. X will no longer start due to missing vm_page_next(). cc: manu -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0