From nobody Sat Apr 19 02:25:35 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zfb8X6c92z5sYVV; Sat, 19 Apr 2025 02:25:48 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zfb8X3LlGz4NQk; Sat, 19 Apr 2025 02:25:48 +0000 (UTC) (envelope-from eduardo@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745029548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RNHAme0vnYvmhcHgu0bhZIR8pifD3dAAvWxUOCRYhnk=; b=GgDS1pKt2yD8J0H3NLYCELlBTg0GFfSRaZo04KnnAi/UnNKUGkA9+5WcqHNAm8KjuiYxtY 0J4GC0Qmtog/6hYkDKuD63tMzrXyPkiUCcgwRQffpI6fLzLQkK8w792cK+usz8xKzZ2lqS JjOB6TFb18UdK3Shbun9QTAFnaOJJaw/SOUuWd/AYMoHmjJKhilNsMhZw5pelJlbVt5PhM Iaj7VxvYIifg0TQW3Qz3+wB2owEIPCGs4mcy/Qk9f5034Nz3pkz/tXl+p8vJ6xIjV8BRq1 pO7jk5wa1RKptYfYRnRLpLtO7jjxj/KkkxTPpdRyY4A86QqbKNAkqG+q6JW8eg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1745029548; a=rsa-sha256; cv=none; b=O113ETKS/019FDoDvz7DJTpUwknnd+2y9IKVk34WWiR5IuOJ+29tPYvVLYihbV/NuNeEUN jvZ5932+IwvDR2GG120fVJx/wwZC6ZPWFvbLVYhzDadGD9RATd1HGANM/Pg5gEi33U4NGE 9YAolrpbyvxQe89utInf0KG6uEmZot6uvOkl6qeIrV00zWYZAoo0Ye8gPRFUbEUn3MNHuf Dvmiku1uMFVgHqpvx489raszqUHQK9UamtiLo4iFdYrbZfqZXRjeMtyMEn+Iz5r2m6iHQ9 HjEq92pUGQj/8JLmFDm/w5fB6TbQ6Hfy3DgaBzC4St0ZQNmydXpTpibvvxCDKQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1745029548; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=RNHAme0vnYvmhcHgu0bhZIR8pifD3dAAvWxUOCRYhnk=; b=LkHuxWt7BqT81ehQWWFKiR3VvBfUhk9zx3XMtV9ujTg22N9iufz9UBu+U8ssHszH6AArq/ w+LjWN8UEPbQdaIraA+ruOfDPxbC2J1vhwPvahsWk/5R6D7malzjE6B91Ur8daRW1Sq02U lE1kDckUdIeZsmURw/8WuMN1BlR50fqvRfmvFrUZ7Ja6D8KIXfYlnb5KMUoxSBFZJhvJsj C6jvblOE2p5eG0q9lXeH3bPX2P8HovJqD+/CGaGD6exJWesIltUdIgmNh0OfJ1E1i2aD2G XO37TOuCi6gFCZz5bM2roTy+Pv6LO6v9U0nMolZfGblNyDLic5BFbRvNrxynQA== Received: from mail-qv1-f48.google.com (mail-qv1-f48.google.com [209.85.219.48]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) (Authenticated sender: eduardo) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Zfb8X2nflz2c2; Sat, 19 Apr 2025 02:25:48 +0000 (UTC) (envelope-from eduardo@freebsd.org) Received: by mail-qv1-f48.google.com with SMTP id 6a1803df08f44-6e8fa2d467fso3023006d6.2; Fri, 18 Apr 2025 19:25:48 -0700 (PDT) X-Forwarded-Encrypted: i=1; AJvYcCVfBI6FHYLALPzgah6vDTVSOZVdsE2yi+cXCygjX4SbfKI5abijpRRxDQfJGGLYwePMal4nr+fUjfgYW7/DqIzIiuWbTvQ=@freebsd.org, AJvYcCXXZGhAM2eGTsR2tS7Anf+ZNkg4jRHtO7xPsxW60E0o3+g1x9G2a/BWGicbf8Ww0kWMr6sXEkLIhdM1Baws1flgpS0N@freebsd.org X-Gm-Message-State: AOJu0YzaE8QUw2ksBW0I2wPoB81pql+La06B2zBF3LjLElkRNFfPWDYe M3TnbEB3spryMwcn17V6Y+wmmrvguaBJhA9V06qRTOg+ZTPrPH+CSTtlTWliFpy1pxZhII/vS0u mHN1BMxv8FC9Df9FV1EOOrP3wrig= X-Google-Smtp-Source: AGHT+IGElzfKk1nZXRbpdwGoyt9JNVb55G8wzKFTQn+KcakrrEIxTjABjUOPq77pix3JJ47jnVoG9qYRGCTQkl47xi8= X-Received: by 2002:a05:622a:5cf:b0:472:2122:5a43 with SMTP id d75a77b69052e-47aec354e2emr28643691cf.1.1745029547700; Fri, 18 Apr 2025 19:25:47 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202504181927.53IJRsoQ035803@gitrepo.freebsd.org> In-Reply-To: <202504181927.53IJRsoQ035803@gitrepo.freebsd.org> From: Nuno Teixeira Date: Sat, 19 Apr 2025 03:25:35 +0100 X-Gmail-Original-Message-ID: X-Gm-Features: ATxdqUFJXr892LG2UPvgQ380WcT3mNEuBfmYmhLz4F9PRsSh3-c31ezWtauRW5M Message-ID: Subject: Re: git: a3a88ed22cb1 - main - vm_page: drop prev and next To: Doug Moore Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="0000000000005037080633185a8e" --0000000000005037080633185a8e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Hello, graphics/drm-61-kmod is failing to build and maybe related to some of this commits. Could you take a look and check if it related? Thanks ``` cc -O2 -pipe -fno-strict-aliasing -DLINUXKPI_VERSION=3D60100 '-DKBUILD_MODNAME=3D"i915kms"' '-DLINUXKPI_PARAM_PREFIX=3Di915_' -DDRM_SYSCTL_PARAM_PREFIX=3D_i915kms -DCONFIG_DRM_AMDGPU_CIK -DCONFIG_DRM_AMDGPU_SI -DCONFIG_DRM_AMD_DC -DCONFIG_DRM_AMD_DC_SI -DCONFIG_AMD_PMC -DCONFIG_DRM_I915_FORCE_PROBE=3D'"*"' -DCONFIG_DRM_I915_REQUEST_TIMEOUT=3D20000 -DCONFIG_DRM_I915_CAPTURE_ERROR -DCONFIG_DRM_I915_USERFAULT_AUTOSUSPEND=3D250 -DCONFIG_DRM_I915_STOP_TIMEOUT=3D100 -DCONFIG_DRM_I915_PREEMPT_TIMEOUT=3D64= 0 -DCONFIG_DRM_I915_HEARTBEAT_INTERVAL=3D2500 -DCONFIG_DRM_I915_TIMESLICE_DURATION=3D1 -DCONFIG_DRM_I915_MAX_REQUEST_BUSYWAIT=3D8000 -DCONFIG_DRM_I915_FENCE_TIMEOUT=3D10000 -DCONFIG_DRM_MIPI_DSI -DCONFIG_DRM_PANEL_ORIENTATION_QUIRKS -DCONFIG_APERTURE_HELPERS -DCONFIG_DRM_FBDEV_EMULATION -DCONFIG_DRM_FBDEV_OVERALLOC=3D100 -DCONFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG -DCONFIG_BACKLIGHT_CLASS_DEVICE -DCONFIG_DEBUG_FS -DCONFIG_DMI -DCONFIG_FB -DCONFIG_MTRR -DCONFIG_PCI -DCONFIG_PM -DCONFIG_PM_SLEEP -DCONFIG_SMP -DCONFIG_SUSPEND -DCONFIG_ACPI -DCONFIG_ACPI_SLEEP -DCONFIG_X86 -DCONFIG_X86_PAT -DCONFIG_64BIT -DCONFIG_AS_MOVNTDQA -DCONFIG_COMPAT -DCONFIG_X86_64 -DCONFIG_DRM_AMD_DC_DCN -DCONFIG_DRM_AMD_DC_DCN3_0 -DCONFIG_DRM_AMD_DC_DCN3_01 -DCONFIG_DRM_AMD_DC_DCN3_02 -DCONFIG_DRM_AMD_DC_DCN3_1 -Werror -D_KERNEL -DKLD_MODULE -nostdinc -I/wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/lin= uxkpi/gplv2/include -I/wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/linu= xkpi/bsd/include -I/usr/src/sys/compat/linuxkpi/common/include -I/usr/src/sys/compat/linuxkpi/dummy/include -I/wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/incl= ude -I/wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/incl= ude/drm -I/wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/incl= ude/uapi -I/wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/driv= ers/gpu -I/wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/driv= ers/gpu/drm/i915 -I/wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/driv= ers/gpu/drm/i915/display -include /wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/obj/wr= kdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/i915/opt_= global.h -I. -I/usr/src/sys -I/usr/src/sys/contrib/ck/include -fno-common -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -fdebug-prefix-map=3D./machine=3D/usr/src/sys/amd64/include -fdebug-prefix-map=3D./x86=3D/usr/src/sys/x86/include -fdebug-prefix-map=3D./i386=3D/usr/src/sys/i386/include -MD -MF.depend.i915_gem_stolen.o -MTi915_gem_stolen.o -mcmodel=3Dkernel -mno-red-zone -mno-mmx -mno-sse -msoft-float -fno-asynchronous-unwind-tables -ffreestanding -fwrapv -fstack-protector -Wall -Wstrict-prototypes -Wmissing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D__printf__=3D__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-option -Wno-unknown-pragmas -Wswitch -Wno-error=3Dtautological-compare -Wno-error=3Dempty-body -Wno-error=3Dparentheses-equality -Wno-error=3Dunused-function -Wno-error=3Dpointer-sign -Wno-error=3Dshift-negative-value -Wno-address-of-packed-member -Wno-format-zero-length -Wno-pointer-arith -Wno-format -Wno-cast-qual -mno-aes -mno-avx -std=3Dgnu17 -c /wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/driver= s/gpu/drm/i915/gem/i915_gem_stolen.c -o i915_gem_stolen.o --- i915_gem_mman.o --- /wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/driver= s/gpu/drm/i915/gem/i915_gem_mman.c:171:77: error: call to undeclared function 'vm_page_next'; ISO C99 and later do not support implicit function declarations [-Werror,-Wimplicit-function-declaration] 171 | for (vm_page_t page =3D vm_page_find_least(vmobj, 0); page !=3D NULL; page =3D vm_page_next(page)) = { | ^ /wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/driver= s/gpu/drm/i915/gem/i915_gem_mman.c:171:75: error: incompatible integer to pointer conversion assigning to 'vm_page_t' (aka 'struct vm_page *') from 'int' [-Wint-conversion] 171 | for (vm_page_t page =3D vm_page_find_least(vmobj, 0); page !=3D NULL; page =3D vm_page_next(page)) = { | ^ ~~~~~~~~~~~~~~~~~~ 2 errors generated. *** [i915_gem_mman.o] Error code 1 make[1]: stopped making "all" in /wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/i915 make[1]: 1 error ``` Doug Moore escreveu (sexta, 18/04/2025 =C3=A0(s) 20:28)= : > The branch main has been updated by dougm: > > URL: > https://cgit.FreeBSD.org/src/commit/?id=3Da3a88ed22cb111da3336f64ec3ba581= 5a8278f88 > > commit a3a88ed22cb111da3336f64ec3ba5815a8278f88 > Author: Doug Moore > AuthorDate: 2025-04-18 19:26:56 +0000 > Commit: Doug Moore > CommitDate: 2025-04-18 19:26:56 +0000 > > vm_page: drop prev and next > > Functions vm_page_prev() and vm_page_next() are no longer > invoked. Remove them. > > Reviewed by: kib > Differential Revision: https://reviews.freebsd.org/D49892 > --- > sys/vm/vm_page.c | 40 ---------------------------------------- > sys/vm/vm_page.h | 2 -- > 2 files changed, 42 deletions(-) > > diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c > index 65d278caf3fd..db91b7bab2ab 100644 > --- a/sys/vm/vm_page.c > +++ b/sys/vm/vm_page.c > @@ -1894,46 +1894,6 @@ vm_page_find_least(vm_object_t object, vm_pindex_t > pindex) > return (m); > } > > -/* > - * Returns the given page's successor (by pindex) within the object if i= t > is > - * resident; if none is found, NULL is returned. > - * > - * The object must be locked. > - */ > -vm_page_t > -vm_page_next(vm_page_t m) > -{ > - vm_page_t next; > - > - VM_OBJECT_ASSERT_LOCKED(m->object); > - if ((next =3D TAILQ_NEXT(m, listq)) !=3D NULL) { > - MPASS(next->object =3D=3D m->object); > - if (next->pindex !=3D m->pindex + 1) > - next =3D NULL; > - } > - return (next); > -} > - > -/* > - * Returns the given page's predecessor (by pindex) within the object if > it is > - * resident; if none is found, NULL is returned. > - * > - * The object must be locked. > - */ > -vm_page_t > -vm_page_prev(vm_page_t m) > -{ > - vm_page_t prev; > - > - VM_OBJECT_ASSERT_LOCKED(m->object); > - if ((prev =3D TAILQ_PREV(m, pglist, listq)) !=3D NULL) { > - MPASS(prev->object =3D=3D m->object); > - if (prev->pindex !=3D m->pindex - 1) > - prev =3D NULL; > - } > - return (prev); > -} > - > /* > * Uses the page mnew as a replacement for an existing page at index > * pindex which must be already present in the object. > diff --git a/sys/vm/vm_page.h b/sys/vm/vm_page.h > index 0a40b42ffb62..bf2e850612d7 100644 > --- a/sys/vm/vm_page.h > +++ b/sys/vm/vm_page.h > @@ -664,12 +664,10 @@ bool vm_page_iter_rename(struct pctrie_iter > *old_pages, vm_page_t m, > void vm_page_launder(vm_page_t m); > vm_page_t vm_page_lookup(vm_object_t, vm_pindex_t); > vm_page_t vm_page_lookup_unlocked(vm_object_t, vm_pindex_t); > -vm_page_t vm_page_next(vm_page_t m); > void vm_page_pqbatch_drain(void); > void vm_page_pqbatch_submit(vm_page_t m, uint8_t queue); > bool vm_page_pqstate_commit(vm_page_t m, vm_page_astate_t *old, > vm_page_astate_t new); > -vm_page_t vm_page_prev(vm_page_t m); > bool vm_page_ps_test(vm_page_t m, int psind, int flags, vm_page_t skip_m= ); > void vm_page_putfake(vm_page_t m); > void vm_page_readahead_finish(vm_page_t m); > > --=20 Nuno Teixeira FreeBSD UNIX: Web: https://FreeBSD.org --0000000000005037080633185a8e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Hello,

graphics/drm-61-kmod = is failing to build and maybe related to some of this commits.
Could you take a look and check if it related?

Thanks
```
cc =C2=A0-O2 -pipe -fno-strict-aliasing -DLINUXKPI_VERS= ION=3D60100 '-DKBUILD_MODNAME=3D"i915kms"' '-DLINUXKP= I_PARAM_PREFIX=3Di915_' -DDRM_SYSCTL_PARAM_PREFIX=3D_i915kms -DCONFIG_D= RM_AMDGPU_CIK -DCONFIG_DRM_AMDGPU_SI -DCONFIG_DRM_AMD_DC -DCONFIG_DRM_AMD_D= C_SI -DCONFIG_AMD_PMC -DCONFIG_DRM_I915_FORCE_PROBE=3D'"*"= 9; -DCONFIG_DRM_I915_REQUEST_TIMEOUT=3D20000 -DCONFIG_DRM_I915_CAPTURE_ERRO= R -DCONFIG_DRM_I915_USERFAULT_AUTOSUSPEND=3D250 -DCONFIG_DRM_I915_STOP_TIME= OUT=3D100 -DCONFIG_DRM_I915_PREEMPT_TIMEOUT=3D640 -DCONFIG_DRM_I915_HEARTBE= AT_INTERVAL=3D2500 -DCONFIG_DRM_I915_TIMESLICE_DURATION=3D1 -DCONFIG_DRM_I9= 15_MAX_REQUEST_BUSYWAIT=3D8000 -DCONFIG_DRM_I915_FENCE_TIMEOUT=3D10000 -DCO= NFIG_DRM_MIPI_DSI -DCONFIG_DRM_PANEL_ORIENTATION_QUIRKS -DCONFIG_APERTURE_H= ELPERS -DCONFIG_DRM_FBDEV_EMULATION -DCONFIG_DRM_FBDEV_OVERALLOC=3D100 -DCO= NFIG_ARCH_HAVE_NMI_SAFE_CMPXCHG -DCONFIG_BACKLIGHT_CLASS_DEVICE -DCONFIG_DE= BUG_FS -DCONFIG_DMI -DCONFIG_FB -DCONFIG_MTRR -DCONFIG_PCI -DCONFIG_PM -DCO= NFIG_PM_SLEEP -DCONFIG_SMP -DCONFIG_SUSPEND -DCONFIG_ACPI -DCONFIG_ACPI_SLE= EP -DCONFIG_X86 -DCONFIG_X86_PAT -DCONFIG_64BIT -DCONFIG_AS_MOVNTDQA -DCONF= IG_COMPAT -DCONFIG_X86_64 -DCONFIG_DRM_AMD_DC_DCN -DCONFIG_DRM_AMD_DC_DCN3_= 0 -DCONFIG_DRM_AMD_DC_DCN3_01 -DCONFIG_DRM_AMD_DC_DCN3_02 -DCONFIG_DRM_AMD_= DC_DCN3_1 =C2=A0-Werror
-D_KERNEL -DKLD_MODULE -nostdinc =C2=A0-I/wrkdir= s/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/linuxkpi/gplv= 2/include -I/wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.= 128_1/linuxkpi/bsd/include -I/usr/src/sys/compat/linuxkpi/common/include -I= /usr/src/sys/compat/linuxkpi/dummy/include -I/wrkdirs/usr/ports/graphics/dr= m-61-kmod/work/drm-kmod-drm_v6.1.128_1/include -I/wrkdirs/usr/ports/graphic= s/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/include/drm -I/wrkdirs/usr/ports= /graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/include/uapi -I/wrkdirs/= usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/drivers/gpu -I/= wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/drivers= /gpu/drm/i915 -I/wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v= 6.1.128_1/drivers/gpu/drm/i915/display -include /wrkdirs/usr/ports/graphics= /drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/obj/wrkdirs/usr/ports/graphics/dr= m-61-kmod/work/drm-kmod-drm_v6.1.128_1/i915/opt_global.h -I. -I/usr/src/sys= -I/usr/src/sys/contrib/ck/include -fno-common =C2=A0-fno-omit-frame-pointe= r -mno-omit-leaf-frame-pointer -fdebug-prefix-map=3D./machine=3D/usr/src/sy= s/amd64/include -fdebug-prefix-map=3D./x86=3D/usr/src/sys/x86/include -fdeb= ug-prefix-map=3D./i386=3D/usr/src/sys/i386/include =C2=A0 =C2=A0-MD =C2=A0-= MF.depend.i915_gem_stolen.o -MTi915_gem_stolen.o -mcmodel=3Dkernel -mno-red= -zone -mno-mmx -mno-sse -msoft-float =C2=A0-fno-asynchronous-unwind-tables = -ffreestanding -fwrapv -fstack-protector =C2=A0-Wall -Wstrict-prototypes -W= missing-prototypes -Wpointer-arith -Wcast-qual -Wundef -Wno-pointer-sign -D= __printf__=3D__freebsd_kprintf__ -Wmissing-include-dirs -fdiagnostics-show-= option -Wno-unknown-pragmas -Wswitch -Wno-error=3Dtautological-compare -Wno= -error=3Dempty-body -Wno-error=3Dparentheses-equality -Wno-error=3Dunused-f= unction -Wno-error=3Dpointer-sign -Wno-error=3Dshift-negative-value -Wno-ad= dress-of-packed-member -Wno-format-zero-length -Wno-pointer-arith -Wno-form= at -Wno-cast-qual =C2=A0 -mno-aes -mno-avx =C2=A0-std=3Dgnu17 -c /wrkdirs/u= sr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/drivers/gpu/drm/= i915/gem/i915_gem_stolen.c -o i915_gem_stolen.o
--- i915_gem_mman.o ---<= br>/wrkdirs/usr/ports/graphics/drm-61-kmod/work/drm-kmod-drm_v6.1.128_1/dri= vers/gpu/drm/i915/gem/i915_gem_mman.c:171:77: error: call to undeclared fun= ction 'vm_page_next'; ISO C99 and later do not support implicit fun= ction declarations [-Werror,-Wimplicit-function-declaration]
=C2=A0 171 = | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 for (vm_page_t page =3D vm_page_find_least(vmobj, 0); page !=3D = NULL; page =3D vm_page_next(page)) {
=C2=A0 =C2=A0 =C2=A0 | =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^
/wrkdirs/usr/ports/graphics/drm-= 61-kmod/work/drm-kmod-drm_v6.1.128_1/drivers/gpu/drm/i915/gem/i915_gem_mman= .c:171:75: error: incompatible integer to pointer conversion assigning to &= #39;vm_page_t' (aka 'struct vm_page *') from 'int' [-Wi= nt-conversion]
=C2=A0 171 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 for (vm_page_t page =3D vm_page_f= ind_least(vmobj, 0); page !=3D NULL; page =3D vm_page_next(page)) {
=C2= =A0 =C2=A0 =C2=A0 | =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0^ ~~~~~~~~~~~~~~= ~~~~
2 errors generated.
*** [i915_gem_mman.o] Error code 1

ma= ke[1]: stopped making "all" in /wrkdirs/usr/ports/graphics/drm-61= -kmod/work/drm-kmod-drm_v6.1.128_1/i915
make[1]: 1 error
```

Doug Moore <dougm@freebsd.org> escreveu (sexta, 18/04/2025 =C3=A0(s) 20:28):<= br>
The branch main = has been updated by dougm:

URL: https://cgit.= FreeBSD.org/src/commit/?id=3Da3a88ed22cb111da3336f64ec3ba5815a8278f88
commit a3a88ed22cb111da3336f64ec3ba5815a8278f88
Author:=C2=A0 =C2=A0 =C2=A0Doug Moore <dougm@FreeBSD.org>
AuthorDate: 2025-04-18 19:26:56 +0000
Commit:=C2=A0 =C2=A0 =C2=A0Doug Moore <dougm@FreeBSD.org>
CommitDate: 2025-04-18 19:26:56 +0000

=C2=A0 =C2=A0 vm_page: drop prev and next

=C2=A0 =C2=A0 Functions vm_page_prev() and vm_page_next() are no longer
=C2=A0 =C2=A0 invoked. Remove them.

=C2=A0 =C2=A0 Reviewed by:=C2=A0 =C2=A0 kib
=C2=A0 =C2=A0 Differential Revision:=C2=A0 https://reviews.freebsd= .org/D49892
---
=C2=A0sys/vm/vm_page.c | 40 ----------------------------------------
=C2=A0sys/vm/vm_page.h |=C2=A0 2 --
=C2=A02 files changed, 42 deletions(-)

diff --git a/sys/vm/vm_page.c b/sys/vm/vm_page.c
index 65d278caf3fd..db91b7bab2ab 100644
--- a/sys/vm/vm_page.c
+++ b/sys/vm/vm_page.c
@@ -1894,46 +1894,6 @@ vm_page_find_least(vm_object_t object, vm_pindex_t p= index)
=C2=A0 =C2=A0 =C2=A0 =C2=A0 return (m);
=C2=A0}

-/*
- * Returns the given page's successor (by pindex) within the object if= it is
- * resident; if none is found, NULL is returned.
- *
- * The object must be locked.
- */
-vm_page_t
-vm_page_next(vm_page_t m)
-{
-=C2=A0 =C2=A0 =C2=A0 =C2=A0vm_page_t next;
-
-=C2=A0 =C2=A0 =C2=A0 =C2=A0VM_OBJECT_ASSERT_LOCKED(m->object);
-=C2=A0 =C2=A0 =C2=A0 =C2=A0if ((next =3D TAILQ_NEXT(m, listq)) !=3D NULL) = {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0MPASS(next->obje= ct =3D=3D m->object);
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (next->pindex= !=3D m->pindex + 1)
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0next =3D NULL;
-=C2=A0 =C2=A0 =C2=A0 =C2=A0}
-=C2=A0 =C2=A0 =C2=A0 =C2=A0return (next);
-}
-
-/*
- * Returns the given page's predecessor (by pindex) within the object = if it is
- * resident; if none is found, NULL is returned.
- *
- * The object must be locked.
- */
-vm_page_t
-vm_page_prev(vm_page_t m)
-{
-=C2=A0 =C2=A0 =C2=A0 =C2=A0vm_page_t prev;
-
-=C2=A0 =C2=A0 =C2=A0 =C2=A0VM_OBJECT_ASSERT_LOCKED(m->object);
-=C2=A0 =C2=A0 =C2=A0 =C2=A0if ((prev =3D TAILQ_PREV(m, pglist, listq)) != =3D NULL) {
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0MPASS(prev->obje= ct =3D=3D m->object);
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (prev->pindex= !=3D m->pindex - 1)
-=C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0prev =3D NULL;
-=C2=A0 =C2=A0 =C2=A0 =C2=A0}
-=C2=A0 =C2=A0 =C2=A0 =C2=A0return (prev);
-}
-
=C2=A0/*
=C2=A0 * Uses the page mnew as a replacement for an existing page at index<= br> =C2=A0 * pindex which must be already present in the object.
diff --git a/sys/vm/vm_page.h b/sys/vm/vm_page.h
index 0a40b42ffb62..bf2e850612d7 100644
--- a/sys/vm/vm_page.h
+++ b/sys/vm/vm_page.h
@@ -664,12 +664,10 @@ bool vm_page_iter_rename(struct pctrie_iter *old_page= s, vm_page_t m,
=C2=A0void vm_page_launder(vm_page_t m);
=C2=A0vm_page_t vm_page_lookup(vm_object_t, vm_pindex_t);
=C2=A0vm_page_t vm_page_lookup_unlocked(vm_object_t, vm_pindex_t);
-vm_page_t vm_page_next(vm_page_t m);
=C2=A0void vm_page_pqbatch_drain(void);
=C2=A0void vm_page_pqbatch_submit(vm_page_t m, uint8_t queue);
=C2=A0bool vm_page_pqstate_commit(vm_page_t m, vm_page_astate_t *old,
=C2=A0 =C2=A0 =C2=A0vm_page_astate_t new);
-vm_page_t vm_page_prev(vm_page_t m);
=C2=A0bool vm_page_ps_test(vm_page_t m, int psind, int flags, vm_page_t ski= p_m);
=C2=A0void vm_page_putfake(vm_page_t m);
=C2=A0void vm_page_readahead_finish(vm_page_t m);



--
Nuno Teixeira
=
FreeBSD UNIX:=C2=A0 <eduardo@FreeBSD.org>=C2=A0 =C2=A0Web:=C2=A0 https://Fr= eeBSD.org
--0000000000005037080633185a8e--