From nobody Fri Apr 18 17:30:55 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZfMHS0wzfz5t6dk; Fri, 18 Apr 2025 17:31:00 +0000 (UTC) (envelope-from unkadoug@gmail.com) Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZfMHQ4nY9z3pb8; Fri, 18 Apr 2025 17:30:58 +0000 (UTC) (envelope-from unkadoug@gmail.com) Authentication-Results: mx1.freebsd.org; dkim=pass header.d=gmail.com header.s=20230601 header.b=UM7N+Kxk; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (mx1.freebsd.org: domain of unkadoug@gmail.com designates 2001:4860:4864:20::2d as permitted sender) smtp.mailfrom=unkadoug@gmail.com Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-2d060c62b61so1131200fac.0; Fri, 18 Apr 2025 10:30:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1744997457; x=1745602257; darn=freebsd.org; h=in-reply-to:content-language:references:to:subject:user-agent :mime-version:date:message-id:from:from:to:cc:subject:date :message-id:reply-to; bh=ua3i0REfvIY8pd2B46VObl5g3EFGWWuUBb+veyhiZVY=; b=UM7N+Kxkh07+J7zxO4edt+ejxZpGvBFQLNCAc/fFqtiWhhEvNLJ2JJQrrBHdHRrCT0 dGoy0JphXazGd/AIwBpXq3SpL3H7zqg3ixrHRUlFeaLYgBc8eiNPExaMOdY3TXZRf4p8 OUf+bkGMHnRsuufEZWN8bfo5OcnmunoPeHe3sOB59w502N+eBhZiRiYSyK0wx8IU6SdF PNFlkPz76FcyM20JT1FxowWjYS0hMQtGH+w+QRPkIn/1xcaBlyhnT8RTPw4ovRw+GYRe QxE7QaXSqNn6QUCxCjNJySW54RLjSl0aPDBuem8q7zpzPXnPTtg7atALda/AXKdTtHbh QvYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744997457; x=1745602257; h=in-reply-to:content-language:references:to:subject:user-agent :mime-version:date:message-id:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ua3i0REfvIY8pd2B46VObl5g3EFGWWuUBb+veyhiZVY=; b=PO+6nwCV9jDSkgSuvw8ZspL8C5s12jJMkZUecV6hPt/lGGAVQifOvrVIAHzRpDtU8O f6M3ymy0y1oxIVfYd+WH37XyjdlXb19oHTwMsVGcpLXKB2fK0wx+j1kFaOMGuoT4n+DT PBkA/oyLSjbqRvZtVcVn1+jMyIxLWJPYkF76zBo4Fu3sazMox4PwTdlQfFkPMItkg+l/ 0mTT7vvtOUvh6MRGDH8i7i6byBJrZQPuhVlojRiUuVdLD8n+4Wnfc0DIpPiT0CnsjKB/ 587JqoiRMhD+SFOeprt2Lio8Swz9d0Yld7FGZ1od58Ygn9xBzJg5TMRd5891l4FJehKy 1aiQ== X-Forwarded-Encrypted: i=1; AJvYcCX5RZZMJp2LjMcoC9bxieDnj3QEvPaxKxRNPvtR+wD8LWq6Hw2zraBYDoM9O5gfeNSjJG//TQHHfS6j+Wpmr0SMXNia@freebsd.org, AJvYcCXMjWq7gMd55Wujon3efODsQbqIGZ4QfffEWlYr9PaB+WNqHp/OfckMGjHyVDyHv34XCGxiXak+64FwDNpjJgy891R9B78=@freebsd.org X-Gm-Message-State: AOJu0Yx5/KYaYTwRwprulCeCLVSCy2LxEqsftr2sfOLCdEzPEuwiXQ0J QTaiyGq32LkqsWEm/K/tIkeeP6esHmu0eg7YzjCxI27RxtGJ+L74zE+MXw== X-Gm-Gg: ASbGncu+3w7XMvYWheczpot46EQF9XNuYjOgd/AkZzQ5TBHLjB48EQXqZwTcbp/g2Ht e3O+753GbpPFnt6C/bewXkU2NBCU7R4XPHPBJOYXsgqWndGYsJxWltUr/APjWuLr0ifie25ZPn+ vcFojThESXRfTqJ2KZbtfcWInjMdxG/EsTbFbnQJQf5F11NHIcY3EsTcekCNUnWIi1ynL4nt1HX /mE1xMKEsXrCIZbr81vIr9hIQE0DF1RKRcHZ8zL2HaIBWSI/cihTHfRGplN4XYMOvAOwaITt5N/ QIK3dJi3qgFbgGLUQDObhBg3JHuNQ3c8lNwP478JcNalRPBh6XsehWThdBaCGOJLPsHzSHQSKRJ OtE70Ws4BVGPmWCPq6LVFDvk= X-Google-Smtp-Source: AGHT+IFbVDTr/fR9mf5+TBeNYSSDxPjUMOet7H7CD+AwosiSEEo+fScgc+JXawAEGlcA139HIJFbAg== X-Received: by 2002:a05:6870:ec8e:b0:2d4:c55b:199a with SMTP id 586e51a60fabf-2d526af63cbmr1867412fac.18.1744997457241; Fri, 18 Apr 2025 10:30:57 -0700 (PDT) Received: from [108.254.203.202] (108-254-203-202.lightspeed.hstntx.sbcglobal.net. [108.254.203.202]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-2d52181deb6sm539374fac.46.2025.04.18.10.30.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Apr 2025 10:30:56 -0700 (PDT) From: Doug Moore X-Google-Original-From: Doug Moore Content-Type: multipart/alternative; boundary="------------7ZyFIGUXlhTJX41dsmdrxWpp" Message-ID: <854342c4-0bcf-45c7-874f-8e5388d16f09@freebsd.org> Date: Fri, 18 Apr 2025 12:30:55 -0500 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: git: 4568f5a286a2 - main - kern_kcov: replace vm_page_next() with iterator To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org References: <202504181724.53IHOOHC010885@gitrepo.freebsd.org> Content-Language: en-US In-Reply-To: <202504181724.53IHOOHC010885@gitrepo.freebsd.org> X-Spamd-Result: default: False [1.87 / 15.00]; MID_RHS_MATCH_TO(1.00)[]; NEURAL_SPAM_LONG(0.75)[0.753]; NEURAL_SPAM_SHORT(0.63)[0.635]; DMARC_POLICY_ALLOW(-0.50)[gmail.com,none]; NEURAL_SPAM_MEDIUM(0.48)[0.482]; R_DKIM_ALLOW(-0.20)[gmail.com:s=20230601]; R_SPF_ALLOW(-0.20)[+ip6:2001:4860:4000::/36]; MIME_GOOD(-0.10)[multipart/alternative,text/plain]; DWL_DNSWL_NONE(0.00)[gmail.com:dkim]; RCVD_VIA_SMTP_AUTH(0.00)[]; MIME_TRACE(0.00)[0:+,1:+,2:~]; FREEMAIL_FROM(0.00)[gmail.com]; ARC_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:2001:4860:4864::/48, country:US]; MLMMJ_DEST(0.00)[dev-commits-src-all@freebsd.org,dev-commits-src-main@freebsd.org]; RCPT_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; RCVD_IN_DNSWL_NONE(0.00)[2001:4860:4864:20::2d:from]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; RCVD_TLS_LAST(0.00)[]; DKIM_TRACE(0.00)[gmail.com:+] X-Rspamd-Queue-Id: 4ZfMHQ4nY9z3pb8 X-Spamd-Bar: + This is a multi-part message in MIME format. --------------7ZyFIGUXlhTJX41dsmdrxWpp Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit An unfortunate copy/paste error.  Make that Differential Revision:https://reviews.freebsd.org/D49889 On 4/18/25 12:24, Doug Moore wrote: > The branch main has been updated by dougm: > > URL:https://cgit.FreeBSD.org/src/commit/?id=4568f5a286a212fcceaf9a9bb90eabc104829f49 > > commit 4568f5a286a212fcceaf9a9bb90eabc104829f49 > Author: Doug Moore > AuthorDate: 2025-04-18 17:18:00 +0000 > Commit: Doug Moore > CommitDate: 2025-04-18 17:24:04 +0000 > > kern_kcov: replace vm_page_next() with iterator > > Use VM_RADIX_FORALL, and drop a use of vm_page_next(), in kcov_free(). > > Reviewed by: kib > Differential Revision: kern_kcov: replace vm_page_next() with iterator > --- > sys/kern/kern_kcov.c | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) > > diff --git a/sys/kern/kern_kcov.c b/sys/kern/kern_kcov.c > index 19d35a1ad961..1c1d924b8b79 100644 > --- a/sys/kern/kern_kcov.c > +++ b/sys/kern/kern_kcov.c > @@ -396,20 +396,19 @@ kcov_alloc(struct kcov_info *info, size_t entries) > static void > kcov_free(struct kcov_info *info) > { > + struct pctrie_iter pages; > vm_page_t m; > - size_t i; > > if (info->kvaddr != 0) { > pmap_qremove(info->kvaddr, info->bufsize / PAGE_SIZE); > kva_free(info->kvaddr, info->bufsize); > } > if (info->bufobj != NULL) { > + vm_page_iter_limit_init(&pages, info->bufobj, > + info->bufsize / PAGE_SIZE); > VM_OBJECT_WLOCK(info->bufobj); > - m = vm_page_lookup(info->bufobj, 0); > - for (i = 0; i < info->bufsize / PAGE_SIZE; i++) { > + VM_RADIX_FORALL(m, &pages) > vm_page_unwire_noq(m); > - m = vm_page_next(m); > - } > VM_OBJECT_WUNLOCK(info->bufobj); > vm_object_deallocate(info->bufobj); > } --------------7ZyFIGUXlhTJX41dsmdrxWpp Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit

An unfortunate copy/paste error.  Make that

Differential Revision: https://reviews.freebsd.org/D49889

On 4/18/25 12:24, Doug Moore wrote:
The branch main has been updated by dougm:

URL: https://cgit.FreeBSD.org/src/commit/?id=4568f5a286a212fcceaf9a9bb90eabc104829f49

commit 4568f5a286a212fcceaf9a9bb90eabc104829f49
Author:     Doug Moore <dougm@FreeBSD.org>
AuthorDate: 2025-04-18 17:18:00 +0000
Commit:     Doug Moore <dougm@FreeBSD.org>
CommitDate: 2025-04-18 17:24:04 +0000

    kern_kcov: replace vm_page_next() with iterator
    
    Use VM_RADIX_FORALL, and drop a use of vm_page_next(), in kcov_free().
    
    Reviewed by:    kib
    Differential Revision:  kern_kcov: replace vm_page_next() with iterator
---
 sys/kern/kern_kcov.c | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/sys/kern/kern_kcov.c b/sys/kern/kern_kcov.c
index 19d35a1ad961..1c1d924b8b79 100644
--- a/sys/kern/kern_kcov.c
+++ b/sys/kern/kern_kcov.c
@@ -396,20 +396,19 @@ kcov_alloc(struct kcov_info *info, size_t entries)
 static void
 kcov_free(struct kcov_info *info)
 {
+	struct pctrie_iter pages;
 	vm_page_t m;
-	size_t i;
 
 	if (info->kvaddr != 0) {
 		pmap_qremove(info->kvaddr, info->bufsize / PAGE_SIZE);
 		kva_free(info->kvaddr, info->bufsize);
 	}
 	if (info->bufobj != NULL) {
+		vm_page_iter_limit_init(&pages, info->bufobj,
+		    info->bufsize / PAGE_SIZE);
 		VM_OBJECT_WLOCK(info->bufobj);
-		m = vm_page_lookup(info->bufobj, 0);
-		for (i = 0; i < info->bufsize / PAGE_SIZE; i++) {
+		VM_RADIX_FORALL(m, &pages)
 			vm_page_unwire_noq(m);
-			m = vm_page_next(m);
-		}
 		VM_OBJECT_WUNLOCK(info->bufobj);
 		vm_object_deallocate(info->bufobj);
 	}
--------------7ZyFIGUXlhTJX41dsmdrxWpp--