From nobody Thu Apr 17 20:45:07 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zdqdw0D5Hz5slNQ; Thu, 17 Apr 2025 20:45:08 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zdqdv3fPdz49Rj; Thu, 17 Apr 2025 20:45:07 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744922707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vuRztD8rFxsP3UdMqSNSd53kptfyvrKBaL86M/nz0T4=; b=VWh36mUBdz8Eo9ti2x78KlEGaVtQ0IAQ6/qlfz6zo9MCl1FjOwn9CeR/JxAKXiNEbz5FNk U0JtvW3RI20cj9J34XYBZhgS1cH9jIgXZoJyRaccGPe4SiDnAhd32EruPKlGwrhP66COfS SJ0ov8/f6hXOo+zzHBaTSM8KLFJ/vqf4MtWx78VfXZN/YIrF+Hkd07EcKeAoN4r/k3N7Pu oamYNrfzk2dsb8tVatn3JPXc1A1cvbmrgrCzk0C6Zs3Dba8HFw9zKNXgOlfqN69Om8yYk5 +60+lGNKTvfJwoNn9Xt1iamzOmxQ9lUNnEf51tsNSqBKcLG1OAv9mwmFn019DA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744922707; a=rsa-sha256; cv=none; b=VH0Xv6Ipn6fp/geVCghzVxJRFp5w2PBHYF4LpM/x/oUKxyB0rqQerHBN9vvnp8k8ttLDym sHJmuRpls25lLNiDiMIlMvLyMF7+UlrXUFjbxl+s9SuXTSrMHl6A4PZ/tMekB5RsO0S1t2 fpDk8fd/IVLCUMbcqK575MmtU+0UwtZ4Nb9hUt5wtA9j+4L1EZGLfV8nbuVMS54QdprRPF FeaWbhgB+RRgDRtTXLe70+wg5AxKyqVe/6rHlery0BI2i3YuG3PQkxyJoa+IfwpKhA2gS7 PyzggRBLJqylQ66AirHJtGlt7taNokyLNpIAlb/z19HzGjK64U1yQuVgHEIH3g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744922707; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=vuRztD8rFxsP3UdMqSNSd53kptfyvrKBaL86M/nz0T4=; b=Bq2zIuGCNT4v6TkHZk3zUbtmTmcB0roxUVjHQ83fHXUzRcnVu+LhQw6vGADFn4Q+H6sckM JNM788CzV4B9evjGEwWkGLYJglAHecidvh9dyZHyInVnLzAboGUWK5LNHNmH/0833Oj4Ll LgEYHhy33SMarJRlwfS/f55vzBk8J/8huoIu1LfwEDTExMqNlde9lhZQTH1o7uzQY4l3pp ztqbvhxiZTiALKOqAvt2Xscp5p9e0HQZil1vI7LiMA/DvsAnToQ8dF0hEdpy1FAUscADX9 xioIe71HpELkvjAeRkct1J2di4T75z6sX9SQlgwdxnRLNGcmZZBnQnhrLdsUrw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zdqdv3BN9z13WW; Thu, 17 Apr 2025 20:45:07 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53HKj7OY071278; Thu, 17 Apr 2025 20:45:07 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53HKj7sp071275; Thu, 17 Apr 2025 20:45:07 GMT (envelope-from git) Date: Thu, 17 Apr 2025 20:45:07 GMT Message-Id: <202504172045.53HKj7sp071275@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: 1f8d845d1cdf - main - ptrace_test PT_SC_REMOTE: fix a race List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 1f8d845d1cdfeaefa539df5f6f33bec3da65152c Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=1f8d845d1cdfeaefa539df5f6f33bec3da65152c commit 1f8d845d1cdfeaefa539df5f6f33bec3da65152c Author: Konstantin Belousov AuthorDate: 2025-04-16 15:02:58 +0000 Commit: Konstantin Belousov CommitDate: 2025-04-17 20:33:47 +0000 ptrace_test PT_SC_REMOTE: fix a race Only one of PT_TRACE_ME/PT_ATTACH is needed. Having them both causes the race between parent and child on the attachment way. Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 2 weeks Differential revision: https://reviews.freebsd.org/D49678 --- tests/sys/kern/ptrace_test.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/sys/kern/ptrace_test.c b/tests/sys/kern/ptrace_test.c index db681293f043..de411af6bc40 100644 --- a/tests/sys/kern/ptrace_test.c +++ b/tests/sys/kern/ptrace_test.c @@ -4378,7 +4378,10 @@ ATF_TC_BODY(ptrace__PT_SC_REMOTE_getpid, tc) exit(0); } - attach_child(fpid); + wpid = waitpid(fpid, &status, 0); + REQUIRE_EQ(wpid, fpid); + ATF_REQUIRE(WIFSTOPPED(status)); + REQUIRE_EQ(WSTOPSIG(status), SIGSTOP); pscr.pscr_syscall = SYS_getpid; pscr.pscr_nargs = 0;