From nobody Thu Apr 17 20:45:06 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zdqdt5c99z5slNN; Thu, 17 Apr 2025 20:45:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zdqdt3DMjz49L7; Thu, 17 Apr 2025 20:45:06 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744922706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lheUgNwghlLdqUb9FEvkWCfWwf7s0BeD9MnXtHh2sQE=; b=W3TK+dlilIysby4UiKNE2kz2VCWlZ6IWCnslEDaIC3ok0pr+ZdYUHxvPi3kDSeoejdD1ho c5V0gzNKvXEwT5CKu4jh7ODs4bAfobbSEzHUmCg6nuvpdpJlx9jbl4MLe37yu5GgAet4Yo QbNfhzNFk1fN4671QpOmav2I4alrgimDDyIrbqwi97UcNwpXMX9NZUGpKS+oH+y3MJF63n z3F97Vc81nvznkOIHSq5T9Sd2KyCTi/3PyizkpqB1OwZO+82vuzIO7jXJYQVjGYP7xE7mT pHaYdjgUW3cZCL2dIswm5krmzPGLlOskcLoeEoAPZHS6v0c28GV81EWDvFRY2w== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744922706; a=rsa-sha256; cv=none; b=biobTlv9VDv39KbfXne+NQshW60nRaZfcjcawCxgtCPRuj/VXKmIMeIU4TbKqWT2vjEKKH gdzRGIJnScJyxECNwZEIPtOleKILLesiUSQjrdM3j8LfqYo403cGC/X43ico+NUaufipUh p8eRP3ipaaKFWXCqe6uOc9cO34Z34f2uhNuiZvFLlfCRTdaRlw2kPjBv4Tuws6rtMpp4Hq RtJkUr0VhXN4+RyfLhep52fJRBfquqHtpfddG2iETKpeakkrTLO3FIWpv+UbJXV8x4uBP4 0ztdKSy7A2KaO5xpdZrVzj2hIShroIHbQim6z7MJut+NFp3V4+U/LbrBgj11kg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744922706; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=lheUgNwghlLdqUb9FEvkWCfWwf7s0BeD9MnXtHh2sQE=; b=ZLgzFa9VcwwT9mNIaIpqdSkIGJeNOODs5SFSXrzc/2hQCxXGv+cqly3bHzHhFqIB4sA8sK jOA/+lBGlMZjG/XkpQjqk0tEvtGHI8Q+odJHi4nz48hFVM7Fn7PADTmWhuNI5cr2TdsgNQ Xf/aKsjBE7bW2jkdv7J8xi6cu7+/bp0qaxkkbZJN71dkcM11+SsapZ1ePEpaf5NYmwqKOe qPONO2hSelV9c5Aye3gKgz8d6XlBH2/QT8GJl3brLjW6Mplu7Fp4DFo/ydemBpnjAnh9AC DwZgv+wp4VhwgSFOeK8fPS4OCBNxIuLQJED202adkWEbNLlY1HaBQSRgak+M2Q== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zdqdt2ZR9z13pQ; Thu, 17 Apr 2025 20:45:06 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53HKj65W071238; Thu, 17 Apr 2025 20:45:06 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53HKj6Ra071235; Thu, 17 Apr 2025 20:45:06 GMT (envelope-from git) Date: Thu, 17 Apr 2025 20:45:06 GMT Message-Id: <202504172045.53HKj6Ra071235@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: a6b7d5cddacd - main - kern_sig.c: add chicken bit for old way of SIGSTOP handling on PT_ATTACH List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: a6b7d5cddacd4aa14ee058195eedfe207a69029e Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=a6b7d5cddacd4aa14ee058195eedfe207a69029e commit a6b7d5cddacd4aa14ee058195eedfe207a69029e Author: Konstantin Belousov AuthorDate: 2025-04-17 11:51:42 +0000 Commit: Konstantin Belousov CommitDate: 2025-04-17 20:33:47 +0000 kern_sig.c: add chicken bit for old way of SIGSTOP handling on PT_ATTACH Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 2 weeks Differential revision: https://reviews.freebsd.org/D49678 --- sys/kern/kern_sig.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/sys/kern/kern_sig.c b/sys/kern/kern_sig.c index ba3b04ac6e22..91287b3c1f87 100644 --- a/sys/kern/kern_sig.c +++ b/sys/kern/kern_sig.c @@ -174,6 +174,11 @@ SYSCTL_BOOL(_kern, OID_AUTO, sig_discard_ign, CTLFLAG_RWTUN, "Discard ignored signals on delivery, otherwise queue them to " "the target queue"); +static bool pt_attach_transparent = true; +SYSCTL_BOOL(_debug, OID_AUTO, ptrace_attach_transparent, CTLFLAG_RWTUN, + &pt_attach_transparent, 0, + "Hide wakes from PT_ATTACH on interruptible sleeps"); + SYSINIT(signal, SI_SUB_P1003_1B, SI_ORDER_FIRST+3, sigqueue_start, NULL); /* @@ -2365,7 +2370,8 @@ tdsendsignal(struct proc *p, struct thread *td, int sig, ksiginfo_t *ksi) if (prop & SIGPROP_CONT) sigqueue_delete_stopmask_proc(p); else if (prop & SIGPROP_STOP) { - if ((p->p_flag & P_TRACED) != 0 && + if (pt_attach_transparent && + (p->p_flag & P_TRACED) != 0 && (p->p_flag2 & P2_PTRACE_FSTP) != 0) { td->td_dbgflags |= TDB_FSTP; PROC_SLOCK(p); @@ -3354,7 +3360,7 @@ issignal(struct thread *td) } } - if (false && + if (!pt_attach_transparent && (p->p_flag & (P_TRACED | P_PPTRACE)) == P_TRACED && (p->p_flag2 & P2_PTRACE_FSTP) != 0 && SIGISMEMBER(sigpending, SIGSTOP)) {