From nobody Thu Apr 17 20:45:05 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zdqds6Xcpz5skyH; Thu, 17 Apr 2025 20:45:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zdqds211zz49Nx; Thu, 17 Apr 2025 20:45:05 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744922705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2E77blHQKuaFuxhFZSOppKmGInyvHDF4Dwns3Jg3HZo=; b=lTCOyRY8hVw0a0RsLCmgvJVA1ZPdCPYJYGQQ/SJqQN9hJEG9eyGqxpRJdO4YbJ8XJuQRoN JCQmf6yRxR/EwTvnXXwyyDUXTXGOP/sk+yWcUMGiKpUoHlaHVp5R/srr2FtMlg+g94mDtw g8t4B6IZomIE3vxHgVZYxC4TzMlBo223cm5+J5cGL7kQLM5zU4WM+fDrtm3uvo6vvl4zx8 yOXq4oS6OJnyMKZYyxP3Qtak/A9cykT0gmE1hQs0Rn989zArBWcWPmhJBXYohs9i0PG8/p vwe2OdXMgvRxIHBYxv5L7LR/2TgMMMgBA2qYOB0WgYxWo21BNh90/g83WNpBfw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744922705; a=rsa-sha256; cv=none; b=wxR2MKYqzTDpi5+/WUcNJbL8v9JaX4emYB+G9Ghwp2bqXGYBxEg2uaUnVspkyfqaYVbFPM +Ng6D+Qvvlv6vdjO0fpL0j+FIB8bbqF+vti66OA/Ix48xpPzaEHqC5FcIeUbOVJMz2NCuF zkR67d2ImM/Dxf9NtYql6o/YmHLF8eWQ4pCtYZtkL1sgXbDNznDSsjPALZ/hz/uAPN94Ii d+SC8Hgc8bhOJZmuOSaofaGbxWnFpdF4euS5o/wNjHlcA8eWT78AGSq/OTIIHv1WDoVX5e AgF/QZp/yHxP6q3cVHntmHAmAjowRdqyQYEpJfXwjvaT107YMDXnuxz6fquY0w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744922705; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=2E77blHQKuaFuxhFZSOppKmGInyvHDF4Dwns3Jg3HZo=; b=eUw+E4a3IkeqpKwdsha9nRwzZpod25Hn4ixQwYyZflX4tRyoEmgrRmMmCogqMxRzXwNpNw UyVx4M8XwaZ1EDQrDIoOETQMR0i9ZqJl4GTi0uwsx5Xd/4BEagLiUHJGxwPtRNDmB7GUpz N6Rs7RA0lMzK1DWzDeKT+fP/PvMxE3MkHW6re+lq/mxVcBlQ0uuqS3tNahrGEaCzqQo1lC DzrRxpzGi25xP0j8vwaj7XHJHD8RvFXwFnIIl+U7OgpHXUUvcbMx7nL6enMRWj2lOdDch9 gE0KHiEyDOth094rEq+GwA2ZqKZ45x3Acsj3bWV3EMa5sSj0AogG6FODDHV99A== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zdqds1Zzdz13kp; Thu, 17 Apr 2025 20:45:05 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53HKj5ZN071205; Thu, 17 Apr 2025 20:45:05 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53HKj5fd071202; Thu, 17 Apr 2025 20:45:05 GMT (envelope-from git) Date: Thu, 17 Apr 2025 20:45:05 GMT Message-Id: <202504172045.53HKj5fd071202@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Konstantin Belousov Subject: git: ecc662c749b1 - main - PT_ATTACH: do not interrupt interruptible sleeps List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kib X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: ecc662c749b11434c63a0d3578fc40df6b4798ec Auto-Submitted: auto-generated The branch main has been updated by kib: URL: https://cgit.FreeBSD.org/src/commit/?id=ecc662c749b11434c63a0d3578fc40df6b4798ec commit ecc662c749b11434c63a0d3578fc40df6b4798ec Author: Konstantin Belousov AuthorDate: 2025-04-16 00:09:44 +0000 Commit: Konstantin Belousov CommitDate: 2025-04-17 20:33:47 +0000 PT_ATTACH: do not interrupt interruptible sleeps Handle the first SIGSTOP from the PT_ATTACH specially: instead of waking up some thread in the target process, execute sig_suspend_threads() in the debugger. This is equivalent to the action of the xthread, except that all threads are suspended without interruption. Reviewed by: markj Sponsored by: The FreeBSD Foundation MFC after: 2 weeks Differential revision: https://reviews.freebsd.org/D49678 --- sys/kern/kern_sig.c | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/sys/kern/kern_sig.c b/sys/kern/kern_sig.c index 520577961c3a..ba3b04ac6e22 100644 --- a/sys/kern/kern_sig.c +++ b/sys/kern/kern_sig.c @@ -2365,6 +2365,15 @@ tdsendsignal(struct proc *p, struct thread *td, int sig, ksiginfo_t *ksi) if (prop & SIGPROP_CONT) sigqueue_delete_stopmask_proc(p); else if (prop & SIGPROP_STOP) { + if ((p->p_flag & P_TRACED) != 0 && + (p->p_flag2 & P2_PTRACE_FSTP) != 0) { + td->td_dbgflags |= TDB_FSTP; + PROC_SLOCK(p); + sig_handle_first_stop(td, p, sig, true); + PROC_SUNLOCK(p); + return (0); + } + /* * If sending a tty stop signal to a member of an orphaned * process group, discard the signal here if the action @@ -3345,7 +3354,8 @@ issignal(struct thread *td) } } - if ((p->p_flag & (P_TRACED | P_PPTRACE)) == P_TRACED && + if (false && + (p->p_flag & (P_TRACED | P_PPTRACE)) == P_TRACED && (p->p_flag2 & P2_PTRACE_FSTP) != 0 && SIGISMEMBER(sigpending, SIGSTOP)) { /*