From nobody Tue Apr 15 18:16:58 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZcXRt4X56z5tZ7c; Tue, 15 Apr 2025 18:16:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZcXRt3h0rz3rjy; Tue, 15 Apr 2025 18:16:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744741018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VuJhH3+dSI1BjQ5MyETMMrm+kqFymBMWzRLpbXImU88=; b=CQC76oqP2fslb+NkJqKA2fxTZ6Mw6fDR668REx+p2Z3PiJC8B+nvniQhus4qG7CcmY4szq HvGQrhlEqroNoyfFCkooL1tv3hsAj6rZ6/pP3kQ4E3bM1qx1ctX/4XqDSe+vIyQMkfnemY xgr4TJEYe4/TtxCUTUlAd36C4+4ktKxJmZ8NgoE/9FKESCJoPebv8cGaeXe6uwDUnavHLW ORKhuSAu6QhWtkeBZHHscn1KmM4bC0KfnUqxTIi/MatvWVoGAYWGeR6PPgylaBGvjZV/0N ZV7zAcqzv2YowZ+L4OubouVDG6dAAH8gNbERWSxtgTleKigIE0N0vDMHuARvPA== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744741018; a=rsa-sha256; cv=none; b=VU+VdEEqOyQSAEwAZob7OG/tkiJMVz/qMsHqRfOZItU4WYiPSZsjYePgfuo0ZBGn6tTwIw TNUflvSJIZQku4OuBtkiuAnJuWyGKpMUXAi8Ttn/H4H1XHOe45mGJzNuTYffJB69q3UoWe GlSN/EIxCSXWdYSMAcSwwuKIv4ezRW6qefV1XQgjwp/a5xK6vLDcM5tZOjZKjqkiJbSxr1 oMoIuxavHPAFGZ8gclQQh9BjQg1vNQzeFyj5fVFm53Z/4EAeMAYvnl0AIv5E6Q6ZqiQg1b KIPlP1fTVsL4R0l0Y0ECoFtSr4jLns4OACyNcdKps20nLYn3Bru6ArXeQf8zSA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744741018; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=VuJhH3+dSI1BjQ5MyETMMrm+kqFymBMWzRLpbXImU88=; b=VmebiEDERtGm5LkmAYzZUAXnkxs5Zqv2p8rXVJqzEXae6D65U2p5LPqaE+W7vS2hSMz74O TIEpBMZGJo4jIWJs4wIs/cW4HUTdsBHKHcUWduK+QnkjuQ2lFbVu8n3vDg9YGGX+WQvYxg l+D6cwHVp3y3w02EDTvyfjbGI7Ls3KinsMSy4YFHfJgQEQSZ303vUb6CM4ygwobYyZ4NKb bVePISOdjmck7L30xs+4+lRLL9utAp4vH65nfS6X6TjeR9AqRq0OPbze59LIfPJqS0w7N0 uw2150j+VfM6JPg1KGrly58vLGds4vbhB8nw9bJFVUhpaTtsUriGDp8XQl22Kw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZcXRt3GfJzlGT; Tue, 15 Apr 2025 18:16:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53FIGwk4097849; Tue, 15 Apr 2025 18:16:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53FIGwGU097846; Tue, 15 Apr 2025 18:16:58 GMT (envelope-from git) Date: Tue, 15 Apr 2025 18:16:58 GMT Message-Id: <202504151816.53FIGwGU097846@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Ed Maste Subject: git: 3dcf2c2cafbc - main - OpenSSH: remove ability to enable DSA support (in configure) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: emaste X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 3dcf2c2cafbcf5d725103e6051e70c81a121eb18 Auto-Submitted: auto-generated The branch main has been updated by emaste: URL: https://cgit.FreeBSD.org/src/commit/?id=3dcf2c2cafbcf5d725103e6051e70c81a121eb18 commit 3dcf2c2cafbcf5d725103e6051e70c81a121eb18 Author: Ed Maste AuthorDate: 2025-04-09 15:17:10 +0000 Commit: Ed Maste CommitDate: 2025-04-15 18:12:55 +0000 OpenSSH: remove ability to enable DSA support (in configure) DSA is deprecated and upstream OpenSSH is in the process of removing it. From OpenSSH-portable 10.0, cherry-pick the configure change so that we can independently decide what to merge to stable branches. This change has no direct user-facing impact, as the upstream configure script is not used in the FreeBSD build process. It is worth noting as part of OpenSSH's full removal of DSA support. Reviewed by: jlduran, philip Relnotes: Yes Obtained from: OpenSSH-portable 6c9872faa1c2 Sponsored by: The FreeBSD Foundation --- crypto/openssh/configure.ac | 30 ------------------------------ 1 file changed, 30 deletions(-) diff --git a/crypto/openssh/configure.ac b/crypto/openssh/configure.ac index df05a54b8f63..dbe5b238fb75 100644 --- a/crypto/openssh/configure.ac +++ b/crypto/openssh/configure.ac @@ -2140,16 +2140,6 @@ AC_ARG_WITH([security-key-builtin], [ enable_sk_internal=$withval ] ) -enable_dsa= -AC_ARG_ENABLE([dsa-keys], - [ --enable-dsa-keys enable DSA key support [no]], - [ - if test "x$enableval" != "xno" ; then - enable_dsa=1 - fi - ] -) - AC_SEARCH_LIBS([dlopen], [dl]) AC_CHECK_FUNCS([dlopen]) AC_CHECK_DECL([RTLD_NOW], [], [], [#include ]) @@ -3258,26 +3248,6 @@ if test "x$openssl" = "xyes" ; then AC_MSG_RESULT([no]) ] ) - - openssl_dsa=no - if test ! -z "$enable_dsa" ; then - AC_CHECK_DECLS([OPENSSL_NO_DSA], [], [ - AC_CHECK_DECLS([OPENSSL_IS_BORINGSSL], [], - [ openssl_dsa=yes ], - [ #include ] - ) - ], - [ #include ] - ) - AC_MSG_CHECKING([whether to enable DSA key support]) - if test "x$openssl_dsa" = "xno"; then - AC_MSG_ERROR([DSA requested but not supported by OpenSSL]) - else - AC_MSG_RESULT([yes]) - AC_DEFINE([WITH_DSA], [1], - [DSA keys explicitly enabled]) - fi - fi fi # PKCS11/U2F depend on OpenSSL and dlopen().