From nobody Mon Apr 14 14:07:42 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Zbpyk4Nnsz5ssc6; Mon, 14 Apr 2025 14:07:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Zbpyk3Wxnz3Qgq; Mon, 14 Apr 2025 14:07:42 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744639662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4ThPx4huGoAIv7CMxqgDsUneRwSXbBka1hI0J2OOYyM=; b=h/UrF8Gh9cUzS12LFk8GgDTDhaKBavuPWfhIUafWgikN/HX0RyQFW6dlaLI7AtgpSeLdog nhK5awN8zq6C5qVMTGYEsJFZ3iEUFTazEsgThtGicwsOJZTADhzEJgT5TysfYxDB8fCxHK v40l7c9T6BPXJfVgKtajfCK96cCjhTseOt4rhIdoqUTD6NhBIpzji+prj/QIhDCGbWBc41 euTFwmRiwtmU2mTXOvLrv9DqSRd/bPjDWr9xdJ+LThtaNyUCfdigjiWxFqO0bP0mcmP7OA DSdpgk8NHWPYDWrh6yXvY2uM/+t++A7kTvJk3M77NqskcTD2QFR3RVCXHrFCow== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744639662; a=rsa-sha256; cv=none; b=DVQw4FqM8C6dqyW7ez2O5Nz7YX8k21vuIorW5wIkc0VuKx8B9SzF91utOIp8+0NT1X+1r8 cqZSmdUaEWPLSFlZnyPbqwXgWQ9n5ITeALEVGAmz07CCZZf06f4e9meXymNUJauSJCos9U lu5Wp7YIK9R8UsY5tcFvqVb/zZG4kGuhZ97GBjdWrnhK8pxSn8xHb/fksrskVXtFJFIx1k HILCvgKLdW48ZDQMPmwrskRFyfO4UjUBtL6CkEzQQPvB3ryV9qQ1Ji85eUctJBEOWi5A9n 7EH1tfX8i4m0Y61hqpeUwc/glHOOneYn6dqtGdljeHPE3FUwrKFUDWOlnnV/0w== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744639662; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=4ThPx4huGoAIv7CMxqgDsUneRwSXbBka1hI0J2OOYyM=; b=tF0IwWVL36tS2Xcw/SpO+35SOiZeR8qfbr8RWwHW8wk/kFeekYqRmvQ9z8wtZ/CCKh0958 +LppUSjP8iEHdJ/ysirSpydYsEVTfyD9V6wzoo0eMW9d7hKAcF0CujaBLKrvxURrBxK196 VXI8aMe1yqbVnNXoixOPmsFavhVR7E8wxye3zXgK5dJX4r5VEcsUe8DjAo5tCcI1uE2sMd JdfgCSUxZG3Z7rYHWvbA51i8fuILkKDUGErMve7Zs9QCeqwVYtkZDW1FnMeno/8T1LAM4Z 8CX5b0IPxQp6t10gk9CBYT9xGe+lZ63y2luxFPpd5Bw/wyv/SHT/YXy2G+O8rw== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Zbpyk2VXnzs1c; Mon, 14 Apr 2025 14:07:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53EE7g8a032488; Mon, 14 Apr 2025 14:07:42 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53EE7gxj032485; Mon, 14 Apr 2025 14:07:42 GMT (envelope-from git) Date: Mon, 14 Apr 2025 14:07:42 GMT Message-Id: <202504141407.53EE7gxj032485@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Bjoern A. Zeeb" Subject: git: 832b8e986c68 - main - LinuxKPI: 802.11: increase mbufq lengths List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: bz X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 832b8e986c68a43ecf2d6b4af805aaf37087f7d9 Auto-Submitted: auto-generated The branch main has been updated by bz: URL: https://cgit.FreeBSD.org/src/commit/?id=832b8e986c68a43ecf2d6b4af805aaf37087f7d9 commit 832b8e986c68a43ecf2d6b4af805aaf37087f7d9 Author: Bjoern A. Zeeb AuthorDate: 2025-04-13 20:57:13 +0000 Commit: Bjoern A. Zeeb CommitDate: 2025-04-14 14:06:50 +0000 LinuxKPI: 802.11: increase mbufq lengths Increase the mbufq lengths we use in the RX and TX path to decouple the lower and upper parts (currently using taskqs which likely need to be replaced as well now -- was asked not to add more sophisticated concepts 2-ish years ago). The old values of IFQ_MAXLEN (50) are a tad too small so bump them to 32 * NAPI_POLL_WEIGHT (32 * 64) which seems to be mostly enough now not to drop mbufs anymore (by not overflowing the queues). As a side effect TCP became a lot happier as well growing throughput towards where UDP is already. There is more fish to fry but we are also doing ~750 Mbits/sec TX and 400 Mbit/s RX TCP at VHT160 now. Sponsored by: The FreeBSD Foundation MFC after: 3 days --- sys/compat/linuxkpi/common/src/linux_80211.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sys/compat/linuxkpi/common/src/linux_80211.c b/sys/compat/linuxkpi/common/src/linux_80211.c index 34b2a3a2f8f9..29f4a95f0336 100644 --- a/sys/compat/linuxkpi/common/src/linux_80211.c +++ b/sys/compat/linuxkpi/common/src/linux_80211.c @@ -786,7 +786,7 @@ lkpi_lsta_alloc(struct ieee80211vap *vap, const uint8_t mac[IEEE80211_ADDR_LEN], /* Deferred TX path. */ LKPI_80211_LSTA_TXQ_LOCK_INIT(lsta); TASK_INIT(&lsta->txq_task, 0, lkpi_80211_txq_task, lsta); - mbufq_init(&lsta->txq, IFQ_MAXLEN); + mbufq_init(&lsta->txq, 32 * NAPI_POLL_WEIGHT); lsta->txq_ready = true; return (lsta); @@ -5599,7 +5599,7 @@ linuxkpi_ieee80211_alloc_hw(size_t priv_len, const struct ieee80211_ops *ops) /* Deferred RX path. */ LKPI_80211_LHW_RXQ_LOCK_INIT(lhw); TASK_INIT(&lhw->rxq_task, 0, lkpi_80211_lhw_rxq_task, lhw); - mbufq_init(&lhw->rxq, IFQ_MAXLEN); + mbufq_init(&lhw->rxq, 32 * NAPI_POLL_WEIGHT); lhw->rxq_stopped = false; /*