From nobody Fri Apr 11 13:52:53 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZYyn21YlPz5s3TN; Fri, 11 Apr 2025 13:52:54 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZYyn20TF7z40MS; Fri, 11 Apr 2025 13:52:54 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744379574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AbPqliIClCNTo2Rk/7VzlHctB/id62ua+8qrtf8ahgg=; b=Y+eOcNUePtPMFFBHhx12R5nR5jWXH2DOdzuR9/k6pY/YOhIEja9+RnkNqvtaeNOkWTQ33L xMPexIhO9FwUMAk1ANDupBIrb+64JfdRM+rjCSxWMy3G06Yx1Y5zbKbPjO3s1VRJLpA4Ei pZfKk0MCH8WgvvL9AUCZLwsjabCfQrLoS90+fDIC0aA1rV2SNWCrtQNN9DYtcXKxjLdRxB PMIRAllmDLmf45froyPpxQ62q9Zxp0wn+a07Bt+wgHisLSvEaofDXnmqPbK8C/5Zrw7QoA VhzHkGmf375fkgJQePk2UvEGm6pER6+w+swOHrZM1i5zxuWGfnjOkRvWWrIRvw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744379574; a=rsa-sha256; cv=none; b=RPygKfic3TED5ujITs+P+gpBjhjwf2i8OPYwhqmCZUiFSV69td/wrdMGYpoWR8BsK1/kAs umAZwe0tTbf6WE67jz7AKHonjEEGVgxlDHLufv4+vWtqFkbCOfZiusCrYS+Ps2xpw71W01 Sr0wC3/6ICqgs09lZwHm5hHipDynuTuPdQ5s3ZvpzyBzpWjtFV+HJl2lPsu5hEy7+h1Gt4 CPic5ycox4Z2dLK85xaw3xc0p21qnCdl6YFeq0dTUfhYAS8Uet5wxhCZ/KV/X2Wc+VYBvl 102rP9b0cvYVTy6/CYGgAkCRKIlXHDgi3/cUm9/4XmhjzNZu1e9gs/SLJoVKww== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744379574; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=AbPqliIClCNTo2Rk/7VzlHctB/id62ua+8qrtf8ahgg=; b=OGz+CFhWQhFRm8XhsdM2y9Iufx0fMvZtzWmLMVn6iXdrSqJdw6WzetRTl9VJt995rxRcu1 OQtfUdK5BCLLn7PWSzOp14th9w/g4NTEu7SooSsSnL05/RZVHaMw38thrkqGgm2m0qC0F6 sZtB9515ohRCxGtr7LxOz8tkqqcTKgL5Hp10LFsK8QxzK8dNhWrtUsBmq2+Xd11bhVvKLL Tt/0j7HRBW3eu9lEW7G1pFV0afGFOXRvA8X1DpWd4F/QbYSl206UK5tgLtJ60IFYDQuSQ5 ARaXJQQdakbJWrjFWRZ1UoTnB00qvEAZ14ASKno7mqAEN/0sYfcuQqONdAw2Hg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZYyn16zxczbwP; Fri, 11 Apr 2025 13:52:53 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 53BDqrr1033815; Fri, 11 Apr 2025 13:52:53 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 53BDqrmc033812; Fri, 11 Apr 2025 13:52:53 GMT (envelope-from git) Date: Fri, 11 Apr 2025 13:52:53 GMT Message-Id: <202504111352.53BDqrmc033812@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: John Baldwin Subject: git: 75a24e7f9afb - main - ctld: Disable -Wshadow for GCC List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: jhb X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 75a24e7f9afb128138c3b3462b80731cab0f5bdd Auto-Submitted: auto-generated The branch main has been updated by jhb: URL: https://cgit.FreeBSD.org/src/commit/?id=75a24e7f9afb128138c3b3462b80731cab0f5bdd commit 75a24e7f9afb128138c3b3462b80731cab0f5bdd Author: John Baldwin AuthorDate: 2025-04-11 13:34:36 +0000 Commit: John Baldwin CommitDate: 2025-04-11 13:52:39 +0000 ctld: Disable -Wshadow for GCC GCC raises shadow warnings in C++ when a global function shadows a structure type name (since it shadows the constructors for that type). System headers are full of such cases (and some such as struct sigaction vs sigaction() are mandated by POSIX), so just disable the warning. For example: In file included from usr.sbin/ctld/ctld.cc:33: sys/sys/event.h:366:20: error: 'int kqueue()' hides constructor for 'struct kqueue' [-Werror=shadow] 366 | int kqueue(void); | ^ sys/sys/event.h:371:43: error: 'int kevent(int, const kevent*, int, kevent*, int, const timespec*)' hides constructor for 'struct kevent' [-Werror=shadow] 371 | const struct timespec *timeout); | ^ In file included from usr.sbin/ctld/ctld.cc:37: sys/sys/stat.h:396:63: error: 'int stat(const char*, stat*)' hides constructor for 'struct stat' [-Werror=shadow] 396 | int stat(const char * __restrict, struct stat * __restrict); | ^ Reported by: bz --- usr.sbin/ctld/Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/usr.sbin/ctld/Makefile b/usr.sbin/ctld/Makefile index f96f3152e061..79c69c95fbb1 100644 --- a/usr.sbin/ctld/Makefile +++ b/usr.sbin/ctld/Makefile @@ -14,6 +14,7 @@ CFLAGS+= -I${SRCTOP}/sys/dev/iscsi CFLAGS+= -I${SRCTOP}/lib/libiscsiutil #CFLAGS+= -DICL_KERNEL_PROXY NO_WCAST_ALIGN= +CXXWARNFLAGS.gcc= -Wno-shadow MAN= ctld.8 ctl.conf.5 LIBADD= bsdxml iscsiutil md sbuf util ucl m nv