From nobody Wed Apr 09 19:30:46 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZXtMr5csWz5sGHy; Wed, 09 Apr 2025 19:30:48 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZXtMp6CwRz45gp; Wed, 09 Apr 2025 19:30:46 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744227046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QWJ8qg3yEZRgMqIAuF2sCkOfhuVFUoDLLQO4SEPe1bI=; b=gyGZusu978cw6GS+5lqz2jgXJcg5snZjLozok/j24d3WVBBFh2IqOU1NmHHzCiDmh0w0ON 9kWn3ZtBO2rpvFkUiKKe2g91MfQzcvObfiMkzk1NDdjtSyDTV2dUWmFZrONMmBtapIdNDd euqHRjueB8CY2AoDG6gWTvcbDN1425mxvX+eCqUOsp3sVfER0alI9l/uqvkyPqR5u4JEHB dAcE2wd46Lfh+ixoZ6CHRHjPHa+U5KkIpxM+aW+gcAriIxvX7fpKbaZUe+3l0bNekAV9uG MWum/tV61IUDLPDZWuyTEulkwU+MXsjiHPPWPERjBYq1XHYDN1aEDW34OD5jXw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1744227046; a=rsa-sha256; cv=none; b=X8d2UyclUUTBMOFWwWAWdZfQdiO2+53L4ccaazkYQNgovhInrN5JpHrz6ldsDh9HR9g9gt QIkFOJDlQqW8zaOOYv0bzmM6O17ZIPMuQ7HJt9m/LC+Gr+SHXsLHHdMqXd1NLZEh5WDHEn 66JhABMAyEiCRapbj25O1RuKMg4XdMuchNM7t7ccbTpKK2+3shoeYK8gKqb/dfDWHYT9Ol gnXwYIBHz/EVO7TfxxWfpCnwbLc8Ipl6m52gAuWrKEHimUnqAwbbDN21x4lzvT6+0htxQn buGt00vH/h9DWPV0cmU2fQLpI0EKleNYsDEpMWbtjDCW4M+bwM01xZmbgf2Log== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1744227046; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=QWJ8qg3yEZRgMqIAuF2sCkOfhuVFUoDLLQO4SEPe1bI=; b=TWlfBnMgvMaQSC1yL3GgsDHCHbcl+89O1Y9zK9u8n2PC0pvCf2nsiSBFE+gO6QUiORBlfH RjZQVYb2KEsg4H+UalDOtjAwGDMkb8QCYwAIrABMGAauVcPrgo6b55Ds7T3cEzv+MqBtze E4cFcj9XYxQAudlPXZ16zgWX5XvVv2mzyPU52L9SeoJsnT/gZNwbgKluqoTmCtDJ7Gvday R8fHHdYNpPX2c8AS3/kmKFuEVXPuV9oq6232Z48FIeKcNiuOeQzO00gsP9/bKxUCsXFt4v L2Wc6GM7Wn+xQY6377NVg8CXQXAZkqZ88jIA5BxwHBiNloHUVilq9fo7gkNnwQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZXtMp5ksQzVlP; Wed, 09 Apr 2025 19:30:46 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 539JUkpn080143; Wed, 9 Apr 2025 19:30:46 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 539JUkIE080140; Wed, 9 Apr 2025 19:30:46 GMT (envelope-from git) Date: Wed, 9 Apr 2025 19:30:46 GMT Message-Id: <202504091930.539JUkIE080140@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Kristof Provost Subject: git: 02a12814c14f - main - pf.conf.5: remove incorrect performance comparison List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: kp X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 02a12814c14fb699195703a647cf4a0393586ebe Auto-Submitted: auto-generated The branch main has been updated by kp: URL: https://cgit.FreeBSD.org/src/commit/?id=02a12814c14fb699195703a647cf4a0393586ebe commit 02a12814c14fb699195703a647cf4a0393586ebe Author: Kristof Provost AuthorDate: 2025-04-09 15:28:24 +0000 Commit: Kristof Provost CommitDate: 2025-04-09 19:30:17 +0000 pf.conf.5: remove incorrect performance comparison In FreeBSD's pf the state lookup is done through a hash table, not an RB tree as on OpenBSD. Remove a misleading line from the man page. Sponsored by: Rubicon Communications, LLC ("Netgate") --- share/man/man5/pf.conf.5 | 4 ---- 1 file changed, 4 deletions(-) diff --git a/share/man/man5/pf.conf.5 b/share/man/man5/pf.conf.5 index bc9157d6a5f8..64da49845a32 100644 --- a/share/man/man5/pf.conf.5 +++ b/share/man/man5/pf.conf.5 @@ -1659,10 +1659,6 @@ allows echo requests (such as those created by out statefully, and matches incoming echo replies correctly to states. .Pp Also, looking up states is usually faster than evaluating rules. -If there are 50 rules, all of them are evaluated sequentially in O(n). -Even with 50000 states, only 16 comparisons are needed to match a -state, since states are stored in a binary search tree that allows -searches in O(log2 n). .Pp Furthermore, correct handling of ICMP error messages is critical to many protocols, particularly TCP.