From nobody Sun Apr 06 01:37:57 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZVZjT4QLRz5sgjM; Sun, 06 Apr 2025 01:38:05 +0000 (UTC) (envelope-from chuq@chuq.com) Received: from mail.vc.panix.com (mail.vc.panix.com [166.84.1.92]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZVZjT2ZRxz3Gc4; Sun, 06 Apr 2025 01:38:05 +0000 (UTC) (envelope-from chuq@chuq.com) Authentication-Results: mx1.freebsd.org; none Received: from vc.chuq.com (vc.chuq.com [166.84.7.169]) by mail.vc.panix.com (Postfix) with ESMTPS id 4ZVZjM0ddsz4slP; Sat, 5 Apr 2025 21:37:59 -0400 (EDT) Received: from spathi.chuq.com (spathi.chuq.com [24.6.146.244]) by vc169.vc.panix.com (Postfix) with ESMTPS id 93E223B5D79; Sat, 05 Apr 2025 18:37:58 -0700 (PDT) (envelope-from chuq@chuq.com) Received: by spathi.chuq.com (Postfix, from userid 1022) id B25213CFFA25; Sat, 5 Apr 2025 18:37:57 -0700 (PDT) Date: Sat, 5 Apr 2025 18:37:57 -0700 From: Chuck Silvers To: Cy Schubert Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 1ac6ea8a0251 - main - kerberos5, libcom_err, others: append to LDFLAGS instead of replacing Message-ID: References: <202504052120.535LKCpL016160@gitrepo.freebsd.org> <20250406012731.EB58124B@slippy.cwsent.com> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20250406012731.EB58124B@slippy.cwsent.com> X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:2033, ipnet:166.84.0.0/16, country:US] X-Rspamd-Queue-Id: 4ZVZjT2ZRxz3Gc4 X-Spamd-Bar: ---- On Sat, Apr 05, 2025 at 06:27:31PM -0700, Cy Schubert wrote: > In message <202504052120.535LKCpL016160@gitrepo.freebsd.org>, Chuck Silvers > wri > tes: > > The branch main has been updated by chs: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=1ac6ea8a0251243d34f0ede2315b8f2b > > 4393080d > > > > commit 1ac6ea8a0251243d34f0ede2315b8f2b4393080d > > Author: Chuck Silvers > > AuthorDate: 2025-04-05 21:18:35 +0000 > > Commit: Chuck Silvers > > CommitDate: 2025-04-05 21:19:57 +0000 > > > > kerberos5, libcom_err, others: append to LDFLAGS instead of replacing > > > > Reviewed by: imp, emaste > > Differential Revision: https://reviews.freebsd.org/D49548 > > --- > > kerberos5/lib/libasn1/Makefile | 2 +- > > kerberos5/lib/libgssapi_krb5/Makefile | 2 +- > > kerberos5/lib/libgssapi_ntlm/Makefile | 2 +- > > kerberos5/lib/libgssapi_spnego/Makefile | 2 +- > > kerberos5/lib/libhdb/Makefile | 2 +- > > kerberos5/lib/libheimbase/Makefile | 2 +- > > kerberos5/lib/libheimntlm/Makefile | 2 +- > > kerberos5/lib/libhx509/Makefile | 2 +- > > kerberos5/lib/libkadm5clnt/Makefile | 2 +- > > kerberos5/lib/libkadm5srv/Makefile | 2 +- > > kerberos5/lib/libkafs5/Makefile | 2 +- > > kerberos5/lib/libkdc/Makefile | 2 +- > > kerberos5/lib/libkrb5/Makefile | 2 +- > > kerberos5/lib/libwind/Makefile | 2 +- > > kerberos5/libexec/digest-service/Makefile | 2 +- > > kerberos5/libexec/hprop/Makefile | 2 +- > > kerberos5/libexec/hpropd/Makefile | 2 +- > > kerberos5/libexec/ipropd-master/Makefile | 2 +- > > kerberos5/libexec/ipropd-slave/Makefile | 2 +- > > kerberos5/libexec/kadmind/Makefile | 2 +- > > kerberos5/libexec/kcm/Makefile | 2 +- > > kerberos5/libexec/kdc/Makefile | 2 +- > > kerberos5/libexec/kpasswdd/Makefile | 2 +- > > kerberos5/usr.bin/kadmin/Makefile | 2 +- > > kerberos5/usr.bin/kpasswd/Makefile | 2 +- > > kerberos5/usr.sbin/iprop-log/Makefile | 2 +- > > kerberos5/usr.sbin/kstash/Makefile | 2 +- > > lib/libcom_err/Makefile | 2 +- > > tools/regression/tls/ttls3/Makefile | 2 +- > > tools/tools/net80211/w00t/Makefile.inc | 2 +- > > 30 files changed, 30 insertions(+), 30 deletions(-) > > > > What was the reason for this? this is so that things added to LDFLAGS by eg. /etc/make.conf or /etc/src.conf are not lost just because an individual makefile wants to add something to LDFLAGS as well. -Chuck