From nobody Thu Apr 03 21:04:22 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZTDkZ52VXz5sTrX; Thu, 03 Apr 2025 21:04:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZTDkZ4MVnz3tQp; Thu, 03 Apr 2025 21:04:22 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743714262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KeBUB57Si6Z8wPJwv5D23Vt6Z2W9cUQHUF6yAPvM2Y0=; b=Fzcg6jitAydI3ytUxw5Ik20x8yTi5QAo82agUYaSU63AP+uCnaBr63y8fmykfpjV2+e6Ei jBCKwgUsI3xwmyDG0CRZa+aq+ZgdxZIRjNE+6n9c8cp9v743vkqjcik1ZGMWp4Xkoo5gBA IOv7m0GdW616EEw5Tfa7QhdE/pLYZxGlQC2aJk9OnF0rUb5QFIosn4c426QUiriq8TdIbz ZX843M9OeQWoPcjm2NmW4Frycw0bCt7I7u2p/IVfTgheXminbCr+lUNRXrkOAPW9hf6SUd LcMf+jnV34gB3vjqPs+Pj/Utl9roVA0pqir85cOtrwAHZCTT4BvqdygOQnKO+Q== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1743714262; a=rsa-sha256; cv=none; b=EgrXIsaF+EuCVZTuzZ0nmqQ1yLWLK5DKg/5TVILkUTijWSxGkC4AjsX/AX+dJJg5Xun+zC 4v0/RYH/SNtQxGWziNtSFXXcV5BdKvL2FVKU1EMbt7tC1/KZm0WQyZrj4bSyt/Cp+MTH4C g0AmwZnjncjMGovnyv4rt4DkGfk0SmrXhX5lo3Zwvi7dmWdEQEEfBFuRit/XWgQIAZFL9G u1XVGPvyLqUWrUgEpgvirqTt99Ng1Z6GNluJ0XBso/loYUWj/YaQu6aYzDh/Vyx3rVsPfm YycAARqxLywWfVswh/QpyMjZY1eUyRMwqJwRkm8r3VtzXKrIybWK7RRE7BkrXg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1743714262; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KeBUB57Si6Z8wPJwv5D23Vt6Z2W9cUQHUF6yAPvM2Y0=; b=wbMs6omjoG/N5k2XfkslFvGZQblcKgalIUQ3sdIVwkojf8WMQheC46fbpZs9jH5Sq/4b+l v+fywRKdERZj1EtaA4nNZAUDiJOGHG2BCAITMOhCQEXRhr631srgaWmvgQsWhcZhv8pfFX cnbSXRdeDcqVJSWiQG0pg/kMZ8FO0nmXp0v39ACeTpHBlUVhrvUQ/V6jNu+klHeC4SUemc jyoWyYTTFHcAxzQ9Me06vQePWKgi0DWCIBYBIxal3jed6ZKUK6bBxo6QUMVl87UK4+5oYv g+xA+EY4hgaiI2aYIAZI/IJcsnGwshYTrXEUwxYH8M0Ps14A19CFTiyiwCRjRQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4ZTDkZ3rngz2XN; Thu, 03 Apr 2025 21:04:22 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 533L4MC6010052; Thu, 3 Apr 2025 21:04:22 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 533L4MBG010049; Thu, 3 Apr 2025 21:04:22 GMT (envelope-from git) Date: Thu, 3 Apr 2025 21:04:22 GMT Message-Id: <202504032104.533L4MBG010049@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 94acddd2ad01 - main - tcp: improve initializing the fields in tcp_log_buffer List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 94acddd2ad0142221124c3fb7fe3778a5a1f8036 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=94acddd2ad0142221124c3fb7fe3778a5a1f8036 commit 94acddd2ad0142221124c3fb7fe3778a5a1f8036 Author: Michael Tuexen AuthorDate: 2025-04-03 06:59:46 +0000 Commit: Michael Tuexen CommitDate: 2025-04-03 06:59:46 +0000 tcp: improve initializing the fields in tcp_log_buffer Initialize the fields in the tcp_log_buffer in the sequence they appear in the structure and add the initialization of tlb_flex1, tlb_flex2, and _pad[]. Reviewed by: rrs, Peter Lei MFC after: 3 days Sponsored by: Netflix, Inc. Differential Revision: https://reviews.freebsd.org/D49652 --- sys/netinet/tcp_log_buf.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/sys/netinet/tcp_log_buf.c b/sys/netinet/tcp_log_buf.c index 7b937958a4fb..e9ad05382b81 100644 --- a/sys/netinet/tcp_log_buf.c +++ b/sys/netinet/tcp_log_buf.c @@ -1857,16 +1857,21 @@ retry: COPY_STAT_T(rttvar); COPY_STAT(rcv_up); COPY_STAT(rcv_adv); + COPY_STAT_T(flags2); COPY_STAT(rcv_nxt); COPY_STAT(rcv_wnd); COPY_STAT_T(dupacks); COPY_STAT_T(segqlen); COPY_STAT(snd_numholes); - COPY_STAT(snd_scale); - COPY_STAT(rcv_scale); - COPY_STAT_T(flags2); + log_buf->tlb_flex1 = 0; + log_buf->tlb_flex2 = 0; COPY_STAT_T(fbyte_in); COPY_STAT_T(fbyte_out); + COPY_STAT(snd_scale); + COPY_STAT(rcv_scale); + log_buf->_pad[0] = 0; + log_buf->_pad[1] = 0; + log_buf->_pad[2] = 0; #undef COPY_STAT #undef COPY_STAT_T /* Copy stack-specific info. */