From nobody Wed Apr 02 19:43:28 2025 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4ZSZzl714pz5rW1Z; Wed, 02 Apr 2025 19:43:31 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Received: from omta004.cacentral1.a.cloudfilter.net (omta002.cacentral1.a.cloudfilter.net [3.97.99.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client CN "Client", Issuer "CA" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4ZSZzl53cgz3Pmw; Wed, 02 Apr 2025 19:43:31 +0000 (UTC) (envelope-from cy.schubert@cschubert.com) Authentication-Results: mx1.freebsd.org; none Received: from shw-obgw-4004a.ext.cloudfilter.net ([10.228.9.227]) by cmsmtp with ESMTPS id zsrUtdSXW5Mqy03zmuHT83; Wed, 02 Apr 2025 19:43:30 +0000 Received: from spqr.komquats.com ([70.66.136.217]) by cmsmtp with ESMTPSA id 03zluUDD2JhBP03zmuhKR9; Wed, 02 Apr 2025 19:43:30 +0000 X-Auth-User: cschuber X-Authority-Analysis: v=2.4 cv=QY3Fvdbv c=1 sm=1 tr=0 ts=67ed9362 a=h7br+8Ma+Xn9xscxy5znUg==:117 a=h7br+8Ma+Xn9xscxy5znUg==:17 a=kj9zAlcOel0A:10 a=XR8D0OoHHMoA:10 a=6I5d2MoRAAAA:8 a=EkcXrb_YAAAA:8 a=YxBL1-UpAAAA:8 a=QJRumn0MJZXuOLPX7-kA:9 a=CjuIK1q_8ugA:10 a=LK5xJRSDVpKd5WXXoEvA:22 a=Ia-lj3WSrqcvXOmTRaiG:22 Received: from slippy.cwsent.com (slippy [10.1.1.91]) by spqr.komquats.com (Postfix) with ESMTP id BC0FD244; Wed, 02 Apr 2025 12:43:28 -0700 (PDT) Received: by slippy.cwsent.com (Postfix, from userid 1000) id 8A364214; Wed, 02 Apr 2025 12:43:28 -0700 (PDT) X-Mailer: exmh version 2.9.0 11/07/2018 with nmh-1.8+dev Reply-to: Cy Schubert From: Cy Schubert X-os: FreeBSD X-Sender: cy@cwsent.com X-URL: http://www.cschubert.com/ To: Olivier Certner cc: Mitchell Horne , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: e69623451ea6 - main - mccomphy: add support for YT8531 In-reply-to: <2992932.slGk94SIus@ravel> References: <202504021657.532Gv93w049180@gitrepo.freebsd.org> <2992932.slGk94SIus@ravel> Comments: In-reply-to Olivier Certner message dated "Wed, 02 Apr 2025 21:28:33 +0200." List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Date: Wed, 02 Apr 2025 12:43:28 -0700 Message-Id: <20250402194328.8A364214@slippy.cwsent.com> X-CMAE-Envelope: MS4xfDid13pctxuSV98IYaJdeJVjujXduY4FpEhLKwDNolfhcPfibeLWvKnUq8tbK0ioyYjFVRzWpHTfjoMiqnDFUqja8rEr6tkdbmOZ/tzyGxqA8wJpWg2+ 0QVUXw5+yoNgy9qLnlqBlHWS9E1OXDkxtjN8dJCxV2+t/hdcjR4Q3JQyKRlfUy62WYBw5vegoKEa5bBywr8gWkTkA4g9+azjd3m7U7vb2Q0xzOihtO0zT+rW 5BIV6ILe+ATMtXm7nHjF70BXJqIGvA7OEc/UbKI2e8DNCYt5QvpJNEz7TkQgr7j5mR6tU+EOAeBalSOpkOxyZFCwLom481wZtnYIvkqpQEGcTlSrgamKB+M7 K1SiEmXL X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:16509, ipnet:3.96.0.0/15, country:US] X-Rspamd-Queue-Id: 4ZSZzl53cgz3Pmw X-Spamd-Bar: ---- In message <2992932.slGk94SIus@ravel>, Olivier Certner writes: > > Hi Mitchell, > > This commit is likely the cause of the current build failure on amd64, see: > https://ci.freebsd.org/job/FreeBSD-main-amd64-build/31518/ > > Thanks and regards. > > -- > Olivier Certner Hmm. I wonder why this was committed in the first place. The review listed isn't this commit. Should this be reverted to a) correct the commit log message to document the correct revision and b) fix the build? -- Cheers, Cy Schubert FreeBSD UNIX: Web: https://FreeBSD.org NTP: Web: https://nwtime.org e^(i*pi)+1=0