From nobody Thu Nov 14 19:41:43 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Xq9Wr3gRDz5d4Dx; Thu, 14 Nov 2024 19:41:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Xq9Wr1DR1z41WQ; Thu, 14 Nov 2024 19:41:44 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731613304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zQ7POcbFgpXF7TMTpolq8l8bwO3/lbtOlt1rzTpVrgY=; b=LXMxW/LQBGuZBPWFr5vsLQ6gJUB/FdcRK3RxvfIg8F2IXkN52aEcP6I/9BEPnX2cdRYHDt /bXVOTdkzfytquTdKt6t1zNLT2BSoq4Qj+B2KArddVQZaD/6UEQg7lFn3BLQWcQpoz1yJH bgm6l9B0cUeyrV/L5yPmoETzlrL/RrcRsAPdfKfcFKvaJaByUETr3oyv7LaV9d5oAQ75eV 8AtZ2S2h//Rz60Zlq/PzmcApYmMZm6L8unTgRWZXmM8Bm9L1jRME6hLWycxDO2EUDPpIPm BCwZ2I5Vcci5NaTDX7tGPTbxad9pNGmSP65u/pKWHr8BWIBisoPygcBZ6/8J7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1731613304; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=zQ7POcbFgpXF7TMTpolq8l8bwO3/lbtOlt1rzTpVrgY=; b=LM4g/JoPO98VOrG1oDWukof5BuG6Unik9nWCTDAeQrX6vHMshi9CCXfHjoLFxII3BJHVA4 Vh6QLLbF1iYz/qWaT68frb/LzenECuZQArYo1Z4Ma6vobcqa2znR8CyGZlob955HgmaZlD qEsDqpjFyccBP70znn+BYgDAcn3k/f+GDTEFZiTupai2eTXbmo0qRm+sYSIChNqh4XHght Itw9foH8borfloixe9bkMuzgw19hCQ2Wv1ZCVHrDrLI/kumVH75bnEScCbpxcW3GpQNnWk fZh+7sozpnbRiF1/TOEcN5hZMqPcKK1671/kDBacajeTmfBwJtg9bJrJxnj54A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1731613304; a=rsa-sha256; cv=none; b=mE88X0Ey8k0QDOMW8uGFV0BdasKGdXGvjBFWipjryn8arWzfAGkrdFkp15Zfg/Tg5cTDE2 Xr4nOj3jJWWwviqQfNFxlUSH4gbe3SF4Ie+K4chLb3Ch2C3qeF8zPhOaS/6LwMiDQe/cSc bwEtoRtf35jJazJWbTbfhJZ8gomuI4eNofnCT6BLjYFKItVWTBEueYOzLHqMGpRXofWbY9 CcOUFrOsIEyvw7K52MPWGMCy2GEknQIWUjGdeDB3A6QTliKtH4H5xBi9X+2L99AgQqmNMj JzOCmQQ/ee1+2GTnfJo69jq0rJSruLuTk2Tomqp1KG7dMVEk5i6aSgfgX16fOA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Xq9Wr0rB0zrc1; Thu, 14 Nov 2024 19:41:44 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4AEJfiHX037341; Thu, 14 Nov 2024 19:41:44 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4AEJfhu1037338; Thu, 14 Nov 2024 19:41:43 GMT (envelope-from git) Date: Thu, 14 Nov 2024 19:41:43 GMT Message-Id: <202411141941.4AEJfhu1037338@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Gleb Smirnoff Subject: git: 0b4539ee542f - main - inpcb: gc unused argument of in_pcbconnect() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: glebius X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 0b4539ee542f7011160c07bf52af7f16739f4a92 Auto-Submitted: auto-generated The branch main has been updated by glebius: URL: https://cgit.FreeBSD.org/src/commit/?id=0b4539ee542f7011160c07bf52af7f16739f4a92 commit 0b4539ee542f7011160c07bf52af7f16739f4a92 Author: Gleb Smirnoff AuthorDate: 2024-11-14 19:39:13 +0000 Commit: Gleb Smirnoff CommitDate: 2024-11-14 19:39:13 +0000 inpcb: gc unused argument of in_pcbconnect() --- sys/netinet/in_pcb.c | 3 +-- sys/netinet/in_pcb.h | 3 +-- sys/netinet/tcp_syncache.c | 2 +- sys/netinet/tcp_usrreq.c | 2 +- sys/netinet/udp_usrreq.c | 2 +- sys/netinet6/udp6_usrreq.c | 2 +- 6 files changed, 6 insertions(+), 8 deletions(-) diff --git a/sys/netinet/in_pcb.c b/sys/netinet/in_pcb.c index 116ee149fecb..7c881817ac6e 100644 --- a/sys/netinet/in_pcb.c +++ b/sys/netinet/in_pcb.c @@ -1005,8 +1005,7 @@ in_pcbbind_setup(struct inpcb *inp, struct sockaddr_in *sin, in_addr_t *laddrp, * then pick one. */ int -in_pcbconnect(struct inpcb *inp, struct sockaddr_in *sin, struct ucred *cred, - bool rehash __unused) +in_pcbconnect(struct inpcb *inp, struct sockaddr_in *sin, struct ucred *cred) { u_short lport, fport; in_addr_t laddr, faddr; diff --git a/sys/netinet/in_pcb.h b/sys/netinet/in_pcb.h index a4b4075b3501..0cf5ca017963 100644 --- a/sys/netinet/in_pcb.h +++ b/sys/netinet/in_pcb.h @@ -661,8 +661,7 @@ int in_pcballoc(struct socket *, struct inpcbinfo *); int in_pcbbind(struct inpcb *, struct sockaddr_in *, struct ucred *); int in_pcbbind_setup(struct inpcb *, struct sockaddr_in *, in_addr_t *, u_short *, struct ucred *); -int in_pcbconnect(struct inpcb *, struct sockaddr_in *, struct ucred *, - bool); +int in_pcbconnect(struct inpcb *, struct sockaddr_in *, struct ucred *); int in_pcbconnect_setup(struct inpcb *, struct sockaddr_in *, in_addr_t *, u_short *, in_addr_t *, u_short *, struct ucred *); void in_pcbdisconnect(struct inpcb *); diff --git a/sys/netinet/tcp_syncache.c b/sys/netinet/tcp_syncache.c index d0068a9d313b..606d808676e1 100644 --- a/sys/netinet/tcp_syncache.c +++ b/sys/netinet/tcp_syncache.c @@ -898,7 +898,7 @@ syncache_socket(struct syncache *sc, struct socket *lso, struct mbuf *m) sin.sin_port = sc->sc_inc.inc_fport; bzero((caddr_t)sin.sin_zero, sizeof(sin.sin_zero)); INP_HASH_WLOCK(&V_tcbinfo); - error = in_pcbconnect(inp, &sin, thread0.td_ucred, false); + error = in_pcbconnect(inp, &sin, thread0.td_ucred); INP_HASH_WUNLOCK(&V_tcbinfo); if (error != 0) goto abort; diff --git a/sys/netinet/tcp_usrreq.c b/sys/netinet/tcp_usrreq.c index 9a6e80363f0c..b5725eb1ce86 100644 --- a/sys/netinet/tcp_usrreq.c +++ b/sys/netinet/tcp_usrreq.c @@ -1471,7 +1471,7 @@ tcp_connect(struct tcpcb *tp, struct sockaddr_in *sin, struct thread *td) return (EISCONN); INP_HASH_WLOCK(&V_tcbinfo); - error = in_pcbconnect(inp, sin, td->td_ucred, true); + error = in_pcbconnect(inp, sin, td->td_ucred); INP_HASH_WUNLOCK(&V_tcbinfo); if (error != 0) return (error); diff --git a/sys/netinet/udp_usrreq.c b/sys/netinet/udp_usrreq.c index 9dad79e95b04..30c8fff5ea94 100644 --- a/sys/netinet/udp_usrreq.c +++ b/sys/netinet/udp_usrreq.c @@ -1648,7 +1648,7 @@ udp_connect(struct socket *so, struct sockaddr *nam, struct thread *td) } NET_EPOCH_ENTER(et); INP_HASH_WLOCK(pcbinfo); - error = in_pcbconnect(inp, sin, td->td_ucred, true); + error = in_pcbconnect(inp, sin, td->td_ucred); INP_HASH_WUNLOCK(pcbinfo); NET_EPOCH_EXIT(et); if (error == 0) diff --git a/sys/netinet6/udp6_usrreq.c b/sys/netinet6/udp6_usrreq.c index 414be35b5bef..c52c808a3299 100644 --- a/sys/netinet6/udp6_usrreq.c +++ b/sys/netinet6/udp6_usrreq.c @@ -1151,7 +1151,7 @@ udp6_connect(struct socket *so, struct sockaddr *nam, struct thread *td) inp->inp_vflag &= ~INP_IPV6; NET_EPOCH_ENTER(et); INP_HASH_WLOCK(pcbinfo); - error = in_pcbconnect(inp, &sin, td->td_ucred, true); + error = in_pcbconnect(inp, &sin, td->td_ucred); INP_HASH_WUNLOCK(pcbinfo); NET_EPOCH_EXIT(et); /*