From nobody Sun Nov 03 19:04:09 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4XhPCY3Kf9z5cd1t; Sun, 03 Nov 2024 19:04:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R10" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4XhPCY2Rfxz4rtx; Sun, 3 Nov 2024 19:04:09 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730660649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pqxUSDy+Lp/VgEsGFL2n6Ga/+TagsWstWcgIYcgdk5Y=; b=s4fZ/t9+V8zg7M5bQuhtVbnYoaEZku2F+IaxqiIqAiv/K1HpSj5yOvMuxJ68phWyRqmHkH 5IK9XKhYpx6LUxRoneaDAUtuer7+txE3pbeFMf2ljYfr7M4jnUfqq2hAEq1m2/a10KX12M ZselKAH5bwN1P9LIbepHX98aW6a7HrgLV+n3YEcDXE+QF1xluC9VVvECpD3D9xFHa5AmBH KZ3OF6ufiKUNpwyBSH+lrlHEW4fGw1uVYCxJ82UEkRYDLgSkfblFOJ4uhZC8mT2eE5xLVW pU2/MpHWuAJwDv+8fH0EhiDff+AbqIYI4CeUqalBWgpMEZr2YSJqT6abePbIXQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1730660649; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=pqxUSDy+Lp/VgEsGFL2n6Ga/+TagsWstWcgIYcgdk5Y=; b=PsbQmAJ9RJ3VrEpUWoAIW0zavsCR7n+vfSKFCufFtyszt/7qq26eKXtU0UfOt0YpSHaIL4 rkgFraY9zEtD2UbaCBA6zqEO6zirkz6SQZTHYgWFbL4ME/9kYlWu3RSpAOPaPxPm4+Encl 1PpBD5nIBJACdk/4SEoCPstPyzSmV8OVQ6sNK11ODjh+IczTSkVcgkE2PXBx86F2nfwHFJ pS6wP4byjaOhszNhoSprrog9lU9NGI2/aDjMsmM+nJwRe/dyWSvBwjqmJwlbIi9Ca3Thed O66HuC1GwsPQ899hsfwjRxzy2MAVB/B52ySScIw+bquqWr14Zlfdsv9QcyTq1g== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1730660649; a=rsa-sha256; cv=none; b=wubwkPy5xMGp4SNAZ8gVZyjf1qy99crmiR2jNnNbW4LVyc+rKv7elN8yom6WGDJbuEj899 iwkSeW3UGr8DYQQ8AsTPUx+pVLwziGk8Y53pzkXLd9zOCECqYOaHVgzx/0qcuzs2LhF7bv VbOG6+DFGHX7KtmMn4G5nJxgNJVTLtEJYupjVQvwV9X5qC9zNp4aPGm3gEfX/zKxDoQsph AtScZNTt5iPpyB1Qtk6p/gEfue3e+VBBKvhebbt3JqU8UP1GzHH+a6ejHNd9MhiON0tXlQ gCKBlI+8LDcM6wrWH1mD4U9LFxEh9KKs1EvPq4YcA478jWPSnlz+r1bDxXI2qg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4XhPCY21Rxz11rG; Sun, 3 Nov 2024 19:04:09 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 4A3J49wm052817; Sun, 3 Nov 2024 19:04:09 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 4A3J49b1052814; Sun, 3 Nov 2024 19:04:09 GMT (envelope-from git) Date: Sun, 3 Nov 2024 19:04:09 GMT Message-Id: <202411031904.4A3J49b1052814@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Christos Margiolis Subject: git: 181a31d83490 - main - sound: Move sndstat_register() call to pcm_setstatus() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: christos X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 181a31d8349088cbcead8dcbff8d62ee8af6c913 Auto-Submitted: auto-generated The branch main has been updated by christos: URL: https://cgit.FreeBSD.org/src/commit/?id=181a31d8349088cbcead8dcbff8d62ee8af6c913 commit 181a31d8349088cbcead8dcbff8d62ee8af6c913 Author: Christos Margiolis AuthorDate: 2024-11-03 19:02:37 +0000 Commit: Christos Margiolis CommitDate: 2024-11-03 19:02:37 +0000 sound: Move sndstat_register() call to pcm_setstatus() The d->status string is populated in pcm_setstatus() anyway, so call sndstat_register() after we populate it, and are closer to finalizing the device creation. Sponsored by: The FreeBSD Foundation MFC after: 1 week Reviewed by: dev_submerge.ch, markj Differential Revision: https://reviews.freebsd.org/D47323 --- sys/dev/sound/pcm/sound.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/sys/dev/sound/pcm/sound.c b/sys/dev/sound/pcm/sound.c index 5ca38ca622c9..3c4fb38fa4f5 100644 --- a/sys/dev/sound/pcm/sound.c +++ b/sys/dev/sound/pcm/sound.c @@ -293,6 +293,7 @@ pcm_setstatus(device_t dev, char *str) vchan_setmaxauto(d, snd_maxautovchans); strlcpy(d->status, str, SND_STATUSLEN); + sndstat_register(dev, d->status); PCM_LOCK(d); @@ -509,8 +510,6 @@ pcm_register(device_t dev, void *devinfo, int numplay, int numrec) if (numplay > 0 || numrec > 0) d->flags |= SD_F_AUTOVCHAN; - sndstat_register(dev, d->status); - return (0); }