git: 9370f49ad1c4 - main - qlnx: qlnxe: Fix kernel address leakage
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 28 May 2024 05:46:48 UTC
The branch main has been updated by kbowling:
URL: https://cgit.FreeBSD.org/src/commit/?id=9370f49ad1c4625cd73c4d84d3e42ed3e20fabbf
commit 9370f49ad1c4625cd73c4d84d3e42ed3e20fabbf
Author: Fuqian Huang <huangfq.daxian@gmail.com>
AuthorDate: 2024-05-28 05:45:52 +0000
Commit: Kevin Bowling <kbowling@FreeBSD.org>
CommitDate: 2024-05-28 05:45:52 +0000
qlnx: qlnxe: Fix kernel address leakage
In function qlnx_rdma_deregister_if,
the address of object rdma_if will be printed out.
rdma_if is the address of a global variable qlnxr_drv,
which is passed from dev/qlnx/qlnxr/qlnxr_os.c
A kernel address leakage happens.
Fix this by removing the printf statement.
PR: 238646
MFC after: 1 week
---
sys/dev/qlnx/qlnxe/qlnx_rdma.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/sys/dev/qlnx/qlnxe/qlnx_rdma.c b/sys/dev/qlnx/qlnxe/qlnx_rdma.c
index 77b25a017ade..a69f0efd095a 100644
--- a/sys/dev/qlnx/qlnxe/qlnx_rdma.c
+++ b/sys/dev/qlnx/qlnxe/qlnx_rdma.c
@@ -253,8 +253,6 @@ qlnx_rdma_deregister_if(qlnx_rdma_if_t *rdma_if)
int ret = 0;
qlnx_host_t *ha;
- printf("%s: enter rdma_if = %p\n", __func__, rdma_if);
-
if (mtx_initialized(&qlnx_rdma_dev_lock)) {
mtx_lock(&qlnx_rdma_dev_lock);
@@ -285,7 +283,6 @@ qlnx_rdma_deregister_if(qlnx_rdma_if_t *rdma_if)
mtx_unlock(&qlnx_rdma_dev_lock);
}
- printf("%s: exit rdma_if = %p\n", __func__, rdma_if);
return (ret);
}