From nobody Fri May 17 16:27:14 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Vgsn0185gz5LQGv; Fri, 17 May 2024 16:27:16 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Vgsn00fz0z4TQB; Fri, 17 May 2024 16:27:16 +0000 (UTC) (envelope-from brooks@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715963236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lX0FwhoS+iLp620VS+3uFjH8463ERETW3Sw51pZRL3Y=; b=MYDBXFW1wZD+AjKueEwXOZbi7b6DtvY68pAbrejDN3x+Sjb87uQom6iX566AdHJTnplAhy BWXOTxBWLgye5BGjt2KVZmp//mUJ+lfVQPXjk70xWV58qa/swkHWxrlhe0bb0WAr7Y5eQS p5yb0rG1KcgB1g6NluAn3b4LEszq2TgL8BW4o0nCZbw6DMA0DkGyks4bFe0aRIiVGf6yRM YlxSnR5ld6Uf5w+eYSA6Ja8JPTrqjSSfBLFdiI1FyEBjEDICrDOB4v82a5gdlCRbKN2QP+ 90bNuQZg1rZz3y+B0tvePSbhcpfMzrPQ2B0ijqabMcTtYsJT5YIUt39s9n+tqw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715963236; a=rsa-sha256; cv=none; b=dTgi0D+2M+5E7Ur0UbNOkjv38ruIyNwr1HcS+vB4Cy08RR5S3QM9MG/g4i6BRCMbkY/lF6 WXY7Hs5hsmdnppVJw3kK3MVF3B46/P3+etKHnp5M6sj7Pz5q6RGliJdoN1xinWNFl/Ivk+ EWA0nom45di5YMthYOFindg8dqOg851PewuiMjeouA4B3XxYmLSrEBodi5ORNZRCMt6VPQ Ijo7lufv1qbknKOIt4Ev0UIDC3X8YFR8aoSaTvAmyJDygGbKfXnEuPmgEBgm7eBtTZrvM3 SNMDchKdVl3hPYXTjxS7BuJU1ZFttYdRI4+lW+ikm7GzoV5rYpwjcCUFU/Tm4A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715963236; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=lX0FwhoS+iLp620VS+3uFjH8463ERETW3Sw51pZRL3Y=; b=mUPChGFDbu4zqSfSVY1+vRrGUyXgzSZ1GYPhQSoVeHnIBuGl1ltmQTq/meJcVDr7AqVdFk fHMX742Gh09LVDpYCITo+Rf8S7Inl2WyOmcHh9473UC/hVAKcOIq7nuEdoqBGHrGJCKdsh FjXUFuRRu5xaJmBNvBfJsgrTAlNzM5ZHIF8wx4rQxGT2mifyrl8kDJ+XFrQxRs0KzkY5Pc 9AMaKvT4wxJzadEWMdJkK+RGzqlGi89x37yZADTGhuh3SUYSAV1qyVbFkZGeIoM1aD9/2Q V1omewfZ8Xg68gDpI36UbxcLbLDzUSrOeLqiQ/VGK2tBh0bSry+hr9aKhXngCw== Received: from spindle.one-eyed-alien.net (spindle.one-eyed-alien.net [199.48.129.229]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: brooks/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 4Vgsmz6yP5zGyD; Fri, 17 May 2024 16:27:15 +0000 (UTC) (envelope-from brooks@freebsd.org) Received: by spindle.one-eyed-alien.net (Postfix, from userid 3001) id 913D33C019B; Fri, 17 May 2024 16:27:14 +0000 (UTC) Date: Fri, 17 May 2024 16:27:14 +0000 From: Brooks Davis To: John Baldwin Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4c0dfd5959bd - main - arm: fail early on gcc builds Message-ID: References: <202405171601.44HG1Sef047261@gitrepo.freebsd.org> <456e4eef-e194-4e32-b3a7-c93bb941b82b@FreeBSD.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <456e4eef-e194-4e32-b3a7-c93bb941b82b@FreeBSD.org> On Fri, May 17, 2024 at 09:14:46AM -0700, John Baldwin wrote: > On 5/17/24 9:01 AM, Brooks Davis wrote: > > The branch main has been updated by brooks: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=4c0dfd5959bd499754e3fc9a7ce37c1d5ece31f7 > > > > commit 4c0dfd5959bd499754e3fc9a7ce37c1d5ece31f7 > > Author: Brooks Davis > > AuthorDate: 2024-05-17 15:47:22 +0000 > > Commit: Brooks Davis > > CommitDate: 2024-05-17 16:01:19 +0000 > > > > arm: fail early on gcc builds > > Since at least 2022 (see https://reviews.freebsd.org/D36754), it has > > not been possible to build armv6/armv7 with gcc due to atomics macros > > gcc doesn't like. Prevent developers doing due diligance from wasting > > time and CPU cycles on this combination as it just fails to build in > > libc. > > Reviewed by: imp, andrew > > Differential Revision: https://reviews.freebsd.org/D45193 > > As I said in the review, this is a weird change. Only amd64 and i386 build > with GCC. You should blacklist all the others if you are going to blacklist > any, not just 32-bit arm. I hadn't blacklisted any to make it possible for > other developers to work on it. Also, the review in question is probably not > the right fix, it's probably that we need to pass different CFLAGS to GCC for > 32-bit arm. I think I misunderstood your point in the review. I've wasted days trying to do the right thing to let me reapply 4510f2ca9170 (Make WITHOUT_UNDEFINED_VERSION the default) only to find that it's secret knowledge that gcc builds are broken except on x86. IMO there's less than zero value in universe targets that don't work unless they are clearly fenced. I propose disabling all the others and adding a flag to ignore this guard. -- Brooks P.S. I've got aarch64 building except for GOOGLETEST and BOOT which both fail to link due to relocation complaints.