From nobody Thu May 09 15:23:41 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VZwlL0qypz5JvqT; Thu, 09 May 2024 15:23:42 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VZwlK5j1lz4DGW; Thu, 9 May 2024 15:23:41 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715268221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BPOSrlO3i9fskdBRt8eE/bYVnxuTtg5eci608F3IIXc=; b=j66r5bWTfSo6PlXeEwtbcriR0OJ5u4hzCz4H8ZOPxweh2Av2o1y2pswB24+D/XuJRg2HyD eua0c9mvZBlH0qJjy6zx0fsVuJ0s+jiBDdlcUKkqWZM6Y0hDnOUbF/s3sAQ/uXbYXB5SxA jFMTFC3BKN/VsOxt/oIunbHjVqSUrIpEQ3ALfcWfA0kO2hFWtgRfL7vNDhk0h0WHDrlfjQ /dlejImZ9zOug+ZUy1uXMYkQoLuugLq5ZzwkIxxra+cpTA+5Fv1ZwZv5wjJESDujgHFmay J+98Td8bRKdFzzscAd5XaGbgZmWfBQgs1+A71fmoifcaRdcUoujAe9eb0ST3XQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1715268221; a=rsa-sha256; cv=none; b=WljfCloDSCwkiiGYqrvo9eyfpqgvW5bZOO6Lt8lgchW/C6e/GgL3D/p5ZiWxKWO+iRS+UW wVBJyIISeAmkAISRx9yEtF3Hjws7ZJnUd/Ugs5vurrmIHMiA99Wm3arqE5kZ8sYlIRJYAF gRvPz6o8kTEsyXgmQcdYZa981sAozDYrEV17ENzS5jVzMdlp4exlcInSJpzHDouqGXCCzS s3oGeua8YBT4u7FAYDncvE/T23arwIiM419oMAwZcqJ5MoLzfKSoSCLhqaO9mTdOBchtuC 41NHTgFZVRgKjUGZqXOKVRqJ3UorN4mDlVlJKM+BwqalAi26jwEFhxnXuG2TuQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1715268221; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=BPOSrlO3i9fskdBRt8eE/bYVnxuTtg5eci608F3IIXc=; b=GSCYIzZpvK5vkdNp3Mbs568hySUp9vXI+TcdDo0rVYSXg9pPntjvQOpu8pnSdoK4eGT23s ip2dzQIupczRE1J91zf7XvIBpW+GKYn24wSqkEzU4FXrL8Jn2mSIFVSsjnYpSxIOLcjSem G0xnDfACvIBwKUgoW53xkQsouJzhcYnxb1wB7ZxXxSffO8GP/1nZiGRPHrb9QDs+vq4Hb0 X8wTSUVPpQ/nN2w7J7LD3KJN4dDERnpHsXWiJ6BXxOCB/+EwzV0E2J7iTMQTgpWSIKf4M+ uk2AqIXH3oVj2H9qBW1e+o8cwbGpaOFej2kQF6r8K1SyWEFUpi1MlaACtLzrLg== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4VZwlK5JP6z1DYk; Thu, 9 May 2024 15:23:41 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.17.1/8.17.1) with ESMTP id 449FNfIe052287; Thu, 9 May 2024 15:23:41 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.17.1/8.17.1/Submit) id 449FNfIx052284; Thu, 9 May 2024 15:23:41 GMT (envelope-from git) Date: Thu, 9 May 2024 15:23:41 GMT Message-Id: <202405091523.449FNfIx052284@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Michael Tuexen Subject: git: 83dcc7790b11 - main - sctp: don't provide uninitialized memory to process_chunk_drop() List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: tuexen X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 83dcc7790b11e605c32ec9a091c6bba3bc921083 Auto-Submitted: auto-generated The branch main has been updated by tuexen: URL: https://cgit.FreeBSD.org/src/commit/?id=83dcc7790b11e605c32ec9a091c6bba3bc921083 commit 83dcc7790b11e605c32ec9a091c6bba3bc921083 Author: Michael Tuexen AuthorDate: 2024-05-08 22:17:13 +0000 Commit: Michael Tuexen CommitDate: 2024-05-08 22:17:13 +0000 sctp: don't provide uninitialized memory to process_chunk_drop() Right now, the code in process_chunk_drop() does not look the the corresponding fields. Therefore, no functional change intended. Reported by: Coverity Scan CID: 1472476 MFC after: 3 days --- sys/netinet/sctp_input.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/sys/netinet/sctp_input.c b/sys/netinet/sctp_input.c index a55ef5ac1eab..0a8372a07362 100644 --- a/sys/netinet/sctp_input.c +++ b/sys/netinet/sctp_input.c @@ -4231,6 +4231,8 @@ sctp_handle_packet_dropped(struct sctp_pktdrop_chunk *cp, SCTP_STAT_INCR(sctps_pdrpmbda); } } else { + desc.tsn_ifany = htonl(0); + memset(desc.data_bytes, 0, SCTP_NUM_DB_TO_VERIFY); if (pktdrp_flags & SCTP_FROM_MIDDLE_BOX) { SCTP_STAT_INCR(sctps_pdrpmbct); }