From nobody Sat May 04 21:38:39 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4VX1JY2dkdz5JfNS for ; Sat, 4 May 2024 21:38:53 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4VX1JX6Yhkz4RnJ for ; Sat, 4 May 2024 21:38:52 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-ej1-x629.google.com with SMTP id a640c23a62f3a-a59b81d087aso60489866b.3 for ; Sat, 04 May 2024 14:38:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20230601.gappssmtp.com; s=20230601; t=1714858731; x=1715463531; darn=freebsd.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=MOF+G151kXpPWzVH2RbehOHtksiV4Iox18QVS0bODAg=; b=07CJkEa9ymAzAjbiwT+ewWxRoFmRWjDgQ+s2UAQV8EByW+6CCRhbV7VYGbD6z9mr2O jF2w/znbm7zuocH1nshyESknJk+j8lZAorwn1GuSpKIQU3al8tb1ch/rIOf3wLY5TjCf lRmZpTEw8/Jv3X/7syl0NgHppeAztuW55avk38cvyk2eJl0Im3GAcfdy8qg2dxJxl3ha GgJ1dUfYZ3JlDReGox70NqJW7scpb6chwPKDCfeOfs3M5A6kY/5yQEAqKAGq8AxnzYyE tlikt2YYmSl/DEn3IHb4wZXHu/vc1qfXEYSNy39HeHVQuMAECfa9MpDGrY7UpEOd9sij HGVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714858731; x=1715463531; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MOF+G151kXpPWzVH2RbehOHtksiV4Iox18QVS0bODAg=; b=fppw5eJKMRIxayY7odSQkyxbbNiOdKn0+0qCaK74BT723BPRwjUHAwZyjgyoL7hG3E SSPCjAh2uyqzBF5B5PATZadgv7U+39YPQLlMUbDc8iq/Sh1DUATq+F17PXf74mtMTY4q ow13D8LYLKzk3yh4m+mCTjn7UegAlcNsJ9G35jF9c7XZj4oYoKGFq+KTbEAdezwpNw6J 38khAjwVe2ddQ1oDTH9mWz8dgB9JObjYrA2702CDMVvy875ltxBVbh4J6viJTUhegcen Rkhw9DSptJ0hxMNx/czvfngdco+jzuQbAgqYO0Hubd4ueQwFkJaMSn+90p/CaoEpg0R7 EHDQ== X-Forwarded-Encrypted: i=1; AJvYcCWhdBpPF5KGyfkb+mvUWgQYXeKTehFwsLZ8q5D4QwFLo9cg2W4iRiDEG238ZXyXBGxE+YMr3seCWpsCaHY/Hb1O90ILsAA5DCSAOxbUQ8OCfQ== X-Gm-Message-State: AOJu0YxizSCuzriU4/06Oz7+dPmeSI1n/GuiiC17I0WrwrIEVhOeTihq SLqbPUEQg78Nh3ZCFtbJOW3atW5V2G+hhxqPZkMW+bTmjcGju0PqQ8bn3QebvLJ9BJBr4l26uU6 iJii7shtdNpS22ucY/xu/iip1XlzLr/GDuVZdYw== X-Google-Smtp-Source: AGHT+IH8S4fepaIMdGx0Zhz7jdPPCumJb69MXBid/i/3NWk6YauNzB+yF71rPQsSqCD8I3+hrYyhP91LXLAGXNOquPs= X-Received: by 2002:a17:907:d92:b0:a59:b02a:90da with SMTP id go18-20020a1709070d9200b00a59b02a90damr1400917ejc.68.1714858731217; Sat, 04 May 2024 14:38:51 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 References: <202405041645.444Gjn2b099621@gitrepo.freebsd.org> In-Reply-To: From: Warner Losh Date: Sat, 4 May 2024 15:38:39 -0600 Message-ID: Subject: Re: git: cb808de400c7 - main - rc.conf.5: modernise network_interfaces To: Lexi Winter Cc: Kelly Hays , Warner Losh , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: multipart/alternative; boundary="00000000000083c2b40617a7a9f7" X-Spamd-Bar: ---- X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; TAGGED_RCPT(0.00)[]; ASN(0.00)[asn:15169, ipnet:2a00:1450::/32, country:US] X-Rspamd-Queue-Id: 4VX1JX6Yhkz4RnJ --00000000000083c2b40617a7a9f7 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Sat, May 4, 2024 at 1:40=E2=80=AFPM Lexi Winter wrote: > Kelly Hays: > > On Sat, May 4, 2024 at 11:45=E2=80=AFAM Warner Losh w= rote: > > > @@ -2045,9 +2062,9 @@ interfaces with: > > > .Bd -literal > > > gif_interfaces=3D"gif0 gif1" > > > gifconfig_gif0=3D"100.64.0.1 100.64.0.2" > > > -ifconfig_gif0=3D"inet 10.0.0.1 10.0.0.2 netmask 255.255.255.252" > > > +ifconfig_gif0=3D"inet 10.0.0.1/32 10.0.0.2" > > > gifconfig_gif1=3D"inet6 2a00::1 2a01::1" > > > -ifconfig_gif1=3D"inet 10.1.0.1 10.1.0.2 netmask 255.255.255.252" > > > +ifconfig_gif1=3D"inet 10.1.0.1/32 10.1.0.2" > > > > In the last example above the CIDR notation for the netmask of > > 255.255.255.252 would be /30 not /32. > > yes, this is wrong. imp: can you fix this or do you want a new PR? > I'll just commit a fix and give Kelly credit. Warner --00000000000083c2b40617a7a9f7 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Sat, May 4, 2024 at 1:40=E2=80=AFP= M Lexi Winter <lexi@le-fay.org>= ; wrote:
Kelly H= ays:
> On Sat, May 4, 2024 at 11:45=E2=80=AFAM Warner Losh <imp@freebsd.org> wrote:
> > @@ -2045,9 +2062,9 @@ interfaces with:
> >=C2=A0 .Bd -literal
> >=C2=A0 gif_interfaces=3D"gif0 gif1"
> >=C2=A0 gifconfig_gif0=3D"100.64.0.1 100.64.0.2"
> > -ifconfig_gif0=3D"inet 10.0.0.1 10.0.0.2 netmask 255.255.255= .252"
> > +ifconfig_gif0=3D"inet 10.0.0.1/32 10.0.0.2"
> >=C2=A0 gifconfig_gif1=3D"inet6 2a00::1 2a01::1"
> > -ifconfig_gif1=3D"inet 10.1.0.1 10.1.0.2 netmask 255.255.255= .252"
> > +ifconfig_gif1=3D"inet 10.1.0.1/32 10.1.0.2"
>
> In the last example above the CIDR notation for the netmask of
> 255.255.255.252 would be /30 not /32.

yes, this is wrong.=C2=A0 imp: can you fix this or do you want a new PR?

I'll just commit a fix and give Kelly= credit.

Warner=C2=A0
--00000000000083c2b40617a7a9f7--