From nobody Mon Jun 24 20:04:59 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W7Jpl4FyKz5PYrt; Mon, 24 Jun 2024 20:05:03 +0000 (UTC) (envelope-from glebius@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W7Jpl3CqTz3xKG; Mon, 24 Jun 2024 20:05:03 +0000 (UTC) (envelope-from glebius@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1719259503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=74uttWd+GtlQ8KNSBofIt8Dv99wgjZYtGZbyhNUl2u4=; b=EsB9VnlTZ8L1oxO89xHDsTfcS6I5DV+ecmSY9JLfcz1K/RdjJBurPK5Tv3aIeb1zRlixkp 51bPneP70FVsPhR9qKW2tGhiA4KatTyD5jHU7OrkRNoOxXmO5ucjnXwyWDUw3bbvg+Txlk PmoBGPCZMQ/SpTwh6MJv0tgT+KKHtcYpThOPnSDeI2VnkRTd5yG+I2mGkdh40FahZ0bK4E 0mGIVbTYtd+A0Wy+bRGhWX7HZ/cAR+bZh/700BKPKmas12UTFNMymb4yneJTY0vZsHeKfI 5TnNjb/66BY/QVwefqls8sMSBLViH0YYpJVCGFX7LyPy8LXnWRxcLX8ZXbKvNQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1719259503; a=rsa-sha256; cv=none; b=MsuZkgTShTevMJyz8V6rhZqw9GhXkUVxmZml8JRusl9TASXJwXhBmEj51vHQcwo40lGxkL C39DemcglJt+XwfK15eg3tj3Hx0jKDhVL1yafQgRKvzNQC6nDkASboiSeerA4eDP342ljB EUXsx4HJHT0leuwoytlNQrtS4hsQs/bmCBYf2S2i25/OgtA4I8kfDwZPS/WDCnw/wmYIK3 Y79GHunFAqQQb84lwZjn5JHsidPzKTYgAZUfej7XIuA68lID9Uan/2QpSbh4AKGepMiEKr 8S7s9+3EuJOXdIktlHG9ourdzoRuxQ504FeXROei/AKWrtCiOWT+XvNYZZsf8A== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1719259503; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=74uttWd+GtlQ8KNSBofIt8Dv99wgjZYtGZbyhNUl2u4=; b=OEzXX6OxkEvikT6O+4CNpfASYUiSRQ/PoBR6lzZmY3JrHwJekYUqgv/NYe46dA5oun4LH4 lmg1yq/uB3hShVNoMJq1roypq6OBrGbklsDFo+rj/uOPvk9nN6NY8J1X57wGQ3BnM3stGU lLRTOwDhks4dNZgXlMm7txwPX2FqdwBG2UKAX9ojRdt8HeWe6IteuIuSj4cb6sPxZyNj8c PeXRWDThI0MX1DmUULwIsKDolho4GB5vARHzvTjAVptHjCWwKaatfcHtBH8QcSq/M2/+3i lscGH1INVcvKRa04idP0Qb9cysH6NlETA9me1hrCVkz19WpWos6fwkDo5+8cxA== Received: from cell.glebi.us (glebi.us [162.251.186.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: glebius) by smtp.freebsd.org (Postfix) with ESMTPSA id 4W7Jpj3b3rz1G4c; Mon, 24 Jun 2024 20:05:01 +0000 (UTC) (envelope-from glebius@freebsd.org) Date: Mon, 24 Jun 2024 13:04:59 -0700 From: Gleb Smirnoff To: Mark Johnston Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: ac52fa1f1b97 - main - sendfile tests: Fix an error check in tcp_socketpair() Message-ID: References: <202406211821.45LILvWH052581@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202406211821.45LILvWH052581@gitrepo.freebsd.org> Mark, On Fri, Jun 21, 2024 at 06:21:57PM +0000, Mark Johnston wrote: M> commit ac52fa1f1b9768d281b9deed6d1158f43a8564ca M> Author: Mark Johnston M> AuthorDate: 2024-06-21 18:18:22 +0000 M> Commit: Mark Johnston M> CommitDate: 2024-06-21 18:18:22 +0000 M> M> sendfile tests: Fix an error check in tcp_socketpair() M> M> Fixes: c368d3f20fc0 ("tests/sendfile: factor out tcp_socketpair()") M> Differential Revision: https://reviews.freebsd.org/D45598 M> --- M> tests/sys/kern/sendfile_helper.c | 2 +- M> 1 file changed, 1 insertion(+), 1 deletion(-) M> M> diff --git a/tests/sys/kern/sendfile_helper.c b/tests/sys/kern/sendfile_helper.c M> index 703b04fdea6c..6365531e312c 100644 M> --- a/tests/sys/kern/sendfile_helper.c M> +++ b/tests/sys/kern/sendfile_helper.c M> @@ -84,7 +84,7 @@ tcp_socketpair(int *sv) M> if (fcntl(sv[0], F_SETFL, flags) == -1) M> err(1, "fcntl +O_NONBLOCK"); M> M> - if (connect(sv[0], (void *)&sin, sizeof(sin)) != -1 || M> + if (connect(sv[0], (void *)&sin, sizeof(sin)) == -1 && M> errno != EINPROGRESS) M> err(1, "connect cs"); Sorry for not reviewing in a timely manner. Did you actually observe connect(2) on a non-blocking TCP socket to immediately return success? -- Gleb Smirnoff