From nobody Wed Jun 19 12:23:09 2024 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4W42p82Prnz5N3P5; Wed, 19 Jun 2024 12:23:12 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [96.47.72.83]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4W42p81cntz4XqH; Wed, 19 Jun 2024 12:23:12 +0000 (UTC) (envelope-from bapt@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1718799792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I1jKbj+CnDEHUG98bli1L2eVkZWjNbq+kYX/E9fqYiA=; b=vgXlhOB/lw99OZACDlXeX1ARfDZLRWYwgKvYARdub/bf8MeSE5ZCSERFt0T3H+5/V8oB7q xY50mXntT5vOuLfsQKSjtspd5unpFT8AMkjZUb5nbgcxR4NuSRNRTghM7cNNh2tIhn6sdC IAoTsHhP1XJFHugD/UMnc2k2vJeEyI6xad9z/Cy+oyTYN6aCqDUIqy5CSLFK5DKcAqmOg0 rPcdsDanAH7sSpXbYjihTUHOIU8GZw4e45E/ycm8SY6iK40ASZ70mJUEFnv8/HLG/MJ3A9 BnKIRUmp1HFVSG5DyA5jwPVJCldIa+F2hH0euJbiC/KXriTX0lXFis78/GsXeQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1718799792; a=rsa-sha256; cv=none; b=gV1lvJR52BkpiyF7U6svXsBWoTuSC8KXZobGrJrHFX996aRxH8c2aV++2GEaI6IEBvcTxb +ty+XVPpr6X6rbtzMhjuVCIxfcgfJH26jLqVOsUBl+ADCxrmU8q142fSOa8hMT+uE1Mb/1 KcdRtSSKFieCL2rQ6Evof7HWvvva0TUQeZIHLeXheWN8yn5xged/rPPYJFNi9MebC7hP0k rnpadH2sSo5I0EqezcMiJGREc9TY7Ovc1Fv2SwmCmybVT/+V2S/6+ylVhWQotdAbSUARoD slW8wH8hJFQOip749v2+WZYKSgYb0TL1ABzn4qhSu5Irz8zdWMrRzu458M5scQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1718799792; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=I1jKbj+CnDEHUG98bli1L2eVkZWjNbq+kYX/E9fqYiA=; b=HUpV4wPeJ0ZrhZZ/XZlwT+U998o1zCMNUhJf6B0oVPClzDnWvQUkfxfOvLEgiyrxjGVtjT wzAYzQhAtmgLIK8hTQdpAMHEmcGHk2GtWCnDj3o7rCVNg46yS4fcR917M9vh6cXjsUQs9b WD/zqn9tFBF7nT7WHWco52iIkQK4H7iOk/OoP4Q/e0iu2873VGoom7q6rM6U5T1KIGgu52 AkQ3CSFsjkDSCFOAwDuU2yv5zzkpT6xnOcqtoSDjYYlw+5fAmNi+9eoAhyjNPVn6W+C7s6 0PNQ+GzEVfyiqL15k4/LojEIh5oD+EYAfOCUZ++Aj8GMCah6KLvEycMchYrztg== Received: from aniel.nours.eu (nours.eu [IPv6:2001:41d0:8:3a4d::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: bapt) by smtp.freebsd.org (Postfix) with ESMTPSA id 4W42p80XZTzNnk; Wed, 19 Jun 2024 12:23:12 +0000 (UTC) (envelope-from bapt@freebsd.org) Received: by aniel.nours.eu (Postfix, from userid 1001) id 0273695246; Wed, 19 Jun 2024 14:23:09 +0200 (CEST) Date: Wed, 19 Jun 2024 14:23:09 +0200 From: Baptiste Daroussin To: Doug Rabson Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: e97ad33a89a7 - main - Add an implementation of the 9P filesystem Message-ID: References: <202406191213.45JCDPPP051964@gitrepo.freebsd.org> List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <202406191213.45JCDPPP051964@gitrepo.freebsd.org> On Wed 19 Jun 12:13, Doug Rabson wrote: > The branch main has been updated by dfr: > > URL: https://cgit.FreeBSD.org/src/commit/?id=e97ad33a89a78f55280b0485b3249ee9b907a718 > > commit e97ad33a89a78f55280b0485b3249ee9b907a718 > Author: Doug Rabson > AuthorDate: 2022-12-06 13:07:46 +0000 > Commit: Doug Rabson > CommitDate: 2024-06-19 12:12:04 +0000 > > Add an implementation of the 9P filesystem > > This is derived from swills@ fork of the Juniper virtfs with many > changes by me including bug fixes, style improvements, clearer layering > and more consistent logging. The filesystem is renamed to p9fs to better > reflect its function and to prevent possible future confusion with > virtio-fs. > > Several updates and fixes from Juniper have been integrated into this > version by Val Packett and these contributions along with the original > Juniper authors are credited below. > > To use this with bhyve, add 'virtio_p9fs_load=YES' to loader.conf. The > bhyve virtio-9p device allows access from the guest to files on the host > by mapping a 'sharename' to a host path. It is possible to use p9fs as a > root filesystem by adding this to /boot/loader.conf: > > vfs.root.mountfrom="p9fs:sharename" > > for non-root filesystems add something like this to /etc/fstab: > > sharename /mnt p9fs rw 0 0 > > In both examples, substitute the share name used on the bhyve command > line. > > The 9P filesystem protocol relies on stateful file opens which map > protocol-level FIDs to host file descriptors. The FreeBSD vnode > interface doesn't really support this and we use heuristics to guess the > right FID to use for file operations. This can be confused by privilege > lowering and does not guarantee that the FID created for a given file > open is always used for file operations, even if the calling process is > using the file descriptor from the original open call. Improving this > would involve changes to the vnode interface which is out-of-scope for > this import. > First of all: thanks a lot! you say the changes in the vnode interface are out of scope for this import, which makes perfectly sense, but it is part of your TODO for later? Best regards, Bapt