git: 5d0498db4782 - main - nvmf_tcp: Rename max_c2hdata sysctl to max_transmit_data
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 25 Jul 2024 19:33:27 UTC
The branch main has been updated by jhb:
URL: https://cgit.FreeBSD.org/src/commit/?id=5d0498db478253c42b5e4140b9aff8596a797464
commit 5d0498db478253c42b5e4140b9aff8596a797464
Author: John Baldwin <jhb@FreeBSD.org>
AuthorDate: 2024-07-25 19:29:43 +0000
Commit: John Baldwin <jhb@FreeBSD.org>
CommitDate: 2024-07-25 19:29:43 +0000
nvmf_tcp: Rename max_c2hdata sysctl to max_transmit_data
This sysctl sets a cap on the maximum payload of transmitted data PDUs
including both C2H_DATA and H2C_DATA PDUs, not just C2H_DATA PDUs.
Sponsored by: Chelsio Communications
---
share/man/man4/nvmf_tcp.4 | 15 +++++++++++----
sys/dev/nvmf/nvmf_tcp.c | 2 +-
2 files changed, 12 insertions(+), 5 deletions(-)
diff --git a/share/man/man4/nvmf_tcp.4 b/share/man/man4/nvmf_tcp.4
index 4d77997c19a2..0a650e342f0e 100644
--- a/share/man/man4/nvmf_tcp.4
+++ b/share/man/man4/nvmf_tcp.4
@@ -3,7 +3,7 @@
.\"
.\" Copyright (c) 2024 Chelsio Communications, Inc.
.\"
-.Dd May 2, 2024
+.Dd July 25, 2024
.Dt NVMF_TCP 4
.Os
.Sh NAME
@@ -35,10 +35,17 @@ variables and
.Xr loader 8
tunables:
.Bl -tag -width indent
-.It Va kern.nvmf.tcp.max_c2hdata
-The maximum data payload size of a
+.It Va kern.nvmf.tcp.max_transmit_data
+The maximum data payload size of
.Va C2H_DATA
-PDU sent by the controller to a remote host.
+and
+.Va H2C_DATA
+PDUs.
+A remote controller may enforce a lower limit on the size of
+.Va H2C_DATA
+PDUs via the
+.Va MAXH2CDATA
+parameter.
The default size is 256 kilobytes.
.El
.Sh SEE ALSO
diff --git a/sys/dev/nvmf/nvmf_tcp.c b/sys/dev/nvmf/nvmf_tcp.c
index 57c81eceee02..8f1b3bf01e39 100644
--- a/sys/dev/nvmf/nvmf_tcp.c
+++ b/sys/dev/nvmf/nvmf_tcp.c
@@ -138,7 +138,7 @@ static void tcp_free_qpair(struct nvmf_qpair *nq);
SYSCTL_NODE(_kern_nvmf, OID_AUTO, tcp, CTLFLAG_RD | CTLFLAG_MPSAFE, 0,
"TCP transport");
static u_int tcp_max_transmit_data = 256 * 1024;
-SYSCTL_UINT(_kern_nvmf_tcp, OID_AUTO, max_c2hdata, CTLFLAG_RWTUN,
+SYSCTL_UINT(_kern_nvmf_tcp, OID_AUTO, max_transmit_data, CTLFLAG_RWTUN,
&tcp_max_transmit_data, 0,
"Maximum size of data payload in a transmitted PDU");