Re: git: ed3563b0ac31 - main - csu: add crtbrand.o dependency on sys/param.h

On Wed, Jan 31, 2024, 1:41 PM Ed Maste <emaste@freebsd.org> wrote:

> The branch main has been updated by emaste:
>
> URL:
> https://cgit.FreeBSD.org/src/commit/?id=ed3563b0ac31d854bf907d4d847ac0195ec9637b
>
> commit ed3563b0ac31d854bf907d4d847ac0195ec9637b
> Author:     Ed Maste <emaste@FreeBSD.org>
> AuthorDate: 2024-01-12 15:01:49 +0000
> Commit:     Ed Maste <emaste@FreeBSD.org>
> CommitDate: 2024-01-31 20:40:27 +0000
>
>     csu: add crtbrand.o dependency on sys/param.h
>
>     __FreeBSD_version is recorded in *crt1.o and crti.o via crtbrand.o.
> Add
>     an explicit dependency to pick up __FreeBSD_version bumps.
>
>     Additional changes are required to fully plumb *crt1.o dependencies
>     through the build.
>

So a kernel bump now rebuilds (or at least relinks) everything? Or soon
will?

    Reported by:    bapt
>     Reviewed by:    bapt
>     Sponsored by:   The FreeBSD Foundation
>     Differential Revision: https://reviews.freebsd.org/D43417
> ---
>  lib/csu/Makefile.inc | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/lib/csu/Makefile.inc b/lib/csu/Makefile.inc
> index 55aaf589f48f..1509a1ece2c3 100644
> --- a/lib/csu/Makefile.inc
> +++ b/lib/csu/Makefile.inc
> @@ -55,6 +55,9 @@ Scrt1_c.o: ${CRT1SRC}
>  Scrt1.o: Scrt1_c.o ${CRT1OBJS} ${CRT1OBJ}
>         ${LD} ${_LDFLAGS} -o ${.TARGET} -r ${.ALLSRC:M*.o}
>
> +# __FreeBSD_version is recorded in crt1.o et al via crtbrand.
> +crtbrand.o: ${SRCTOP}/sys/sys/param.h
> +
>  crtbegin.o: crtbegin.c
>  crtbeginS.o: crtbegin.c
>  crtbeginT.o: crtbegin.c
>