Re: git: df834e06bbc7 - main - git-arc: Just strip escape sequences form arc log

Hey John,

On Mon, Jan 15, 2024 at 9:37 AM Warner Losh <imp@bsdimp.com> wrote:

>
>
> On Mon, Jan 15, 2024 at 9:30 AM John Baldwin <jhb@freebsd.org> wrote:
>
>> On 1/14/24 6:24 PM, Warner Losh wrote:
>> > The branch main has been updated by imp:
>> >
>> > URL:
>> https://cgit.FreeBSD.org/src/commit/?id=df834e06bbc78c03cb6b35f074ae43673c9ce463
>> >
>> > commit df834e06bbc78c03cb6b35f074ae43673c9ce463
>> > Author:     Warner Losh <imp@FreeBSD.org>
>> > AuthorDate: 2024-01-15 02:22:04 +0000
>> > Commit:     Warner Losh <imp@FreeBSD.org>
>> > CommitDate: 2024-01-15 02:23:45 +0000
>> >
>> >      git-arc: Just strip escape sequences form arc log
>> >
>> >      Just strip escape sequences and Warning: lines from 'arc list'
>> output. I
>> >      upgraded and they changed and git arc list broke. This restores its
>> >      functionality.
>> >
>> >      Note: jhb didn't like this, so if others object, I'll fix...
>> >
>> >      Sponsored by:           Netflix
>> >      Reviewed by:            markj
>> >      Differential Revision:  https://reviews.freebsd.org/D36553
>>
>> Namely, it breaks the color output for reviews in different states, so
>> Needs Review
>> shows up as purple, Approved as green, etc.  If you find the color output
>> useful
>> you'll have to revert this locally.
>>
>> Also, your last update in the review said that git arc was no longer
>> broken for you
>> back in May implying this commit wasn't needed for git arc to work for
>> you?
>>
>
> Yes and no. I was mistaken. This change is still needed, but its scope can
> be reduced.
> The trouble is that it's at the first for the other things I committed and
> getting it out of the
> way was a pain (I tried). Since I didn't want to delay things any further,
> I went ahead and
> committed and thought I'd fix stuff if there were objections.I'll do that
> now.
>

So even w/o my change, I don't see the color output for the review states
(so I can remove the
general filter I added for color). That's easy enough. but what are you
doing to get color in the
current setup? Or is your arcanist install old and un-updated?

That is, even w/o git-arc.sh, I see color for 'arc list' but not for 'arc
list | more'. I'd kinda like to test
things with and without the change, though.

I'll prep a commit that just drops the ANSI-color filter, but if arc list
no longer does that for pipes
it won't change anything (I think that was the change that I was talking
about back in May).

Warner