Re: git: bd61c1e89dc4 - main - libthr: thr_attr.c: Clarity, whitespace and style
Date: Fri, 05 Jan 2024 14:22:04 UTC
Hi, > Also we usually discourage plain style changes or tweaks unless they are > preparations for more substantial change. Yes, I'm aware of that. It's a fixture of most projects, and generally a good one IMHO. Besides D43006, there will be several other changes to 'thr_attr.c' (and to 'libthr' more generally). > Can you show the place where it happens? Because the canonical style is > reverse, non-bool values must be explicitly tested instead of relying on > the implicit conversion to bool. I was referring to D40626 and D40642, but it may be considered a different situation because, there, an integer, whatever its actual numerical value, is used as a boolean flag as a whole and there is no '&' to extract a particular bit. Please have a look at the small series starting at D43327 (up to D43330) for the modifications you suggested and a few additional ones of mine. Thanks and regards. -- Olivier Certner