git: 38983d40c18e - main - tcp: prevent div by zero in cc_htcp
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sat, 24 Feb 2024 16:15:37 UTC
The branch main has been updated by rscheff:
URL: https://cgit.FreeBSD.org/src/commit/?id=38983d40c18ec5705dcba19ac320b86c5efe8e7e
commit 38983d40c18ec5705dcba19ac320b86c5efe8e7e
Author: Richard Scheffenegger <rscheff@FreeBSD.org>
AuthorDate: 2024-02-24 15:35:23 +0000
Commit: Richard Scheffenegger <rscheff@FreeBSD.org>
CommitDate: 2024-02-24 15:35:59 +0000
tcp: prevent div by zero in cc_htcp
Make sure the divident is at least one. While cwnd should
never be smaller than t_maxseg, this can happen during
Path MTU Discovery, or when TCP options are considered
in other parts of the stack.
PR: 276674
MFC after: 3 days
Reviewed By: tuexen, #transport
Sponsored by: NetApp, Inc.
Differential Revision: https://reviews.freebsd.org/D43797
---
sys/netinet/cc/cc_htcp.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sys/netinet/cc/cc_htcp.c b/sys/netinet/cc/cc_htcp.c
index 949715a69c67..43224446fd84 100644
--- a/sys/netinet/cc/cc_htcp.c
+++ b/sys/netinet/cc/cc_htcp.c
@@ -229,9 +229,9 @@ htcp_ack_received(struct cc_var *ccv, uint16_t type)
* per RTT.
*/
CCV(ccv, snd_cwnd) += (((htcp_data->alpha <<
- HTCP_SHIFT) / (CCV(ccv, snd_cwnd) /
- CCV(ccv, t_maxseg))) * CCV(ccv, t_maxseg))
- >> HTCP_SHIFT;
+ HTCP_SHIFT) / (max(1,
+ CCV(ccv, snd_cwnd) / CCV(ccv, t_maxseg)))) *
+ CCV(ccv, t_maxseg)) >> HTCP_SHIFT;
}
}
}