git: d1e843b3f976 - main - arm: Use constants from sys/intr.h, not genassym
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Fri, 06 Dec 2024 17:54:52 UTC
The branch main has been updated by imp:
URL: https://cgit.FreeBSD.org/src/commit/?id=d1e843b3f976528fbea04e702a20219d532220d3
commit d1e843b3f976528fbea04e702a20219d532220d3
Author: Warner Losh <imp@FreeBSD.org>
AuthorDate: 2024-12-06 17:30:13 +0000
Commit: Warner Losh <imp@FreeBSD.org>
CommitDate: 2024-12-06 17:31:36 +0000
arm: Use constants from sys/intr.h, not genassym
We can now include sys/intr.h to get these constants rather than using
genassym. Opt for this simpler method.
PR: 283041
Sponsored by: Netflix
Reviewed by: mmel, andrew
Differential Revision: https://reviews.freebsd.org/D47847
---
sys/arm/arm/exception.S | 1 +
sys/arm/arm/genassym.c | 4 ----
sys/arm64/arm64/exception.S | 1 +
sys/arm64/arm64/genassym.c | 5 -----
sys/riscv/riscv/genassym.c | 2 --
5 files changed, 2 insertions(+), 11 deletions(-)
diff --git a/sys/arm/arm/exception.S b/sys/arm/arm/exception.S
index 3df91d6e3c1e..2c25628f77cc 100644
--- a/sys/arm/arm/exception.S
+++ b/sys/arm/arm/exception.S
@@ -52,6 +52,7 @@
#include <machine/armreg.h>
#include <machine/asmacros.h>
#include <machine/trap.h>
+#include <sys/intr.h>
#ifdef KDTRACE_HOOKS
.bss
diff --git a/sys/arm/arm/genassym.c b/sys/arm/arm/genassym.c
index 9d6232739022..24c470bdde86 100644
--- a/sys/arm/arm/genassym.c
+++ b/sys/arm/arm/genassym.c
@@ -28,11 +28,9 @@
*/
#include <sys/param.h>
-#include <sys/bus.h>
#include <sys/cpuset.h>
#include <sys/systm.h>
#include <sys/assym.h>
-#include <sys/intr.h>
#include <sys/pcpu.h>
#include <sys/proc.h>
#include <sys/mbuf.h>
@@ -131,8 +129,6 @@ ASSYM(DCACHE_LINE_MASK, offsetof(struct cpuinfo, dcache_line_mask));
ASSYM(ICACHE_LINE_SIZE, offsetof(struct cpuinfo, icache_line_size));
ASSYM(ICACHE_LINE_MASK, offsetof(struct cpuinfo, icache_line_mask));
-ASSYM(INTR_ROOT_IRQ, INTR_ROOT_IRQ);
-
/*
* Emit the LOCORE_MAP_MB option as a #define only if the option was set.
*/
diff --git a/sys/arm64/arm64/exception.S b/sys/arm64/arm64/exception.S
index d8c024d01921..13095def8b00 100644
--- a/sys/arm64/arm64/exception.S
+++ b/sys/arm64/arm64/exception.S
@@ -31,6 +31,7 @@
#include <machine/armreg.h>
#include "assym.inc"
+#include <sys/intr.h>
.text
diff --git a/sys/arm64/arm64/genassym.c b/sys/arm64/arm64/genassym.c
index 3ca712ca3de3..e3977798b046 100644
--- a/sys/arm64/arm64/genassym.c
+++ b/sys/arm64/arm64/genassym.c
@@ -28,8 +28,6 @@
#include <sys/param.h>
#include <sys/assym.h>
-#include <sys/bus.h>
-#include <sys/intr.h>
#include <sys/pcpu.h>
#include <sys/proc.h>
@@ -85,6 +83,3 @@ ASSYM(TF_ELR, offsetof(struct trapframe, tf_elr));
ASSYM(TF_SPSR, offsetof(struct trapframe, tf_spsr));
ASSYM(TF_ESR, offsetof(struct trapframe, tf_esr));
ASSYM(TF_X, offsetof(struct trapframe, tf_x));
-
-ASSYM(INTR_ROOT_IRQ, INTR_ROOT_IRQ);
-ASSYM(INTR_ROOT_FIQ, INTR_ROOT_FIQ);
diff --git a/sys/riscv/riscv/genassym.c b/sys/riscv/riscv/genassym.c
index 74b70858edab..77966913fd1b 100644
--- a/sys/riscv/riscv/genassym.c
+++ b/sys/riscv/riscv/genassym.c
@@ -38,7 +38,6 @@
#include <sys/proc.h>
#include <sys/mbuf.h>
#include <sys/vmmeter.h>
-#include <sys/bus.h>
#include <vm/vm.h>
#include <vm/vm_param.h>
#include <vm/pmap.h>
@@ -51,7 +50,6 @@
#include <machine/proc.h>
#include <machine/cpufunc.h>
#include <machine/pte.h>
-#include <machine/intr.h>
#include <machine/machdep.h>
#include <machine/vmparam.h>