git: 21aba396551e - main - cxgbe(4): Minor tweaks to comments.
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 30 Apr 2024 20:04:52 UTC
The branch main has been updated by np:
URL: https://cgit.FreeBSD.org/src/commit/?id=21aba396551e29808fa56a6d4fab17e871c3524f
commit 21aba396551e29808fa56a6d4fab17e871c3524f
Author: Navdeep Parhar <np@FreeBSD.org>
AuthorDate: 2024-04-30 20:01:07 +0000
Commit: Navdeep Parhar <np@FreeBSD.org>
CommitDate: 2024-04-30 20:02:45 +0000
cxgbe(4): Minor tweaks to comments.
No functional change intended.
MFC after: 1 week
Sponsored by: Chelsio Communications
---
sys/dev/cxgbe/t4_main.c | 12 +++++++-----
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/sys/dev/cxgbe/t4_main.c b/sys/dev/cxgbe/t4_main.c
index 1b1adc2f8614..a9611f239132 100644
--- a/sys/dev/cxgbe/t4_main.c
+++ b/sys/dev/cxgbe/t4_main.c
@@ -5317,9 +5317,13 @@ get_params__post_init(struct adapter *sc)
}
/*
- * MPSBGMAP is queried separately because only recent firmwares support
- * it as a parameter and we don't want the compound query above to fail
- * on older firmwares.
+ * The parameters that follow may not be available on all firmwares. We
+ * query them individually rather than in a compound query because old
+ * firmwares fail the entire query if an unknown parameter is queried.
+ */
+
+ /*
+ * MPS buffer group configuration.
*/
param[0] = FW_PARAM_DEV(MPSBGMAP);
val[0] = 0;
@@ -5331,7 +5335,6 @@ get_params__post_init(struct adapter *sc)
/*
* Determine whether the firmware supports the filter2 work request.
- * This is queried separately for the same reason as MPSBGMAP above.
*/
param[0] = FW_PARAM_DEV(FILTER2_WR);
val[0] = 0;
@@ -5343,7 +5346,6 @@ get_params__post_init(struct adapter *sc)
/*
* Find out whether we're allowed to use the ULPTX MEMWRITE DSGL.
- * This is queried separately for the same reason as other params above.
*/
param[0] = FW_PARAM_DEV(ULPTX_MEMWRITE_DSGL);
val[0] = 0;