RE: git: 7a0e9e3f8f3a - main - zfs: update share/zfs/compatibility.d to match current ZFS code

Martin Matuska <mm_at_FreeBSD.org> wrote on
Date: Thu, 21 Sep 2023 23:38:28 UTC :

> The branch main has been updated by mm:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=7a0e9e3f8f3a9379df793284f719f1a7ee5734c2
> 
> commit 7a0e9e3f8f3a9379df793284f719f1a7ee5734c2
> Author:     Martin Matuska <mm@FreeBSD.org>
> AuthorDate: 2023-09-21 23:34:47 +0000
> Commit:     Martin Matuska <mm@FreeBSD.org>
> CommitDate: 2023-09-21 23:37:38 +0000
> 
>     zfs: update share/zfs/compatibility.d to match current ZFS code
>     
>     MFC after:      3 days
> ---
>  cddl/share/zfs/compatibility.d/Makefile | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/cddl/share/zfs/compatibility.d/Makefile b/cddl/share/zfs/compatibility.d/Makefile
> index e60bd172dcce..13d88fef184d 100644
> --- a/cddl/share/zfs/compatibility.d/Makefile
> +++ b/cddl/share/zfs/compatibility.d/Makefile
> @@ -22,6 +22,7 @@ FILES= \
>  	openzfs-2.0-linux \
>  	openzfs-2.1-freebsd \
>  	openzfs-2.1-linux \
> +	openzfs-2.2 \
>  	zol-0.6.1 \
>  	zol-0.6.4 \
>  	zol-0.6.5 \
> @@ -42,12 +43,17 @@ LINKS= \
>  	${FILESDIR}/freebsd-11.3	${FILESDIR}/freebsd-12.0 \
>  	${FILESDIR}/freebsd-11.3	${FILESDIR}/freebsd-12.1 \
>  	${FILESDIR}/freebsd-11.3	${FILESDIR}/freebsd-12.2 \
> +	${FILESDIR}/freebsd-11.3	${FILESDIR}/freebsd-12.3 \
> +	${FILESDIR}/freebsd-11.3	${FILESDIR}/freebsd-12.4 \
>  	${FILESDIR}/freebsd-11.3	${FILESDIR}/freenas-11.3 \
>  	${FILESDIR}/freenas-11.0	${FILESDIR}/freenas-11.1 \
>  	${FILESDIR}/openzfsonosx-1.9.3	${FILESDIR}/openzfsonosx-1.9.4 \
>  	${FILESDIR}/openzfs-2.0-freebsd	${FILESDIR}/truenas-12.0 \
>  	${FILESDIR}/zol-0.7		${FILESDIR}/ubuntu-18.04 \
> -	${FILESDIR}/zol-0.8		${FILESDIR}/ubuntu-20.04
> +	${FILESDIR}/zol-0.8		${FILESDIR}/ubuntu-20.04 \
> +	${FILESDIR}/openzfs-2.1-linux	${FILESDIR}/ubuntu-22.04 \
> +	${FILESDIR}/openzfs-2.2		${FILESDIR}/openzfs-2.2-linux \
> +	${FILESDIR}/openzfs-2.2		${FILESDIR}/openzfs-2.2-freebsd
>  
>  LINKMODE= ${NOBINMODE}

openzfs-2.2 lists:

redacted_datasets
redaction_bookmarks
edonr
draid

that are in the modern for_read_obj list from zhack :

com.delphix:redacted_datasets = 0
com.delphix:redaction_bookmarks = 0
org.openzfs:draid = 0
org.illumos:edonr = 0

but stand/libsa/zfs/zfsimpl.c 's features_for_read list does
not have matching entries.

I do not know if this is a problem vs. not. Without comments
about it or the handling for them for features_for_read , it
looks odd.


The features_for_read list does include 5+2 "READ-ONLY COMPATIBILE yes"
items for some reason (5 for_write_obj list items + 2 others):

"com.datto:resilver_defer",		// READ-ONLY COMPATIBLE yes
"com.delphix:obsolete_counts",		// READ-ONLY COMPATIBLE yes
"com.delphix:spacemap_histogram",	// READ-ONLY COMPATIBLE yes
"com.delphix:spacemap_v2",		// READ-ONLY COMPATIBLE yes
"com.delphix:zpool_checkpoint",		// READ-ONLY COMPATIBLE yes

and (no for_*_obj list matches in zhack output):

"com.intel:allocation_classes",		// READ-ONLY COMPATIBLE yes
"org.zfsonlinux:allocation_classes",	// READ-ONLY COMPATIBLE yes

I assume that these 7 are not harmful beyond being misleading
about what should be expected to be in the features_for_read
list.

(The comment notation is my addition for explicitness in this
note.)

===
Mark Millard
marklmi at yahoo.com