git: 8c4ee0b22c98 - main - Use xpt_path_sbuf() in few drivers
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Thu, 23 Nov 2023 16:29:33 UTC
The branch main has been updated by mav:
URL: https://cgit.FreeBSD.org/src/commit/?id=8c4ee0b22c98fc1e208dd133f617bd329cd10728
commit 8c4ee0b22c98fc1e208dd133f617bd329cd10728
Author: Alexander Motin <mav@FreeBSD.org>
AuthorDate: 2023-11-23 16:25:45 +0000
Commit: Alexander Motin <mav@FreeBSD.org>
CommitDate: 2023-11-23 16:29:19 +0000
Use xpt_path_sbuf() in few drivers
xpt_path_string() is now a wrapper around xpt_path_sbuf(). Using it
to than concatenate result to another sbuf makes no sense. Just call
xpt_path_sbuf() directly.
MFC after: 1 month
---
sys/dev/mpr/mpr_sas.c | 5 +----
sys/dev/mps/mps_sas.c | 5 +----
sys/dev/virtio/scsi/virtio_scsi.c | 4 +---
3 files changed, 3 insertions(+), 11 deletions(-)
diff --git a/sys/dev/mpr/mpr_sas.c b/sys/dev/mpr/mpr_sas.c
index 9d83162723ae..048b3cb7a53d 100644
--- a/sys/dev/mpr/mpr_sas.c
+++ b/sys/dev/mpr/mpr_sas.c
@@ -304,7 +304,6 @@ mprsas_log_command(struct mpr_command *cm, u_int level, const char *fmt, ...)
struct sbuf sb;
va_list ap;
char str[224];
- char path_str[64];
if (cm == NULL)
return;
@@ -318,9 +317,7 @@ mprsas_log_command(struct mpr_command *cm, u_int level, const char *fmt, ...)
va_start(ap, fmt);
if (cm->cm_ccb != NULL) {
- xpt_path_string(cm->cm_ccb->csio.ccb_h.path, path_str,
- sizeof(path_str));
- sbuf_cat(&sb, path_str);
+ xpt_path_sbuf(cm->cm_ccb->csio.ccb_h.path, &sb);
if (cm->cm_ccb->ccb_h.func_code == XPT_SCSI_IO) {
scsi_command_string(&cm->cm_ccb->csio, &sb);
sbuf_printf(&sb, "length %d ",
diff --git a/sys/dev/mps/mps_sas.c b/sys/dev/mps/mps_sas.c
index 6a5b2f5d90f3..3cf29aa4e893 100644
--- a/sys/dev/mps/mps_sas.c
+++ b/sys/dev/mps/mps_sas.c
@@ -295,7 +295,6 @@ mpssas_log_command(struct mps_command *cm, u_int level, const char *fmt, ...)
struct sbuf sb;
va_list ap;
char str[224];
- char path_str[64];
if (cm == NULL)
return;
@@ -309,9 +308,7 @@ mpssas_log_command(struct mps_command *cm, u_int level, const char *fmt, ...)
va_start(ap, fmt);
if (cm->cm_ccb != NULL) {
- xpt_path_string(cm->cm_ccb->csio.ccb_h.path, path_str,
- sizeof(path_str));
- sbuf_cat(&sb, path_str);
+ xpt_path_sbuf(cm->cm_ccb->csio.ccb_h.path, &sb);
if (cm->cm_ccb->ccb_h.func_code == XPT_SCSI_IO) {
scsi_command_string(&cm->cm_ccb->csio, &sb);
sbuf_printf(&sb, "length %d ",
diff --git a/sys/dev/virtio/scsi/virtio_scsi.c b/sys/dev/virtio/scsi/virtio_scsi.c
index f6278434e5f9..60ef32ef39f4 100644
--- a/sys/dev/virtio/scsi/virtio_scsi.c
+++ b/sys/dev/virtio/scsi/virtio_scsi.c
@@ -2336,7 +2336,6 @@ vtscsi_printf_req(struct vtscsi_request *req, const char *func,
struct sbuf sb;
va_list ap;
char str[192];
- char path_str[64];
if (req == NULL)
return;
@@ -2352,8 +2351,7 @@ vtscsi_printf_req(struct vtscsi_request *req, const char *func,
cam_sim_name(sc->vtscsi_sim), cam_sim_unit(sc->vtscsi_sim),
cam_sim_bus(sc->vtscsi_sim));
} else {
- xpt_path_string(ccb->ccb_h.path, path_str, sizeof(path_str));
- sbuf_cat(&sb, path_str);
+ xpt_path_sbuf(ccb->ccb_h.path, &sb);
if (ccb->ccb_h.func_code == XPT_SCSI_IO) {
scsi_command_string(&ccb->csio, &sb);
sbuf_printf(&sb, "length %d ", ccb->csio.dxfer_len);