Re: git: 28f66935d400 - main - tests: Disable sys/compat32 and sys/compat32/aarch64 tests

On Mon, 15 May 2023, Jessica Clarke wrote:

> The branch main has been updated by jrtc27:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=28f66935d400eb3fb52f4e64931c0cb3c9d24be4
>
> commit 28f66935d400eb3fb52f4e64931c0cb3c9d24be4
> Author:     Jessica Clarke <jrtc27@FreeBSD.org>
> AuthorDate: 2023-05-15 22:16:40 +0000
> Commit:     Jessica Clarke <jrtc27@FreeBSD.org>
> CommitDate: 2023-05-15 22:16:40 +0000
>
>    tests: Disable sys/compat32 and sys/compat32/aarch64 tests
>
>    The former has build system issues, with missing Kyuafiles, presumably
>    due to not using TESTS_SUBDIRS and bsd.test.mk (and possibly some issues
>    on top of that around TESTSDIR and related variables). The latter has
>    issues with GCC and cut-down LLVM builds.
>
>    Requested by:   kevans
>    Fixes:          ccb59683b983 ("arm64: add tests for swp/swpb emulation")
> ---
> tests/sys/compat32/Makefile         | 4 +++-
> tests/sys/compat32/aarch64/Makefile | 3 +++
> 2 files changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/tests/sys/compat32/Makefile b/tests/sys/compat32/Makefile
> index 31834de16246..3dd5ca218d00 100644
> --- a/tests/sys/compat32/Makefile
> +++ b/tests/sys/compat32/Makefile
> @@ -1,6 +1,8 @@
> -
> +# XXX: Currently broken in CI
> +.if 0
> .if exists(${.CURDIR}/${MACHINE_ARCH})
> SUBDIR+=	${MACHINE_ARCH}
> .endif
>
> .include <bsd.subdir.mk>
> +.endif
> diff --git a/tests/sys/compat32/aarch64/Makefile b/tests/sys/compat32/aarch64/Makefile
> index 716182b15d9c..f5961b06cc8b 100644
> --- a/tests/sys/compat32/aarch64/Makefile
> +++ b/tests/sys/compat32/aarch64/Makefile
> @@ -1,3 +1,5 @@
> +# XXX: Doesn't work with GCC and requires an LLVM with the ARM backend
> +.if 0
> PACKAGE=	tests
> FILESGROUPS+=	asmprogs
>
> @@ -22,3 +24,4 @@ ${aprog}: ${aprog}.S
> .endfor
>
> .include <bsd.test.mk>
> +.endif
>

My build just failed on:
root@fbsd14:/usr/src # git rev-parse --short HEAD
28f66935d400

...

===> tests/sys/compat32 (cleandir)
make[5]: don't know how to make cleandir. Stop

make[5]: stopped in /usr/src/tests/sys/compat32
*** Error code 2

Stop.
make[4]: stopped in /usr/src/tests/sys
*** Error code 1

Stop.
make[3]: stopped in /usr/src/tests
*** Error code 1

Stop.
make[2]: stopped in /usr/src
        57.80 real        41.64 user         0.00 sys
*** Error code 1

Stop.
make[1]: stopped in /usr/src
*** Error code 1