Re: git: 4849767cb16a - main - md5: Improve compatibility.
- In reply to: Dag-Erling Smørgrav : "git: 4849767cb16a - main - md5: Improve compatibility."
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Tue, 09 May 2023 06:34:18 UTC
On Mon, May 8, 2023 at 4:05 PM Dag-Erling Smørgrav <des@freebsd.org> wrote:
>
> The branch main has been updated by des:
>
> URL: https://cgit.FreeBSD.org/src/commit/?id=4849767cb16a4dbd4d1b923db25d34029c09e7b0
>
> commit 4849767cb16a4dbd4d1b923db25d34029c09e7b0
> Author: Dag-Erling Smørgrav <des@FreeBSD.org>
> AuthorDate: 2023-05-08 06:56:09 +0000
> Commit: Dag-Erling Smørgrav <des@FreeBSD.org>
> CommitDate: 2023-05-08 06:56:22 +0000
>
> md5: Improve compatibility.
>
> * Overhaul the GNU compatibility mode to more closely emulate what the GNU tools do.
>
> * Add a Perl compatibility mode which emulates the shasum tool that ships with Perl. This is currently not installed.
>
> * Overhaul the tests.
>
> Sponsored by: Klara, Inc.
> Reviewed by: kevans
> Differential Revision: https://reviews.freebsd.org/D39446
gcc12 reports:
/workspace/src/sbin/md5/md5.c: In function 'MDInput':
/workspace/src/sbin/md5/md5.c:737:17: error: comparison of unsigned
expression in '< 0' is always false [-Werror=type-limits]
737 | if (len < 0) {
| ^
(From https://ci.freebsd.org/job/FreeBSD-main-amd64-gcc12_build/950/console )
Not sure if this can be changed to `len <= 0`, or just remove this
part. Can you check it? Thanks!
Best,
Li-Wen