From nobody Fri May 05 15:00:04 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4QCYl367WBz49QWD; Fri, 5 May 2023 15:00:15 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QCYl35jsTz3qjk; Fri, 5 May 2023 15:00:15 +0000 (UTC) (envelope-from kevans@freebsd.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683298815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D0dpFP8H0QRsCvptg6bdBiLGIP7VK2b48IMm41OKCuU=; b=fMPVeMCA3rh6tDWqE8JN5E9N0TxtUprCuLe14rrc5oVCcvqloPncfHKecJ348iNpW2XP9H 4yZ4Owz23anIRXtxCFeokqyE0pozf+nftptJMWGEzAH0J6+IgD/IzOXAEJ6GI4puzTtt/J NZOa3OiQAjGAjfzLxMl/BQu+s3vaSkAxwcT/hATCOdqC+eBd4gBfcbHjaRCD5YkL9LfVq/ uY+jwN3MoFM4QrxuHvNYso4iGsfXpDaCnWrr/7sNVVn7Y5fbVXNEZjszcWixzUfhjDc8RR NVButj4K8GBedH7J0HpMyjBHtry7SINxh+WtNvZivD/rTvUh5FRqFGauVV8/NQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1683298815; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=D0dpFP8H0QRsCvptg6bdBiLGIP7VK2b48IMm41OKCuU=; b=repiJVCC4MdkpR5sWHV5B80PDO7aZqM8VXt8PC3LVA9tWjdqw5nzBk5Xn3y9q+eYNPPA3Y GXIMwXId1PDsIpY2m5Bx9tf45mmdy3zZ0Gsno5D6TtlSpeFFJU6ySBd+aNjnU/4tHUCDz1 JQQPhhRXxukM6AG60ATjiXfWPXLOFlShyUq2/kDhaR0pIJiAuV3+dHZ93fhX+vucADN5Zu tx4pS94Is6tZHiB1isaL1EP/c76ZzL6N8Gjvn2PzWn0va8+SeWs9pFbeWtNTq2z94rUQhc zzKH2sNI3ZOrTS8hmW2eKsYu8oGx33rUZqfbwJM9R/gZanLoH+xNqs6uk+nIxw== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1683298815; a=rsa-sha256; cv=none; b=ZrQNQC1urPL405/2c5HcppvrOx3l7HRa1bHSx0vlpDwHXVBuIzS+btzaxIWUdiyjpeRXD9 BZP7lYNp9iw71BYOkGfzvHw+R2J+U2VsRvxzcg0XYJqwE9BNUx9fqxHrFCBFjLylTTwOy/ RVFxjMzjxqYsKQl+0qGJfaAdQt/B4UZ/m4+uoJNWtPN4CuDnQA9PbY+AckTti5m2IXK41n 3sfT7JgR1Gb377UvSShOT65w3iKYxQcxS5f9qZ6TapTAjLinLmP1xlJPUcNGGnavlKzQAI Y/To37hp4qhoAhhgID1QMzMhn1e4DEz7rXZQKXMhkGEnegJ6NYh2vVktCaXKAA== Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1D4" (verified OK)) (Authenticated sender: kevans) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QCYl34k8pzRrx; Fri, 5 May 2023 15:00:15 +0000 (UTC) (envelope-from kevans@freebsd.org) Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-74fbf99adc2so84520385a.3; Fri, 05 May 2023 08:00:15 -0700 (PDT) X-Gm-Message-State: AC+VfDwsSQbwXCWRl2aGIE+4p4LQacWuP6VWnV6I3cV+geRWHbvnhD4N GZZtJpH8IOFC6jJy+vc99dpKPeRyJhdxz2ZJ6AE= X-Google-Smtp-Source: ACHHUZ44ZrmQx6+OREmzGa6fY3O5x18R7wtfDycdhrsfmYvx/p4lZEYjXZyk4ZNkDbVZACIEq0HRsKbePIhP9wQwevA= X-Received: by 2002:a05:6214:c47:b0:5ce:7b40:89bd with SMTP id r7-20020a0562140c4700b005ce7b4089bdmr2050815qvj.18.1683298815234; Fri, 05 May 2023 08:00:15 -0700 (PDT) List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 References: <202304140513.33E5DsXL019547@gitrepo.freebsd.org> <20230505105935.c2e6df2864b7a9ab6c6fef81@bidouilliste.com> In-Reply-To: <20230505105935.c2e6df2864b7a9ab6c6fef81@bidouilliste.com> From: Kyle Evans Date: Fri, 5 May 2023 10:00:04 -0500 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: git: 8935a3993219 - main - daemon: use kqueue for all events To: Emmanuel Vadot Cc: ihor@antonovs.family, src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-ThisMailContainsUnwantedMimeParts: N On Fri, May 5, 2023 at 3:59=E2=80=AFAM Emmanuel Vadot wrote: > > > Hello, > > On Fri, 14 Apr 2023 05:13:54 GMT > Kyle Evans wrote: > > > The branch main has been updated by kevans: > > > > URL: https://cgit.FreeBSD.org/src/commit/?id=3D8935a3993219be76c7ea03e9= ad4509657d08af6c > > > > commit 8935a3993219be76c7ea03e9ad4509657d08af6c > > Author: Ihor Antonov > > AuthorDate: 2023-04-14 05:10:29 +0000 > > Commit: Kyle Evans > > CommitDate: 2023-04-14 05:12:21 +0000 > > > > daemon: use kqueue for all events > > > > Refactor daemon to use kqueue/kevent instead of signals. > > > > This changes allows to simplify the code in several ways: > > - the execution flow is now linear, no async events. > > - several variables became redundant and got removed. > > - all event handling is now concentrated inside of the event loop, = which > > makes code reading and comprehension easier. > > - new kqueuex(2) call is used for CLOEXEC, but maintained closing t= he > > kq fd prior to execve() to ease later MFC > > > > No UX/API changes are intended. > > > > Reviewed by: kevans > > Pull Request: https://github.com/freebsd/freebsd-src/pull/701 > > This break sysutils/seatd when we resume and leaves the console is a > really sad state (impossible to use, keystroke don't match). > Don't really know how to properly debug but : > > 1/ Reverting the commit make seatd not exiting on resume (and so sway > doesn't exit). > 2/ If I start seatd without daemon it works > 3/ If I manually start saetd with daemon in tmux with > "daemon -s debug -T seatd -p /var/run/seatd.pid /usr/local/bin/seatd > -g video" (so same thing as the rc script) I see > "daemon: kevent wait: Interrupted system call" printed when I get back > network. > > Feel free to ask me any test you want to debug further ;) > Can you check if this is sufficient? https://people.freebsd.org/~kevans/daemon-kq.diff We shouldn't bail out if were simply interrupted, presumably we just want to resume waiting for an event. Thanks, Kyle Evans