From nobody Mon May 01 14:09:58 2023 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4Q94pt4xXqz48ZsY; Mon, 1 May 2023 14:09:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Q94pt4G43z3PGF; Mon, 1 May 2023 14:09:58 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682950198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hjDwiRh8RloamFxaD8w+YDkk4wAOINhIZxHZtsg5oW0=; b=fXwu16WQ6Vplm1mgEL448JnJxcJ08XyKGAST72bDm+CTuy9nZGcH6OxH3gsPOvD0nKktQU WiFn4QWuvGk6Mb+8UtyjYHtQ7ODBFMqETnkzFFOP33y2sbrfdoSuyC05NXA9ikUbRM26sH DUkdwuEmGTYYpeOEJDBThXzuWThK27/SA4GfM7gVyybP2/29Ps2YPScjQiaFhMaphAu2KY UkBZNwn46aj87FmBYCuB5TBqKwgYjsG+QfXo1zLUm+UMpJXTBi8wOl9UB/2ehqewmoE/qU YS8uWwOhokPR5M3vPPcYIjf5ap2GgrATEcfR99sP491zNxUuynkBCb7Ddm+yLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1682950198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=hjDwiRh8RloamFxaD8w+YDkk4wAOINhIZxHZtsg5oW0=; b=fvSdtjLeyi/RCloBTwnfRPMaKLExc/BwWPvalPrN7cN4cZky4JrIuJOyeI8Fmu901mmLon T3Kp5k+U+YkmOn9qv4RHqaAQ8XFj5sLHO8IhvANWVn5v0khmFzFXvN3qwM+nhYJ+ewTUJh Eq5hSnGa7ZPO6B0nnakGG03QC1CFrA86Ei7kvXh+Qf5aJumP4voA6SmDYsYoawkakNJFWc jW3HMS212srXF0kbep5f5LZB7Kj7kHTm4tFzwn4DP1rH9yz+HExBaklHkA4WN7asWQCemK ejT4c82w40qDEcwKJ1ob3fq6VRC2nDcCKyRY3Hwf4f2ZHQ2cGNnGIxJ8dJzYoQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1682950198; a=rsa-sha256; cv=none; b=eRGiqKUFQR+VJ2jRf6UGKPonAoOWo1x5N96CKJnxydfDo2FHIlcevcxje2hdztZ5OXlNrC VRjAV0tTvl2sV+PhqD6sfnfnE5HVmihW4tiAjL+Jp7I/MxkMluR8gYkyWuIYo9uoq91TDk H7h5hkezCdApFucEbFhmWJUcABUcPJ8i3no8eXqukro+DevMRHWO7bT6p84JrqHTq3lsuM IFfa8doyO1qHDUVPSnQLrGPR2VZ4hZR4vV52zrWi9jQV2Uf2udSA8xOSW3PJUxzUarM6ja Xtxpde9Lk5fNlkvQw61/xYs/6XKQp9LJOO/Pp4c+MGF0oNaOx9MqoZ7NyDoCXQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4Q94pt3LRxz17SL; Mon, 1 May 2023 14:09:58 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.16.1/8.16.1) with ESMTP id 341E9waw057674; Mon, 1 May 2023 14:09:58 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.16.1/8.16.1/Submit) id 341E9wop057673; Mon, 1 May 2023 14:09:58 GMT (envelope-from git) Date: Mon, 1 May 2023 14:09:58 GMT Message-Id: <202305011409.341E9wop057673@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: "Alexander V. Chernikov" Subject: git: 6a09a7f1e9a5 - main - netlink: always zero provided header buffers. List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: Sender: owner-dev-commits-src-main@freebsd.org X-BeenThere: dev-commits-src-main@freebsd.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: melifaro X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 6a09a7f1e9a52fb25158ca60216c6b817f8c0b71 Auto-Submitted: auto-generated X-ThisMailContainsUnwantedMimeParts: N The branch main has been updated by melifaro: URL: https://cgit.FreeBSD.org/src/commit/?id=6a09a7f1e9a52fb25158ca60216c6b817f8c0b71 commit 6a09a7f1e9a52fb25158ca60216c6b817f8c0b71 Author: Alexander V. Chernikov AuthorDate: 2023-05-01 14:07:33 +0000 Commit: Alexander V. Chernikov CommitDate: 2023-05-01 14:09:47 +0000 netlink: always zero provided header buffers. Reported by: KMSAN MFC after: 3 days --- sys/netlink/netlink_message_writer.h | 1 + sys/netlink/route/neigh.c | 3 --- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/sys/netlink/netlink_message_writer.h b/sys/netlink/netlink_message_writer.h index 57fc1bf342ea..92e43834efc7 100644 --- a/sys/netlink/netlink_message_writer.h +++ b/sys/netlink/netlink_message_writer.h @@ -225,6 +225,7 @@ nlmsg_reserve_data_raw(struct nl_writer *nw, size_t sz) void *data_ptr = &nw->data[nw->offset]; nw->offset += sz; + bzero(data_ptr, sz); return (data_ptr); } diff --git a/sys/netlink/route/neigh.c b/sys/netlink/route/neigh.c index 807c125cc3f0..db72bc9bfd4e 100644 --- a/sys/netlink/route/neigh.c +++ b/sys/netlink/route/neigh.c @@ -156,12 +156,9 @@ dump_lle_locked(struct llentry *lle, void *arg) ndm = nlmsg_reserve_object(nw, struct ndmsg); ndm->ndm_family = wa->family; - ndm->ndm_pad1 = 0; - ndm->ndm_pad2 = 0; ndm->ndm_ifindex = wa->ifp->if_index; ndm->ndm_state = lle_state_to_nl_state(wa->family, lle); ndm->ndm_flags = lle_flags_to_nl_flags(lle); - ndm->ndm_type = 0; switch (wa->family) { #ifdef INET