Re: git: a85dcd4ac4b0 - main - netlink: restrict default userland switch to netlink to i386/amd64.
- Reply: Warner Losh : "Re: git: a85dcd4ac4b0 - main - netlink: restrict default userland switch to netlink to i386/amd64."
- In reply to: Ed Maste : "Re: git: a85dcd4ac4b0 - main - netlink: restrict default userland switch to netlink to i386/amd64."
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Sun, 26 Mar 2023 16:45:07 UTC
On 26 Mar 2023, at 17:17, Ed Maste <emaste@freebsd.org> wrote: > > > On Sun, 26 Mar 2023 at 07:07, Alexander V. Chernikov > <melifaro@freebsd.org> wrote: >> >> The branch main has been updated by melifaro: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=a85dcd4ac4b0612b63b5a71eeaaa707a09ae0003 >> >> commit a85dcd4ac4b0612b63b5a71eeaaa707a09ae0003 >> Author: Alexander V. Chernikov <melifaro@FreeBSD.org> >> AuthorDate: 2023-03-26 11:05:21 +0000 >> Commit: Alexander V. Chernikov <melifaro@FreeBSD.org> >> CommitDate: 2023-03-26 11:06:53 +0000 >> >> netlink: restrict default userland switch to netlink to i386/amd64. > > We should keep default options the same for all Tier-1 architectures, > so amd64 and arm64 should be in sync. But also, what’s the technical justification for this change? There should not be gratuitous differences between architectures like this, only when there is a reason something shouldn’t be enabled. Why should x86 (and possibly arm64) get netlink, but not arm/powerpc/riscv? We have very few machine-dependent defaults in src.opts.mk. If there is no such justification then please revert this in its entirety, and if there is such a justification it belongs in a comment above the if. Jess