Re: git: c581962414ed - main - src.conf.5: Add some WITH_/WITHOUT_ option descriptions

From: Warner Losh <imp_at_bsdimp.com>
Date: Wed, 08 Mar 2023 23:38:31 UTC
On Wed, Mar 8, 2023, 3:34 PM John Baldwin <jhb@freebsd.org> wrote:

> On 3/8/23 3:31 PM, Ed Maste wrote:
> > The branch main has been updated by emaste:
> >
> > URL:
> https://cgit.FreeBSD.org/src/commit/?id=c581962414edfc26796319ccc988647b08b03ce1
> >
> > commit c581962414edfc26796319ccc988647b08b03ce1
> > Author:     Ed Maste <emaste@FreeBSD.org>
> > AuthorDate: 2023-03-07 18:49:23 +0000
> > Commit:     Ed Maste <emaste@FreeBSD.org>
> > CommitDate: 2023-03-08 23:30:45 +0000
> >
> >      src.conf.5: Add some WITH_/WITHOUT_ option descriptions
> >
> >      Reviewed by:    markj, brooks
> >      Sponsored by:   The FreeBSD Foundation
> >      Differential Revision: https://reviews.freebsd.org/D38961
>
> Hah, I was just working on those, but I noticed that we don't have
> duplicate WITH/WITHOUT options for other options so kind of punted.
>
> The description for WITHOUT_OFED can be slightly simplified to use
> the "Do not build..." pattern which is the more common idiom btw.
>

I've always wondered why we need both... can't we just have a generic
description?

Warner

>