git: 9a9a24896469 - main - bhyve: init checkput before caph_enter
- Go to: [ bottom of page ] [ top of archives ] [ this month ]
Date: Mon, 06 Mar 2023 13:05:31 UTC
The branch main has been updated by corvink:
URL: https://cgit.FreeBSD.org/src/commit/?id=9a9a248964696f45260ea026aa5f9174cc86b137
commit 9a9a248964696f45260ea026aa5f9174cc86b137
Author: Vitaliy Gusev <gusev.vitaliy@gmail.com>
AuthorDate: 2023-03-06 12:35:21 +0000
Commit: Corvin Köhne <corvink@FreeBSD.org>
CommitDate: 2023-03-06 13:04:21 +0000
bhyve: init checkput before caph_enter
init_checkpoint_thread binds to a socket. Bhyve isn't allowed to do that
after caph_enter.
Reviewed by: corvink, markj
MFC after: 1 week
Sponsored by: vStack
Differential Revision: https://reviews.freebsd.org/D38857
---
usr.sbin/bhyve/bhyverun.c | 20 +++++++++++---------
1 file changed, 11 insertions(+), 9 deletions(-)
diff --git a/usr.sbin/bhyve/bhyverun.c b/usr.sbin/bhyve/bhyverun.c
index 0c4aef70b2a9..af4d15666ae3 100644
--- a/usr.sbin/bhyve/bhyverun.c
+++ b/usr.sbin/bhyve/bhyverun.c
@@ -1562,6 +1562,17 @@ main(int argc, char *argv[])
*/
setproctitle("%s", vmname);
+#ifdef BHYVE_SNAPSHOT
+ /* initialize mutex/cond variables */
+ init_snapshot();
+
+ /*
+ * checkpointing thread for communication with bhyvectl
+ */
+ if (init_checkpoint_thread(ctx) != 0)
+ errx(EX_OSERR, "Failed to start checkpoint thread");
+#endif
+
#ifndef WITHOUT_CAPSICUM
caph_cache_catpages();
@@ -1573,15 +1584,6 @@ main(int argc, char *argv[])
#endif
#ifdef BHYVE_SNAPSHOT
- /* initialize mutex/cond variables */
- init_snapshot();
-
- /*
- * checkpointing thread for communication with bhyvectl
- */
- if (init_checkpoint_thread(ctx) != 0)
- errx(EX_OSERR, "Failed to start checkpoint thread");
-
if (restore_file != NULL) {
destroy_restore_state(&rstate);
if (vm_restore_time(ctx) < 0)