Re: git: 3cbc8e752b92 - main - tftpd: fix double-colon typo in option string

On 7/20/23 16:28, Dmitry Morozovsky wrote:
> The branch main has been updated by marck:
> 
> URL: https://cgit.FreeBSD.org/src/commit/?id=3cbc8e752b92442c784306731e94fd904de3373c
> 
> commit 3cbc8e752b92442c784306731e94fd904de3373c
> Author:     Dmitry Morozovsky <marck@FreeBSD.org>
> AuthorDate: 2023-07-20 21:24:28 +0000
> Commit:     Dmitry Morozovsky <marck@FreeBSD.org>
> CommitDate: 2023-07-20 21:24:28 +0000
> 
>      tftpd: fix double-colon typo in option string
>      
>      MFC after:      1 month
>      X-MFC-With:     273a307d0b80743fb08e23237b3f74dc94a8fa2a
>      X-MFC-With:     03c2616dc530e5b23f06f9aa421012154590e578

Er, this wasn't a bug. -d takes an optional argument, which is indicated 
with a double colon.

Thanks,

Kyle Evans

> ---
>   libexec/tftpd/tftpd.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libexec/tftpd/tftpd.c b/libexec/tftpd/tftpd.c
> index 1c04cd113932..27bb7cb4cc67 100644
> --- a/libexec/tftpd/tftpd.c
> +++ b/libexec/tftpd/tftpd.c
> @@ -142,7 +142,7 @@ main(int argc, char *argv[])
>   	acting_as_client = 0;
>   
>   	tftp_openlog("tftpd", LOG_PID | LOG_NDELAY, LOG_FTP);
> -	while ((ch = getopt(argc, argv, "cCd::F:lnoOp:s:Su:U:wW")) != -1) {
> +	while ((ch = getopt(argc, argv, "cCd:F:lnoOp:s:Su:U:wW")) != -1) {
>   		switch (ch) {
>   		case 'c':
>   			ipchroot = 1;